Bug 38596

Summary: DataTable - previous order sequence behaviour not restored at the OPAC
Product: Koha Reporter: Jonathan Druart <jonathan.druart>
Component: OPACAssignee: Jonathan Druart <jonathan.druart>
Status: Pushed to stable --- QA Contact: Marcel de Rooy <m.de.rooy>
Severity: normal    
Priority: P5 - low CC: alexbuckley, david, m.de.rooy
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
This fixes the display of the ordering arrows in OPAC table heading rows so that the sort options are ascending (the down arrow), and descending (the up arrow). It removes an incorrect intermediate stage where no arrows were highlighted. (This is related to the upgrade to DataTables 2.x in Koha 24.11.)
Version(s) released in:
25.05.00,24.11.02
Circulation function:
Bug Depends on: 36640    
Bug Blocks: 38255    
Attachments: Bug 38596: (bug 36640 follow-up): Restore previous order sequence behaviour - OPAC
Bug 38596: (bug 36640 follow-up): Restore previous order sequence behaviour - OPAC
Bug 38596: (bug 36640 follow-up): Restore previous order sequence behaviour - OPAC
Bug 38596: (bug 36640 follow-up): Restore previous order sequence behaviour - OPAC

Description Jonathan Druart 2024-12-02 11:48:04 UTC
See

commit e76c5c0145f1575254603ba507fbea339cfb4e82
Author: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Date:   Thu Oct 31 10:50:20 2024 +0100

    Bug 36640: Restore previous order sequence behaviour
Comment 1 Jonathan Druart 2024-12-02 11:49:56 UTC
Created attachment 175050 [details] [review]
Bug 38596: (bug 36640 follow-up): Restore previous order sequence behaviour - OPAC

See commit e76c5c0145f1575254603ba507fbea339cfb4e82
    Bug 36640: Restore previous order sequence behaviour

Test plan:
Go to http://localhost:8080/cgi-bin/koha/opac-detail.pl?biblionumber=1
Click on the header to modify the order, click again, then again.
It should always be asc or desc, and you should see the corresponding
arrows.
Comment 2 David Nind 2024-12-03 04:01:18 UTC
The patch no longer applies 8-(..
Comment 3 Jonathan Druart 2024-12-04 13:43:52 UTC
Created attachment 175180 [details] [review]
Bug 38596: (bug 36640 follow-up): Restore previous order sequence behaviour - OPAC

See commit e76c5c0145f1575254603ba507fbea339cfb4e82
    Bug 36640: Restore previous order sequence behaviour

Test plan:
Go to http://localhost:8080/cgi-bin/koha/opac-detail.pl?biblionumber=1
Click on the header to modify the order, click again, then again.
It should always be asc or desc, and you should see the corresponding
arrows.
Comment 4 David Nind 2024-12-04 22:45:55 UTC
Created attachment 175211 [details] [review]
Bug 38596: (bug 36640 follow-up): Restore previous order sequence behaviour - OPAC

See commit e76c5c0145f1575254603ba507fbea339cfb4e82
    Bug 36640: Restore previous order sequence behaviour

Test plan:
Go to http://localhost:8080/cgi-bin/koha/opac-detail.pl?biblionumber=1
Click on the header to modify the order, click again, then again.
It should always be asc or desc, and you should see the corresponding
arrows.

Signed-off-by: David Nind <david@davidnind.com>
Comment 5 Marcel de Rooy 2024-12-13 10:36:54 UTC
Created attachment 175443 [details] [review]
Bug 38596: (bug 36640 follow-up): Restore previous order sequence behaviour - OPAC

See commit e76c5c0145f1575254603ba507fbea339cfb4e82
    Bug 36640: Restore previous order sequence behaviour

Test plan:
Go to http://localhost:8080/cgi-bin/koha/opac-detail.pl?biblionumber=1
Click on the header to modify the order, click again, then again.
It should always be asc or desc, and you should see the corresponding
arrows.

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 6 Katrin Fischer 2024-12-23 08:38:26 UTC
Pushed for 25.05!

Well done everyone, thank you!
Comment 7 Paul Derscheid 2025-02-03 19:09:33 UTC
Nice work everyone!

Pushed to 24.11.x for 24.11.01
Comment 8 Alex Buckley 2025-02-20 20:50:01 UTC
not backporting to 24.05.x unless requested - dependency not in 24.05