Bug 38596 - DataTable - previous order sequence behaviour not restored at the OPAC
Summary: DataTable - previous order sequence behaviour not restored at the OPAC
Status: Pushed to stable
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Jonathan Druart
QA Contact: Marcel de Rooy
URL:
Keywords:
Depends on: 36640
Blocks: 38255
  Show dependency treegraph
 
Reported: 2024-12-02 11:48 UTC by Jonathan Druart
Modified: 2025-02-03 19:09 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
This fixes the display of the ordering arrows in OPAC table heading rows so that the sort options are ascending (the down arrow), and descending (the up arrow). It removes an incorrect intermediate stage where no arrows were highlighted. (This is related to the upgrade to DataTables 2.x in Koha 24.11.)
Version(s) released in:
25.05.00,24.11.02
Circulation function:


Attachments
Bug 38596: (bug 36640 follow-up): Restore previous order sequence behaviour - OPAC (1.28 KB, patch)
2024-12-02 11:49 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 38596: (bug 36640 follow-up): Restore previous order sequence behaviour - OPAC (1.13 KB, patch)
2024-12-04 13:43 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 38596: (bug 36640 follow-up): Restore previous order sequence behaviour - OPAC (1.17 KB, patch)
2024-12-04 22:45 UTC, David Nind
Details | Diff | Splinter Review
Bug 38596: (bug 36640 follow-up): Restore previous order sequence behaviour - OPAC (1.27 KB, patch)
2024-12-13 10:36 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2024-12-02 11:48:04 UTC
See

commit e76c5c0145f1575254603ba507fbea339cfb4e82
Author: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Date:   Thu Oct 31 10:50:20 2024 +0100

    Bug 36640: Restore previous order sequence behaviour
Comment 1 Jonathan Druart 2024-12-02 11:49:56 UTC
Created attachment 175050 [details] [review]
Bug 38596: (bug 36640 follow-up): Restore previous order sequence behaviour - OPAC

See commit e76c5c0145f1575254603ba507fbea339cfb4e82
    Bug 36640: Restore previous order sequence behaviour

Test plan:
Go to http://localhost:8080/cgi-bin/koha/opac-detail.pl?biblionumber=1
Click on the header to modify the order, click again, then again.
It should always be asc or desc, and you should see the corresponding
arrows.
Comment 2 David Nind 2024-12-03 04:01:18 UTC
The patch no longer applies 8-(..
Comment 3 Jonathan Druart 2024-12-04 13:43:52 UTC
Created attachment 175180 [details] [review]
Bug 38596: (bug 36640 follow-up): Restore previous order sequence behaviour - OPAC

See commit e76c5c0145f1575254603ba507fbea339cfb4e82
    Bug 36640: Restore previous order sequence behaviour

Test plan:
Go to http://localhost:8080/cgi-bin/koha/opac-detail.pl?biblionumber=1
Click on the header to modify the order, click again, then again.
It should always be asc or desc, and you should see the corresponding
arrows.
Comment 4 David Nind 2024-12-04 22:45:55 UTC
Created attachment 175211 [details] [review]
Bug 38596: (bug 36640 follow-up): Restore previous order sequence behaviour - OPAC

See commit e76c5c0145f1575254603ba507fbea339cfb4e82
    Bug 36640: Restore previous order sequence behaviour

Test plan:
Go to http://localhost:8080/cgi-bin/koha/opac-detail.pl?biblionumber=1
Click on the header to modify the order, click again, then again.
It should always be asc or desc, and you should see the corresponding
arrows.

Signed-off-by: David Nind <david@davidnind.com>
Comment 5 Marcel de Rooy 2024-12-13 10:36:54 UTC
Created attachment 175443 [details] [review]
Bug 38596: (bug 36640 follow-up): Restore previous order sequence behaviour - OPAC

See commit e76c5c0145f1575254603ba507fbea339cfb4e82
    Bug 36640: Restore previous order sequence behaviour

Test plan:
Go to http://localhost:8080/cgi-bin/koha/opac-detail.pl?biblionumber=1
Click on the header to modify the order, click again, then again.
It should always be asc or desc, and you should see the corresponding
arrows.

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 6 Katrin Fischer 2024-12-23 08:38:26 UTC
Pushed for 25.05!

Well done everyone, thank you!
Comment 7 Paul Derscheid 2025-02-03 19:09:33 UTC
Nice work everyone!

Pushed to 24.11.x for 24.11.01