Summary: | Obsolete call on system preference 'OPACLocalCoverImagesPriority' | ||
---|---|---|---|
Product: | Koha | Reporter: | Fridolin Somers <fridolin.somers> |
Component: | Architecture, internals, and plumbing | Assignee: | Fridolin Somers <fridolin.somers> |
Status: | Pushed to oldoldstable --- | QA Contact: | Marcel de Rooy <m.de.rooy> |
Severity: | minor | ||
Priority: | P5 - low | CC: | david, m.de.rooy, wainuiwitikapark |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: |
This fixes the OPAC search results page by removing a call to system preference OPACLocalCoverImagesPriority - this system preference no longer exists. (There is no visible difference to the OPAC search results page.)
|
Version(s) released in: |
25.05.00,24.11.02,24.05.09,23.11.14
|
Circulation function: | |||
Attachments: |
Bug 38653: Remove call on system preference 'OPACLocalCoverImagesPriority'
Bug 38653: Remove call on system preference 'OPACLocalCoverImagesPriority' Bug 38653: Remove call on system preference 'OPACLocalCoverImagesPriority' |
Description
Fridolin Somers
2024-12-09 11:46:17 UTC
Created attachment 175298 [details] [review] Bug 38653: Remove call on system preference 'OPACLocalCoverImagesPriority' This is in opac/opac-search.pl a call on system preference OPACLocalCoverImagesPriority. This preference does not exists elsewhere and dates back to Koha 3.8 from Bug 1633 This patch removes the call and fixes folding of if. Check this returns empty : git grep OPACLocalCoverImagesPriority Created attachment 175299 [details] [review] Bug 38653: Remove call on system preference 'OPACLocalCoverImagesPriority' This is in opac/opac-search.pl a call on system preference OPACLocalCoverImagesPriority. This preference does not exists elsewhere and dates back to Koha 3.8 from Bug 1633 This patch removes the call and fixes folding of if. Check this returns empty : git grep OPACLocalCoverImagesPriority Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 175446 [details] [review] Bug 38653: Remove call on system preference 'OPACLocalCoverImagesPriority' This is in opac/opac-search.pl a call on system preference OPACLocalCoverImagesPriority. This preference does not exists elsewhere and dates back to Koha 3.8 from Bug 1633 This patch removes the call and fixes folding of if. Check this returns empty : git grep OPACLocalCoverImagesPriority Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Pushed for 25.05! Well done everyone, thank you! This is in the commit log for 24.11, though not noted here yet. Not backporting to 24.05.x unless requested (In reply to Wainui Witika-Park from comment #5) > This is in the commit log for 24.11, though not noted here yet. > > Not backporting to 24.05.x unless requested Actually changed my mind Applied to 24.05.x for 24.05.09 I see it is in 24.11.02 (stable) Pushed to 23.11.x for 23.11.14 |