Bug 38653

Summary: Obsolete call on system preference 'OPACLocalCoverImagesPriority'
Product: Koha Reporter: Fridolin Somers <fridolin.somers>
Component: Architecture, internals, and plumbingAssignee: Fridolin Somers <fridolin.somers>
Status: Pushed to oldoldstable --- QA Contact: Marcel de Rooy <m.de.rooy>
Severity: minor    
Priority: P5 - low CC: david, m.de.rooy, wainuiwitikapark
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
This fixes the OPAC search results page by removing a call to system preference OPACLocalCoverImagesPriority - this system preference no longer exists. (There is no visible difference to the OPAC search results page.)
Version(s) released in:
25.05.00,24.11.02,24.05.09,23.11.14
Circulation function:
Attachments: Bug 38653: Remove call on system preference 'OPACLocalCoverImagesPriority'
Bug 38653: Remove call on system preference 'OPACLocalCoverImagesPriority'
Bug 38653: Remove call on system preference 'OPACLocalCoverImagesPriority'

Description Fridolin Somers 2024-12-09 11:46:17 UTC
This is in opac/opac-search.pl a call on system preference OPACLocalCoverImagesPriority.
This preference does not exists elsewhere and dates back to Koha 3.8 from Bug 1633

I propose to remove ;)
Comment 1 Fridolin Somers 2024-12-09 11:50:11 UTC
Created attachment 175298 [details] [review]
Bug 38653: Remove call on system preference 'OPACLocalCoverImagesPriority'

This is in opac/opac-search.pl a call on system preference OPACLocalCoverImagesPriority.
This preference does not exists elsewhere and dates back to Koha 3.8 from Bug 1633

This patch removes the call and fixes folding of if.

Check this returns empty : git grep OPACLocalCoverImagesPriority
Comment 2 Owen Leonard 2024-12-09 12:04:30 UTC
Created attachment 175299 [details] [review]
Bug 38653: Remove call on system preference 'OPACLocalCoverImagesPriority'

This is in opac/opac-search.pl a call on system preference
OPACLocalCoverImagesPriority. This preference does not exists elsewhere
and dates back to Koha 3.8 from Bug 1633

This patch removes the call and fixes folding of if.

Check this returns empty : git grep OPACLocalCoverImagesPriority

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 3 Marcel de Rooy 2024-12-13 10:51:50 UTC
Created attachment 175446 [details] [review]
Bug 38653: Remove call on system preference 'OPACLocalCoverImagesPriority'

This is in opac/opac-search.pl a call on system preference
OPACLocalCoverImagesPriority. This preference does not exists elsewhere
and dates back to Koha 3.8 from Bug 1633

This patch removes the call and fixes folding of if.

Check this returns empty : git grep OPACLocalCoverImagesPriority

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 4 Katrin Fischer 2024-12-23 09:37:57 UTC
Pushed for 25.05!

Well done everyone, thank you!
Comment 5 Wainui Witika-Park 2025-04-10 05:02:52 UTC
This is in the commit log for 24.11, though not noted here yet.

Not backporting to 24.05.x unless requested
Comment 6 Wainui Witika-Park 2025-04-17 06:11:50 UTC
(In reply to Wainui Witika-Park from comment #5)
> This is in the commit log for 24.11, though not noted here yet.
> 
> Not backporting to 24.05.x unless requested

Actually changed my mind

Applied to 24.05.x for 24.05.09
Comment 7 Fridolin Somers 2025-04-24 08:17:56 UTC
I see it is in 24.11.02 (stable)
Comment 8 Fridolin Somers 2025-04-24 08:19:49 UTC
Pushed to 23.11.x for 23.11.14