Bug 38653 - Obsolete call on system preference 'OPACLocalCoverImagesPriority'
Summary: Obsolete call on system preference 'OPACLocalCoverImagesPriority'
Status: Pushed to main
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor
Assignee: Fridolin Somers
QA Contact: Marcel de Rooy
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-12-09 11:46 UTC by Fridolin Somers
Modified: 2025-01-01 23:07 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
This fixes the OPAC search results page by removing a call to system preference OPACLocalCoverImagesPriority - this system preference no longer exists. (There is no visible difference to the OPAC search results page.)
Version(s) released in:
25.05.00
Circulation function:


Attachments
Bug 38653: Remove call on system preference 'OPACLocalCoverImagesPriority' (1.54 KB, patch)
2024-12-09 11:50 UTC, Fridolin Somers
Details | Diff | Splinter Review
Bug 38653: Remove call on system preference 'OPACLocalCoverImagesPriority' (1.59 KB, patch)
2024-12-09 12:04 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 38653: Remove call on system preference 'OPACLocalCoverImagesPriority' (1.68 KB, patch)
2024-12-13 10:51 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Fridolin Somers 2024-12-09 11:46:17 UTC
This is in opac/opac-search.pl a call on system preference OPACLocalCoverImagesPriority.
This preference does not exists elsewhere and dates back to Koha 3.8 from Bug 1633

I propose to remove ;)
Comment 1 Fridolin Somers 2024-12-09 11:50:11 UTC
Created attachment 175298 [details] [review]
Bug 38653: Remove call on system preference 'OPACLocalCoverImagesPriority'

This is in opac/opac-search.pl a call on system preference OPACLocalCoverImagesPriority.
This preference does not exists elsewhere and dates back to Koha 3.8 from Bug 1633

This patch removes the call and fixes folding of if.

Check this returns empty : git grep OPACLocalCoverImagesPriority
Comment 2 Owen Leonard 2024-12-09 12:04:30 UTC
Created attachment 175299 [details] [review]
Bug 38653: Remove call on system preference 'OPACLocalCoverImagesPriority'

This is in opac/opac-search.pl a call on system preference
OPACLocalCoverImagesPriority. This preference does not exists elsewhere
and dates back to Koha 3.8 from Bug 1633

This patch removes the call and fixes folding of if.

Check this returns empty : git grep OPACLocalCoverImagesPriority

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 3 Marcel de Rooy 2024-12-13 10:51:50 UTC
Created attachment 175446 [details] [review]
Bug 38653: Remove call on system preference 'OPACLocalCoverImagesPriority'

This is in opac/opac-search.pl a call on system preference
OPACLocalCoverImagesPriority. This preference does not exists elsewhere
and dates back to Koha 3.8 from Bug 1633

This patch removes the call and fixes folding of if.

Check this returns empty : git grep OPACLocalCoverImagesPriority

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 4 Katrin Fischer 2024-12-23 09:37:57 UTC
Pushed for 25.05!

Well done everyone, thank you!