Summary: | SIP not marking patrons expired unless NotifyBorrowerDeparture has a positive value | ||
---|---|---|---|
Product: | Koha | Reporter: | Nick Clemens (kidclamp) <nick> |
Component: | SIP2 | Assignee: | Matthias Meusburger <matthias.meusburger> |
Status: | Pushed to main --- | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | ||
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
25.05.00
|
|
Circulation function: | |||
Bug Depends on: | 25813 | ||
Bug Blocks: | |||
Attachments: |
Bug 38658: Display message for expired patrons in SIP when NotifyBorrowerDeparture is disabled
Bug 38658: Display message for expired patrons in SIP when NotifyBorrowerDeparture is disabled Bug 38658: Display message for expired patrons in SIP when NotifyBorrowerDeparture is disabled |
Description
Nick Clemens (kidclamp)
2024-12-09 19:45:52 UTC
Created attachment 175954 [details] [review] Bug 38658: Display message for expired patrons in SIP when NotifyBorrowerDeparture is disabled This patch restores the behavior that existed in SIP before Bug 25813 - Enhance patron expiration in SIP display: Always consider an expired patron as expired, even if NotifyBorrowerDeparture is set to 0 (disabled) or unset. Test plan: - Set NotifyBorrowerDeparture to 0 - Set a patron's expiry date to be in the past - Use misc/sip_cli_emulator.pl to display patron information: perl misc/sip_cli_emulator.pl -a localhost -p 6001 -su term1 -sp term1 -l CPL -t CR --patron <cardnumber> -m patron_information - Check that you have the following message (AF field): "Greetings from Koha. Your account has expired as of <expired date>" Please note that the behavior with NotifyBorrowerDeparture now differs in SIP and at the OPAC, where no warning is displayed to an expired patron when NotifyBorrowerDeparture is disabled or unset. To be fair, now that you've pointed it, I find it strange that the warning about being expired is not displayed at the OPAC when NotifyBorrowerDeparture is disabled or unset, but that can be the subject of another bug. Created attachment 176099 [details] [review] Bug 38658: Display message for expired patrons in SIP when NotifyBorrowerDeparture is disabled This patch restores the behavior that existed in SIP before Bug 25813 - Enhance patron expiration in SIP display: Always consider an expired patron as expired, even if NotifyBorrowerDeparture is set to 0 (disabled) or unset. Test plan: - Set NotifyBorrowerDeparture to 0 - Set a patron's expiry date to be in the past - Use misc/sip_cli_emulator.pl to display patron information: perl misc/sip_cli_emulator.pl -a localhost -p 6001 -su term1 -sp term1 -l CPL -t CR --patron <cardnumber> -m patron_information - Check that you have the following message (AF field): "Greetings from Koha. Your account has expired as of <expired date>" Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Created attachment 178103 [details] [review] Bug 38658: Display message for expired patrons in SIP when NotifyBorrowerDeparture is disabled This patch restores the behavior that existed in SIP before Bug 25813 - Enhance patron expiration in SIP display: Always consider an expired patron as expired, even if NotifyBorrowerDeparture is set to 0 (disabled) or unset. Test plan: - Set NotifyBorrowerDeparture to 0 - Set a patron's expiry date to be in the past - Use misc/sip_cli_emulator.pl to display patron information: perl misc/sip_cli_emulator.pl -a localhost -p 6001 -su term1 -sp term1 -l CPL -t CR --patron <cardnumber> -m patron_information - Check that you have the following message (AF field): "Greetings from Koha. Your account has expired as of <expired date>" Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Should this be a bug fix instead of an enhancement? Pushed for 25.05! Well done everyone, thank you! Hi Katrin, Yes, this is a bugfix. I've set it to "normal". |