Bug 25813 changed the way that SIP reports patron expiry. Prior to this bug patrons could eb marked as expired without setting this pref, now it requires a value. To recreate: 0 - Set NotifyBorrowerDeparture to 30 1 - Set a patron's expiry date to be in the past, I used Edna Acosta 2 - perl misc/sip_cli_emulator.pl -a localhost -p 6001 -su term1 -sp term1 -l CPL -t CR --patron 23529001000463 -m patron_information 3 - Note you are warned patron is expired 4 - Set NotifyBorrowerDeparture to 0 5 - repeat 2 6 - No notice that patron is expired, and patron status does not show any blocks
Created attachment 175954 [details] [review] Bug 38658: Display message for expired patrons in SIP when NotifyBorrowerDeparture is disabled This patch restores the behavior that existed in SIP before Bug 25813 - Enhance patron expiration in SIP display: Always consider an expired patron as expired, even if NotifyBorrowerDeparture is set to 0 (disabled) or unset. Test plan: - Set NotifyBorrowerDeparture to 0 - Set a patron's expiry date to be in the past - Use misc/sip_cli_emulator.pl to display patron information: perl misc/sip_cli_emulator.pl -a localhost -p 6001 -su term1 -sp term1 -l CPL -t CR --patron <cardnumber> -m patron_information - Check that you have the following message (AF field): "Greetings from Koha. Your account has expired as of <expired date>"
Please note that the behavior with NotifyBorrowerDeparture now differs in SIP and at the OPAC, where no warning is displayed to an expired patron when NotifyBorrowerDeparture is disabled or unset. To be fair, now that you've pointed it, I find it strange that the warning about being expired is not displayed at the OPAC when NotifyBorrowerDeparture is disabled or unset, but that can be the subject of another bug.
Created attachment 176099 [details] [review] Bug 38658: Display message for expired patrons in SIP when NotifyBorrowerDeparture is disabled This patch restores the behavior that existed in SIP before Bug 25813 - Enhance patron expiration in SIP display: Always consider an expired patron as expired, even if NotifyBorrowerDeparture is set to 0 (disabled) or unset. Test plan: - Set NotifyBorrowerDeparture to 0 - Set a patron's expiry date to be in the past - Use misc/sip_cli_emulator.pl to display patron information: perl misc/sip_cli_emulator.pl -a localhost -p 6001 -su term1 -sp term1 -l CPL -t CR --patron <cardnumber> -m patron_information - Check that you have the following message (AF field): "Greetings from Koha. Your account has expired as of <expired date>" Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>