Bug 38665

Summary: Markup error in additional fields template title
Product: Koha Reporter: Owen Leonard <oleonard>
Component: TemplatesAssignee: Owen Leonard <oleonard>
Status: Pushed to stable --- QA Contact: Katrin Fischer <katrin.fischer>
Severity: trivial    
Priority: P5 - low CC: david, wainuiwitikapark
Version: Main   
Hardware: All   
OS: All   
GIT URL: Change sponsored?: ---
Patch complexity: Trivial patch Documentation contact:
Documentation submission: Text to go in the release notes:
This fixes a markup error in the browser page title for the additional fields page - there was an additional caret (>) at the start (> Additional fields > Administration > Koha, instead of Additional fields > Administration > Koha).
Version(s) released in:
25.05.00,24.11.03
Circulation function:
Bug Depends on: 33909    
Bug Blocks:    
Attachments: Bug 38665: Fix markup error in Additional fields template title
Bug 38665: Fix markup error in Additional fields template title

Description Owen Leonard 2024-12-10 14:44:20 UTC
If you're on the "main" page of admin/additional-fields.pl there is an extra caret at the start of the title: 

> Additional fields > Administration > Koha
Comment 1 Owen Leonard 2024-12-10 14:49:37 UTC
Created attachment 175353 [details] [review]
Bug 38665: Fix markup error in Additional fields template title

The logic of the title tag construction should not result in a caret
preceding the first element on the Additional fields main page.

To test, apply the patch and go to Administration -> Additional fields.
There should be no caret appearing at the start of the page title
information:

Additional fields > Administration > Koha

Other pages (listing additional fields, adding additional fields, etc)
should have the correct title, e.g.

New field > Table 'aqbasket' > Additional fields > Administration > Koha

Sponsored-by: Athens County Public Libraries
Comment 2 David Nind 2024-12-15 18:53:18 UTC
Created attachment 175481 [details] [review]
Bug 38665: Fix markup error in Additional fields template title

The logic of the title tag construction should not result in a caret
preceding the first element on the Additional fields main page.

To test, apply the patch and go to Administration -> Additional fields.
There should be no caret appearing at the start of the page title
information:

Additional fields > Administration > Koha

Other pages (listing additional fields, adding additional fields, etc)
should have the correct title, e.g.

New field > Table 'aqbasket' > Additional fields > Administration > Koha

Sponsored-by: Athens County Public Libraries
Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Katrin Fischer 2024-12-27 15:24:01 UTC
QA by RM
Comment 4 Katrin Fischer 2024-12-27 16:36:39 UTC
Pushed for 25.05!

Well done everyone, thank you!
Comment 5 Paul Derscheid 2025-03-19 23:01:27 UTC
Nice work everyone!

Pushed to 24.11.x for 24.11.03
Comment 6 Wainui Witika-Park 2025-04-17 06:55:38 UTC
Not backporting to 24.05.x unless requested