Bug 38675

Summary: 'Switch provider' dropdown options not styled properly
Product: Koha Reporter: Pedro Amorim <pedro.amorim>
Component: ILLAssignee: Pedro Amorim <pedro.amorim>
Status: Pushed to main --- QA Contact: Lucas Gass (lukeg) <lucas>
Severity: trivial    
Priority: P5 - low CC: alexbuckley, david, lucas, pedro.amorim, tomascohen
Version: MainKeywords: Academy, Sandbox
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
This fixes the styling for the 'Switch provider' dropdown list for interlibrary loan requests - the options are now styled correctly, instead of appearing as plain text links.
Version(s) released in:
25.05.00
Circulation function:
Bug Depends on: 35402    
Bug Blocks:    
Attachments: Bug 38675: Add correct dropdown item class
Bug 38675: Add correct dropdown item class
Bug 38675: Add correct dropdown item class

Description Pedro Amorim 2024-12-11 09:27:29 UTC

    
Comment 1 Pedro Amorim 2024-12-11 09:42:41 UTC
Created attachment 175368 [details] [review]
Bug 38675: Add correct dropdown item class

Test plan:
1) Install at least 2 ILL backends, i.e.:
  https://github.com/PTFS-Europe/koha-ill-backend-plugin/releases/tag/v2.0.5
  https://github.com/PTFS-Europe/koha-ill-reprintsdesk/releases/tag/rc-v3.0.1
2) Enable ILLModule. Create a regular 'Standard' ILL request:
  <staff_url>/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard
3) Pick a type, add '42' (default koha admin user on k-t-d) to cardnumber and pick a library. Click 'Create'.
4) Look at the top toolbar buttons. Click the 'Switch provider' button. You should see 'ReprintsDesk' and 'PluginBackend', but the styling is wrong.
5) Apply patch. Repeat.
Comment 2 David Nind 2024-12-11 10:09:50 UTC
Created attachment 175369 [details] [review]
Bug 38675: Add correct dropdown item class

Test plan:
1) Install at least 2 ILL backends, i.e.:
  https://github.com/PTFS-Europe/koha-ill-backend-plugin/releases/tag/v2.0.5
  https://github.com/PTFS-Europe/koha-ill-reprintsdesk/releases/tag/rc-v3.0.1
2) Enable ILLModule. Create a regular 'Standard' ILL request:
  <staff_url>/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard
3) Pick a type, add '42' (default koha admin user on k-t-d) to cardnumber and pick a library. Click 'Create'.
4) Look at the top toolbar buttons. Click the 'Switch provider' button. You should see 'ReprintsDesk' and 'PluginBackend', but the styling is wrong.
5) Apply patch. Repeat.

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Lucas Gass (lukeg) 2024-12-13 21:43:31 UTC
Created attachment 175472 [details] [review]
Bug 38675: Add correct dropdown item class

Test plan:
1) Install at least 2 ILL backends, i.e.:
  https://github.com/PTFS-Europe/koha-ill-backend-plugin/releases/tag/v2.0.5
  https://github.com/PTFS-Europe/koha-ill-reprintsdesk/releases/tag/rc-v3.0.1
2) Enable ILLModule. Create a regular 'Standard' ILL request:
  <staff_url>/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard
3) Pick a type, add '42' (default koha admin user on k-t-d) to cardnumber and pick a library. Click 'Create'.
4) Look at the top toolbar buttons. Click the 'Switch provider' button. You should see 'ReprintsDesk' and 'PluginBackend', but the styling is wrong.
5) Apply patch. Repeat.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 4 Katrin Fischer 2024-12-23 09:38:03 UTC
Pushed for 25.05!

Well done everyone, thank you!
Comment 5 Alex Buckley 2025-02-20 20:57:54 UTC
not backporting to 24.05.x unless requested - dependency not in 24.05