Bug 38675 - Switch provider dropdown options not styled properly
Summary: Switch provider dropdown options not styled properly
Status: Passed QA
Alias: None
Product: Koha
Classification: Unclassified
Component: ILL (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial
Assignee: Pedro Amorim
QA Contact: Lucas Gass (lukeg)
URL:
Keywords: Academy, Sandbox
Depends on: 35402
Blocks:
  Show dependency tree / graph
 
Reported: 2024-12-11 09:27 UTC by Pedro Amorim
Modified: 2024-12-13 21:43 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
This fixes the styling for the 'Switch provider' dropdown list for interlibrary loan requests - the options are now styled correctly, instead of appearing as plain text links.
Version(s) released in:
Circulation function:

Attachments
Bug 38675: Add correct dropdown item class (2.20 KB, patch)
2024-12-11 09:42 UTC, Pedro Amorim 		Details | Diff | Splinter Review
Bug 38675: Add correct dropdown item class (2.24 KB, patch)
2024-12-11 10:09 UTC, David Nind 		Details | Diff | Splinter Review
Bug 38675: Add correct dropdown item class (2.29 KB, patch)
2024-12-13 21:43 UTC, Lucas Gass (lukeg) 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pedro Amorim 2024-12-11 09:27:29 UTC 

    


    


      



        
          Comment 1
        

        
          Pedro Amorim

        

        
        

        
          2024-12-11 09:42:41 UTC
        

      






Created attachment 175368 [details] [review]
Bug 38675: Add correct dropdown item class

Test plan:
1) Install at least 2 ILL backends, i.e.:
  https://github.com/PTFS-Europe/koha-ill-backend-plugin/releases/tag/v2.0.5
  https://github.com/PTFS-Europe/koha-ill-reprintsdesk/releases/tag/rc-v3.0.1
2) Enable ILLModule. Create a regular 'Standard' ILL request:
  <staff_url>/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard
3) Pick a type, add '42' (default koha admin user on k-t-d) to cardnumber and pick a library. Click 'Create'.
4) Look at the top toolbar buttons. Click the 'Switch provider' button. You should see 'ReprintsDesk' and 'PluginBackend', but the styling is wrong.
5) Apply patch. Repeat.

    


    


      



        
          Comment 2
        

        
          David Nind

        

        
        

        
          2024-12-11 10:09:50 UTC
        

      






Created attachment 175369 [details] [review]
Bug 38675: Add correct dropdown item class

Test plan:
1) Install at least 2 ILL backends, i.e.:
  https://github.com/PTFS-Europe/koha-ill-backend-plugin/releases/tag/v2.0.5
  https://github.com/PTFS-Europe/koha-ill-reprintsdesk/releases/tag/rc-v3.0.1
2) Enable ILLModule. Create a regular 'Standard' ILL request:
  <staff_url>/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard
3) Pick a type, add '42' (default koha admin user on k-t-d) to cardnumber and pick a library. Click 'Create'.
4) Look at the top toolbar buttons. Click the 'Switch provider' button. You should see 'ReprintsDesk' and 'PluginBackend', but the styling is wrong.
5) Apply patch. Repeat.

Signed-off-by: David Nind <david@davidnind.com>

    


    


      



        
          Comment 3
        

        
          Lucas Gass (lukeg)

        

        
        

        
          2024-12-13 21:43:31 UTC
        

      






Created attachment 175472 [details] [review]
Bug 38675: Add correct dropdown item class

Test plan:
1) Install at least 2 ILL backends, i.e.:
  https://github.com/PTFS-Europe/koha-ill-backend-plugin/releases/tag/v2.0.5
  https://github.com/PTFS-Europe/koha-ill-reprintsdesk/releases/tag/rc-v3.0.1
2) Enable ILLModule. Create a regular 'Standard' ILL request:
  <staff_url>/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard
3) Pick a type, add '42' (default koha admin user on k-t-d) to cardnumber and pick a library. Click 'Create'.
4) Look at the top toolbar buttons. Click the 'Switch provider' button. You should see 'ReprintsDesk' and 'PluginBackend', but the styling is wrong.
5) Apply patch. Repeat.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>