Bug 38685

Summary: ILL pages have incomplete breadcrumbs
Product: Koha Reporter: Pedro Amorim <pedro.amorim>
Component: ILLAssignee: Pedro Amorim <pedro.amorim>
Status: Passed QA --- QA Contact: Martin Renvoize (ashimema) <martin.renvoize>
Severity: enhancement    
Priority: P5 - low CC: martin.renvoize, pedro.amorim, tomascohen
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:
Bug Depends on: 35604    
Bug Blocks: 38441    
Attachments: Bug 38685: Remove useless batch_create code
Bug 38685: Only render breadcrumb item if content not empty
Bug 38685: Preparation: DRY code
Bug 38685: Add missing ops to breadcrumbs
Bug 38685: Remove useless batch_create code
Bug 38685: Only render breadcrumb item if content not empty
Bug 38685: Preparation: DRY code
Bug 38685: Add missing ops to breadcrumbs
Bug 38685: Remove useless batch_create code
Bug 38685: Only render breadcrumb item if content not empty
Bug 38685: Preparation: DRY code
Bug 38685: Add missing ops to breadcrumbs

Description Pedro Amorim 2024-12-12 13:15:03 UTC

    
Comment 1 Pedro Amorim 2024-12-12 13:22:13 UTC
Created attachment 175397 [details] [review]
Bug 38685: Remove useless batch_create code

This is not used and not needed.
Noticed when evaluating every potential 'op'.
Comment 2 Pedro Amorim 2024-12-12 13:22:16 UTC
Created attachment 175399 [details] [review]
Bug 38685: Only render breadcrumb item if content not empty

This ensures the '>' caret is only rendered if there is indeed some breadcrumb content.
Comment 3 Pedro Amorim 2024-12-12 13:22:18 UTC
Created attachment 175400 [details] [review]
Bug 38685: Preparation: DRY code

This is in preparation of the next patch, to avoid big copy + pastes
Comment 4 Pedro Amorim 2024-12-12 13:22:22 UTC
Created attachment 175401 [details] [review]
Bug 38685: Add missing ops to breadcrumbs

Breadcrumbs added to the following op pages:
- confirm
- delete_confirm
- generic_confirm
- edititem
- edit_action
- check_out
- cud-cancel
- availability

Test plan:
1) Enable ILLModule
2) Create a new ILL request:
  <staff_url>/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard
3) Try various actions like 'Edit request', 'Confirm request', 'Place request with partners', etc.
4) Notice the breadcrumbs were previously missing. They are now there.
5) If you want to test the breadcrumbs on the batches pages or availability check stage let me know and I'll help setting up the required plugins to have them work.
Comment 5 Owen Leonard 2024-12-13 17:36:32 UTC
Created attachment 175460 [details] [review]
Bug 38685: Remove useless batch_create code

This is not used and not needed.
Noticed when evaluating every potential 'op'.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 6 Owen Leonard 2024-12-13 17:36:34 UTC
Created attachment 175461 [details] [review]
Bug 38685: Only render breadcrumb item if content not empty

This ensures the '>' caret is only rendered if there is indeed some
breadcrumb content.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 7 Owen Leonard 2024-12-13 17:36:36 UTC
Created attachment 175462 [details] [review]
Bug 38685: Preparation: DRY code

This is in preparation of the next patch, to avoid big copy + pastes

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 8 Owen Leonard 2024-12-13 17:36:38 UTC
Created attachment 175463 [details] [review]
Bug 38685: Add missing ops to breadcrumbs

Breadcrumbs added to the following op pages:
- confirm
- delete_confirm
- generic_confirm
- edititem
- edit_action
- check_out
- cud-cancel
- availability

Test plan:
1) Enable ILLModule
2) Create a new ILL request:
   <staff_url>/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard
3) Try various actions like 'Edit request', 'Confirm request', 'Place
   request with partners', etc.
4) Notice the breadcrumbs were previously missing. They are now there.
5) If you want to test the breadcrumbs on the batches pages or
   availability check stage let me know and I'll help setting up the
   required plugins to have them work.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 9 Martin Renvoize (ashimema) 2025-01-08 17:23:08 UTC
Created attachment 176273 [details] [review]
Bug 38685: Remove useless batch_create code

This is not used and not needed.
Noticed when evaluating every potential 'op'.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 10 Martin Renvoize (ashimema) 2025-01-08 17:23:11 UTC
Created attachment 176274 [details] [review]
Bug 38685: Only render breadcrumb item if content not empty

This ensures the '>' caret is only rendered if there is indeed some
breadcrumb content.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 11 Martin Renvoize (ashimema) 2025-01-08 17:23:14 UTC
Created attachment 176275 [details] [review]
Bug 38685: Preparation: DRY code

This is in preparation of the next patch, to avoid big copy + pastes

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 12 Martin Renvoize (ashimema) 2025-01-08 17:23:16 UTC
Created attachment 176276 [details] [review]
Bug 38685: Add missing ops to breadcrumbs

Breadcrumbs added to the following op pages:
- confirm
- delete_confirm
- generic_confirm
- edititem
- edit_action
- check_out
- cud-cancel
- availability

Test plan:
1) Enable ILLModule
2) Create a new ILL request:
   <staff_url>/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard
3) Try various actions like 'Edit request', 'Confirm request', 'Place
   request with partners', etc.
4) Notice the breadcrumbs were previously missing. They are now there.
5) If you want to test the breadcrumbs on the batches pages or
   availability check stage let me know and I'll help setting up the
   required plugins to have them work.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>