Bug 38685 - ILL pages have incomplete breadcrumbs
Summary: ILL pages have incomplete breadcrumbs
Status: Passed QA
Alias: None
Product: Koha
Classification: Unclassified
Component: ILL (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Pedro Amorim
QA Contact: Martin Renvoize (ashimema)
URL:
Keywords:
Depends on: 35604
Blocks: 38441
  Show dependency treegraph
 
Reported: 2024-12-12 13:15 UTC by Pedro Amorim
Modified: 2025-04-11 14:34 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 38685: Remove useless batch_create code (1.68 KB, patch)
2024-12-12 13:22 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 38685: Only render breadcrumb item if content not empty (1.51 KB, patch)
2024-12-12 13:22 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 38685: Preparation: DRY code (2.71 KB, patch)
2024-12-12 13:22 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 38685: Add missing ops to breadcrumbs (3.58 KB, patch)
2024-12-12 13:22 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 38685: Remove useless batch_create code (1.73 KB, patch)
2024-12-13 17:36 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 38685: Only render breadcrumb item if content not empty (1.56 KB, patch)
2024-12-13 17:36 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 38685: Preparation: DRY code (2.76 KB, patch)
2024-12-13 17:36 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 38685: Add missing ops to breadcrumbs (3.64 KB, patch)
2024-12-13 17:36 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 38685: Remove useless batch_create code (1.80 KB, patch)
2025-01-08 17:23 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 38685: Only render breadcrumb item if content not empty (1.62 KB, patch)
2025-01-08 17:23 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 38685: Preparation: DRY code (2.83 KB, patch)
2025-01-08 17:23 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 38685: Add missing ops to breadcrumbs (3.71 KB, patch)
2025-01-08 17:23 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 38685: Remove useless batch_create code (1.70 KB, patch)
2025-03-27 12:58 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 38685: Only render breadcrumb item if content not empty (1.54 KB, patch)
2025-03-27 12:58 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 38685: Preparation: DRY code (2.83 KB, patch)
2025-03-27 12:58 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 38685: Add missing ops to breadcrumbs (3.71 KB, patch)
2025-03-27 12:58 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 38685: Remove useless batch_create code (1.70 KB, patch)
2025-04-11 14:33 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 38685: Only render breadcrumb item if content not empty (1.54 KB, patch)
2025-04-11 14:33 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 38685: Preparation: DRY code (2.82 KB, patch)
2025-04-11 14:34 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 38685: Add missing ops to breadcrumbs (3.71 KB, patch)
2025-04-11 14:34 UTC, Pedro Amorim
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Pedro Amorim 2024-12-12 13:15:03 UTC

    
Comment 1 Pedro Amorim 2024-12-12 13:22:13 UTC
Created attachment 175397 [details] [review]
Bug 38685: Remove useless batch_create code

This is not used and not needed.
Noticed when evaluating every potential 'op'.
Comment 2 Pedro Amorim 2024-12-12 13:22:16 UTC
Created attachment 175399 [details] [review]
Bug 38685: Only render breadcrumb item if content not empty

This ensures the '>' caret is only rendered if there is indeed some breadcrumb content.
Comment 3 Pedro Amorim 2024-12-12 13:22:18 UTC
Created attachment 175400 [details] [review]
Bug 38685: Preparation: DRY code

This is in preparation of the next patch, to avoid big copy + pastes
Comment 4 Pedro Amorim 2024-12-12 13:22:22 UTC
Created attachment 175401 [details] [review]
Bug 38685: Add missing ops to breadcrumbs

Breadcrumbs added to the following op pages:
- confirm
- delete_confirm
- generic_confirm
- edititem
- edit_action
- check_out
- cud-cancel
- availability

Test plan:
1) Enable ILLModule
2) Create a new ILL request:
  <staff_url>/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard
3) Try various actions like 'Edit request', 'Confirm request', 'Place request with partners', etc.
4) Notice the breadcrumbs were previously missing. They are now there.
5) If you want to test the breadcrumbs on the batches pages or availability check stage let me know and I'll help setting up the required plugins to have them work.
Comment 5 Owen Leonard 2024-12-13 17:36:32 UTC
Created attachment 175460 [details] [review]
Bug 38685: Remove useless batch_create code

This is not used and not needed.
Noticed when evaluating every potential 'op'.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 6 Owen Leonard 2024-12-13 17:36:34 UTC
Created attachment 175461 [details] [review]
Bug 38685: Only render breadcrumb item if content not empty

This ensures the '>' caret is only rendered if there is indeed some
breadcrumb content.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 7 Owen Leonard 2024-12-13 17:36:36 UTC
Created attachment 175462 [details] [review]
Bug 38685: Preparation: DRY code

This is in preparation of the next patch, to avoid big copy + pastes

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 8 Owen Leonard 2024-12-13 17:36:38 UTC
Created attachment 175463 [details] [review]
Bug 38685: Add missing ops to breadcrumbs

Breadcrumbs added to the following op pages:
- confirm
- delete_confirm
- generic_confirm
- edititem
- edit_action
- check_out
- cud-cancel
- availability

Test plan:
1) Enable ILLModule
2) Create a new ILL request:
   <staff_url>/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard
3) Try various actions like 'Edit request', 'Confirm request', 'Place
   request with partners', etc.
4) Notice the breadcrumbs were previously missing. They are now there.
5) If you want to test the breadcrumbs on the batches pages or
   availability check stage let me know and I'll help setting up the
   required plugins to have them work.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 9 Martin Renvoize (ashimema) 2025-01-08 17:23:08 UTC
Created attachment 176273 [details] [review]
Bug 38685: Remove useless batch_create code

This is not used and not needed.
Noticed when evaluating every potential 'op'.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 10 Martin Renvoize (ashimema) 2025-01-08 17:23:11 UTC
Created attachment 176274 [details] [review]
Bug 38685: Only render breadcrumb item if content not empty

This ensures the '>' caret is only rendered if there is indeed some
breadcrumb content.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 11 Martin Renvoize (ashimema) 2025-01-08 17:23:14 UTC
Created attachment 176275 [details] [review]
Bug 38685: Preparation: DRY code

This is in preparation of the next patch, to avoid big copy + pastes

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 12 Martin Renvoize (ashimema) 2025-01-08 17:23:16 UTC
Created attachment 176276 [details] [review]
Bug 38685: Add missing ops to breadcrumbs

Breadcrumbs added to the following op pages:
- confirm
- delete_confirm
- generic_confirm
- edititem
- edit_action
- check_out
- cud-cancel
- availability

Test plan:
1) Enable ILLModule
2) Create a new ILL request:
   <staff_url>/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard
3) Try various actions like 'Edit request', 'Confirm request', 'Place
   request with partners', etc.
4) Notice the breadcrumbs were previously missing. They are now there.
5) If you want to test the breadcrumbs on the batches pages or
   availability check stage let me know and I'll help setting up the
   required plugins to have them work.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 13 Pedro Amorim 2025-03-27 12:58:01 UTC
Created attachment 179787 [details] [review]
Bug 38685: Remove useless batch_create code

This is not used and not needed.
Noticed when evaluating every potential 'op'.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 14 Pedro Amorim 2025-03-27 12:58:03 UTC
Created attachment 179788 [details] [review]
Bug 38685: Only render breadcrumb item if content not empty

This ensures the '>' caret is only rendered if there is indeed some
breadcrumb content.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 15 Pedro Amorim 2025-03-27 12:58:06 UTC
Created attachment 179789 [details] [review]
Bug 38685: Preparation: DRY code

This is in preparation of the next patch, to avoid big copy + pastes

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 16 Pedro Amorim 2025-03-27 12:58:10 UTC
Created attachment 179790 [details] [review]
Bug 38685: Add missing ops to breadcrumbs

Breadcrumbs added to the following op pages:
- confirm
- delete_confirm
- generic_confirm
- edititem
- edit_action
- check_out
- cud-cancel
- availability

Test plan:
1) Enable ILLModule
2) Create a new ILL request:
   <staff_url>/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard
3) Try various actions like 'Edit request', 'Confirm request', 'Place
   request with partners', etc.
4) Notice the breadcrumbs were previously missing. They are now there.
5) If you want to test the breadcrumbs on the batches pages or
   availability check stage let me know and I'll help setting up the
   required plugins to have them work.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 17 Pedro Amorim 2025-03-27 12:58:42 UTC
Rebased and tidied on top of tidied bug 35604
Comment 18 Pedro Amorim 2025-04-11 14:33:54 UTC
Created attachment 180874 [details] [review]
Bug 38685: Remove useless batch_create code

This is not used and not needed.
Noticed when evaluating every potential 'op'.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 19 Pedro Amorim 2025-04-11 14:33:56 UTC
Created attachment 180875 [details] [review]
Bug 38685: Only render breadcrumb item if content not empty

This ensures the '>' caret is only rendered if there is indeed some
breadcrumb content.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 20 Pedro Amorim 2025-04-11 14:34:00 UTC
Created attachment 180876 [details] [review]
Bug 38685: Preparation: DRY code

This is in preparation of the next patch, to avoid big copy + pastes

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 21 Pedro Amorim 2025-04-11 14:34:02 UTC
Created attachment 180877 [details] [review]
Bug 38685: Add missing ops to breadcrumbs

Breadcrumbs added to the following op pages:
- confirm
- delete_confirm
- generic_confirm
- edititem
- edit_action
- check_out
- cud-cancel
- availability

Test plan:
1) Enable ILLModule
2) Create a new ILL request:
   <staff_url>/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard
3) Try various actions like 'Edit request', 'Confirm request', 'Place
   request with partners', etc.
4) Notice the breadcrumbs were previously missing. They are now there.
5) If you want to test the breadcrumbs on the batches pages or
   availability check stage let me know and I'll help setting up the
   required plugins to have them work.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>