Created attachment 175397 [details] [review] Bug 38685: Remove useless batch_create code This is not used and not needed. Noticed when evaluating every potential 'op'.
Created attachment 175399 [details] [review] Bug 38685: Only render breadcrumb item if content not empty This ensures the '>' caret is only rendered if there is indeed some breadcrumb content.
Created attachment 175400 [details] [review] Bug 38685: Preparation: DRY code This is in preparation of the next patch, to avoid big copy + pastes
Created attachment 175401 [details] [review] Bug 38685: Add missing ops to breadcrumbs Breadcrumbs added to the following op pages: - confirm - delete_confirm - generic_confirm - edititem - edit_action - check_out - cud-cancel - availability Test plan: 1) Enable ILLModule 2) Create a new ILL request: <staff_url>/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard 3) Try various actions like 'Edit request', 'Confirm request', 'Place request with partners', etc. 4) Notice the breadcrumbs were previously missing. They are now there. 5) If you want to test the breadcrumbs on the batches pages or availability check stage let me know and I'll help setting up the required plugins to have them work.
Created attachment 175460 [details] [review] Bug 38685: Remove useless batch_create code This is not used and not needed. Noticed when evaluating every potential 'op'. Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 175461 [details] [review] Bug 38685: Only render breadcrumb item if content not empty This ensures the '>' caret is only rendered if there is indeed some breadcrumb content. Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 175462 [details] [review] Bug 38685: Preparation: DRY code This is in preparation of the next patch, to avoid big copy + pastes Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 175463 [details] [review] Bug 38685: Add missing ops to breadcrumbs Breadcrumbs added to the following op pages: - confirm - delete_confirm - generic_confirm - edititem - edit_action - check_out - cud-cancel - availability Test plan: 1) Enable ILLModule 2) Create a new ILL request: <staff_url>/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard 3) Try various actions like 'Edit request', 'Confirm request', 'Place request with partners', etc. 4) Notice the breadcrumbs were previously missing. They are now there. 5) If you want to test the breadcrumbs on the batches pages or availability check stage let me know and I'll help setting up the required plugins to have them work. Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 176273 [details] [review] Bug 38685: Remove useless batch_create code This is not used and not needed. Noticed when evaluating every potential 'op'. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 176274 [details] [review] Bug 38685: Only render breadcrumb item if content not empty This ensures the '>' caret is only rendered if there is indeed some breadcrumb content. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 176275 [details] [review] Bug 38685: Preparation: DRY code This is in preparation of the next patch, to avoid big copy + pastes Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 176276 [details] [review] Bug 38685: Add missing ops to breadcrumbs Breadcrumbs added to the following op pages: - confirm - delete_confirm - generic_confirm - edititem - edit_action - check_out - cud-cancel - availability Test plan: 1) Enable ILLModule 2) Create a new ILL request: <staff_url>/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard 3) Try various actions like 'Edit request', 'Confirm request', 'Place request with partners', etc. 4) Notice the breadcrumbs were previously missing. They are now there. 5) If you want to test the breadcrumbs on the batches pages or availability check stage let me know and I'll help setting up the required plugins to have them work. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>