Bug 38707

Summary: Patron restriction types from installer files not translatable
Product: Koha Reporter: Caroline Cyr La Rose <caroline.cyr-la-rose>
Component: I18N/L10NAssignee: Caroline Cyr La Rose <caroline.cyr-la-rose>
Status: RESOLVED FIXED QA Contact: Martin Renvoize (ashimema) <martin.renvoize>
Severity: normal    
Priority: P5 - low CC: alexbuckley, david, f.demians, fridolin.somers, jonathan.druart, martin.renvoize
Version: Main   
Hardware: All   
OS: All   
GIT URL: Change sponsored?: ---
Patch complexity: --- Documentation contact:
Documentation submission: Text to go in the release notes:
This fixes installer files so that the default patron restriction types are now translatable.
Version(s) released in:
25.05.00,24.11.02,24.05.08
Circulation function:
Attachments: Bug 38707: Patron restriction types from installer files not translatable
Bug 38707: Patron restriction types from installer files not translatable
Bug 38707: Patron restriction types from installer files not translatable

Description Caroline Cyr La Rose 2024-12-13 21:18:43 UTC
The patron restriction types that come installed with Koha (Manual restriction, Overdues, Discharge, etc.) are not translated.

To recreate:

`git grep "Manual restriction" misc/translator/po/fr-CA-installer.po`

--> No results
Comment 1 Caroline Cyr La Rose 2024-12-13 21:25:06 UTC
Created attachment 175471 [details] [review]
Bug 38707: Patron restriction types from installer files not translatable

This patch makes translatable the default patron restriction
types that come installed with Koha.

To test:

1) Search for "Manual restriction" in the translation files

`git grep "Manual restriction" misc/translator/po/fr-CA-installer.po`

--> No results

2) Apply patch

3) Update translations

`gulp po:update --lang fr-CA`

4) Repeat step 1

--> Manual restrictions (as well as the other restriction types
    i.e. Overdues, Suspension, Discharge, and Notice failure
    suspension) is in the .po file
Comment 2 David Nind 2024-12-14 20:03:34 UTC
Created attachment 175476 [details] [review]
Bug 38707: Patron restriction types from installer files not translatable

This patch makes translatable the default patron restriction
types that come installed with Koha.

To test:

1) Search for "Manual restriction" in the translation files

`git grep "Manual restriction" misc/translator/po/fr-CA-installer.po`

--> No results

2) Apply patch

3) Update translations

`gulp po:update --lang fr-CA`

4) Repeat step 1

--> Manual restrictions (as well as the other restriction types
    i.e. Overdues, Suspension, Discharge, and Notice failure
    suspension) is in the .po file

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 David Nind 2024-12-14 20:07:37 UTC
Testing notes (using KTD):

1. To run the git grep command, I had to change to the misc/translator/po directory, otherwise I got no results before and after the patch
Comment 4 Martin Renvoize (ashimema) 2024-12-16 19:01:16 UTC
Created attachment 175567 [details] [review]
Bug 38707: Patron restriction types from installer files not translatable

This patch makes translatable the default patron restriction
types that come installed with Koha.

To test:

1) Search for "Manual restriction" in the translation files

`git grep "Manual restriction" misc/translator/po/fr-CA-installer.po`

--> No results

2) Apply patch

3) Update translations

`gulp po:update --lang fr-CA`

4) Repeat step 1

--> Manual restrictions (as well as the other restriction types
    i.e. Overdues, Suspension, Discharge, and Notice failure
    suspension) is in the .po file

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 5 Katrin Fischer 2024-12-20 17:29:29 UTC
Good catch!
Comment 6 Katrin Fischer 2024-12-23 08:38:35 UTC
Pushed for 25.05!

Well done everyone, thank you!
Comment 7 Paul Derscheid 2025-02-03 19:09:42 UTC
Nice work everyone!

Pushed to 24.11.x for 24.11.01
Comment 8 Alex Buckley 2025-03-20 02:31:24 UTC
Nice work everyone!

Pushed to 24.05.x for 24.05.08
Comment 9 Fridolin Somers 2025-03-20 15:08:17 UTC
I prefer not impact 23.11.x to avoid translation work.
23.11.x support will soon end
Comment 10 Caroline Cyr La Rose 2025-04-18 18:44:50 UTC
Nothing to add/edit in the manual