The patron restriction types that come installed with Koha (Manual restriction, Overdues, Discharge, etc.) are not translated. To recreate: `git grep "Manual restriction" misc/translator/po/fr-CA-installer.po` --> No results
Created attachment 175471 [details] [review] Bug 38707: Patron restriction types from installer files not translatable This patch makes translatable the default patron restriction types that come installed with Koha. To test: 1) Search for "Manual restriction" in the translation files `git grep "Manual restriction" misc/translator/po/fr-CA-installer.po` --> No results 2) Apply patch 3) Update translations `gulp po:update --lang fr-CA` 4) Repeat step 1 --> Manual restrictions (as well as the other restriction types i.e. Overdues, Suspension, Discharge, and Notice failure suspension) is in the .po file
Created attachment 175476 [details] [review] Bug 38707: Patron restriction types from installer files not translatable This patch makes translatable the default patron restriction types that come installed with Koha. To test: 1) Search for "Manual restriction" in the translation files `git grep "Manual restriction" misc/translator/po/fr-CA-installer.po` --> No results 2) Apply patch 3) Update translations `gulp po:update --lang fr-CA` 4) Repeat step 1 --> Manual restrictions (as well as the other restriction types i.e. Overdues, Suspension, Discharge, and Notice failure suspension) is in the .po file Signed-off-by: David Nind <david@davidnind.com>
Testing notes (using KTD): 1. To run the git grep command, I had to change to the misc/translator/po directory, otherwise I got no results before and after the patch
Created attachment 175567 [details] [review] Bug 38707: Patron restriction types from installer files not translatable This patch makes translatable the default patron restriction types that come installed with Koha. To test: 1) Search for "Manual restriction" in the translation files `git grep "Manual restriction" misc/translator/po/fr-CA-installer.po` --> No results 2) Apply patch 3) Update translations `gulp po:update --lang fr-CA` 4) Repeat step 1 --> Manual restrictions (as well as the other restriction types i.e. Overdues, Suspension, Discharge, and Notice failure suspension) is in the .po file Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Good catch!
Pushed for 25.05! Well done everyone, thank you!
Nice work everyone! Pushed to 24.11.x for 24.11.01
Nice work everyone! Pushed to 24.05.x for 24.05.08
I prefer not impact 23.11.x to avoid translation work. 23.11.x support will soon end
Nothing to add/edit in the manual