Summary: | Improve the translatability of the patron categories administration page | ||
---|---|---|---|
Product: | Koha | Reporter: | Tomás Cohen Arazi (tcohen) <tomascohen> |
Component: | I18N/L10N | Assignee: | Tomás Cohen Arazi (tcohen) <tomascohen> |
Status: | Pushed to main --- | QA Contact: | Jonathan Druart <jonathan.druart> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | david, f.demians, jonathan.druart, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: |
This improves the translatability of the hint text for these fields on the patron categories form (Administration > Patrons and administration > Patron categories):
- Block expired patron OPAC actions
- Exclude from local holds priority
- Checkout charge limit
- Guarantees checkout charge limit
- Guarantors with guarantees checkout charge limit
|
Version(s) released in: |
25.05.00
|
Circulation function: | |||
Bug Depends on: | 28924 | ||
Bug Blocks: | |||
Attachments: |
Bug 38727: Improve translatability in categories.tt
Bug 38727: Improve translatability in categories.tt Bug 38727: Improve translatability in categories.tt Bug 38727: Improve translatability in categories.tt Bug 38727: Add missing closing div |
Description
Tomás Cohen Arazi (tcohen)
2024-12-17 12:47:57 UTC
Created attachment 175609 [details] [review] Bug 38727: Improve translatability in categories.tt This makes the strings easier to translated for maintaining them as a whole instead of splitting them Extra: it adds a missing dot for consistency. To test: 1. In the categories edit page, check the 3 'If set...' texts 2. Apply this patch and reload => SUCCESS: No visual change 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> You should escape the result of a translation. Created attachment 175619 [details] [review] Bug 38727: Improve translatability in categories.tt This makes the strings easier to translated for maintaining them as a whole instead of splitting them Bonus 1: it adds a missing dot for consistency. Bonus 2: makes a string more idiomatic. To test: 1. In the categories edit page, check the 3 'If set...' texts 2. Apply this patch and reload => SUCCESS: No visual change 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> (In reply to Jonathan Druart from comment #2) > You should escape the result of a translation. Thanks for pointing me in that direction :-D Created attachment 176107 [details] [review] Bug 38727: Improve translatability in categories.tt This makes the strings easier to translated for maintaining them as a whole instead of splitting them Bonus 1: it adds a missing dot for consistency. Bonus 2: makes a string more idiomatic. To test: 1. In the categories edit page, check the 3 'If set...' texts 2. Apply this patch and reload => SUCCESS: No visual change 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> Still this one is ugly: msgid ", holds placed by patrons of this category will not be given priority." Because of the "If <i>Yes</i>" Created attachment 176675 [details] [review] Bug 38727: Improve translatability in categories.tt This makes the strings easier to translated for maintaining them as a whole instead of splitting them Bonus 1: it adds a missing dot for consistency. Bonus 2: makes a string more idiomatic. To test: 1. In the categories edit page, check the 3 'If set...' texts 2. Apply this patch and reload => SUCCESS: No visual change 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 176676 [details] [review] Bug 38727: Add missing closing div Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed for 25.05! Well done everyone, thank you! Did some patches get lost here? For adding the release note, it only looks like the "Block expired patron OPAC actions" field hint text is changed. The patch mentions other text was changed, and obsoleted patches have some changes to the "If set, ...." and other hint text. (In reply to David Nind from comment #10) > Did some patches get lost here? > > For adding the release note, it only looks like the "Block expired patron > OPAC actions" field hint text is changed. > > The patch mentions other text was changed, and obsoleted patches have some > changes to the "If set, ...." and other hint text. I see the two patches in main: ```shell tig log 7cb370904b4c6ee0abf13db85b6893b6eeca6793 tig log aff29616abc3a791c3b3ccf656313c77e21b19db ``` (In reply to Tomás Cohen Arazi (tcohen) from comment #11) > (In reply to David Nind from comment #10) > > Did some patches get lost here? > > > > For adding the release note, it only looks like the "Block expired patron > > OPAC actions" field hint text is changed. > > > > The patch mentions other text was changed, and obsoleted patches have some > > changes to the "If set, ...." and other hint text. > > I see the two patches in main: > > ```shell > tig log 7cb370904b4c6ee0abf13db85b6893b6eeca6793 > tig log aff29616abc3a791c3b3ccf656313c77e21b19db > ``` Not sure what I was thinking/seeing. Everything looks OK now that I've looked at it again! |