Bug 38739

Summary: Templates not ending with include intranet-bottom.inc in staff interface
Product: Koha Reporter: Fridolin Somers <fridolin.somers>
Component: TemplatesAssignee: Owen Leonard <oleonard>
Status: NEW --- QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low    
Version: Main   
Hardware: All   
OS: All   
See Also: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38740
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Description Fridolin Somers 2024-12-18 11:33:05 UTC 
Some templates in staff interface do not end with include intranet-bottom.inc.

 > tail -n1 koha-tmpl/intranet-tmpl/prog/en/modules/*/*.tt | grep -B2 '</html>'

==> koha-tmpl/intranet-tmpl/prog/en/modules/acqui/showorder.tt <==
</html>
--

==> koha-tmpl/intranet-tmpl/prog/en/modules/basket/basket.tt <==
</html>

==> koha-tmpl/intranet-tmpl/prog/en/modules/basket/downloadcart.tt <==
</html>

==> koha-tmpl/intranet-tmpl/prog/en/modules/basket/sendbasketform.tt <==
</html>

==> koha-tmpl/intranet-tmpl/prog/en/modules/batch/print-notices.tt <==
</html>
--

==> koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/showelastic.tt <==
</html>

==> koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/showmarc.tt <==
</html>
--

==> koha-tmpl/intranet-tmpl/prog/en/modules/reports/convert_report.tt <==
</html>
--

==> koha-tmpl/intranet-tmpl/prog/en/modules/tools/preview_letter.tt <==
</html>
--

==> koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/downloadshelf.tt <==
</html>

==> koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/sendshelfform.tt <==
</html>


So for example it does not call hook "intranet_js".

Should all templates end with this include ?
Comment 1 Owen Leonard 2024-12-18 15:38:42 UTC 
Popup windows and pages like showmarc.tt which are loaded via AJAX do not need the full contents of intranet-bottom. We would either need to add some logic to intranet-bottom.inc or add a different, trimmed-down version.