Bug 38750

Summary: Installer process not terminating when nothing to do
Product: Koha Reporter: Jonathan Druart <jonathan.druart>
Component: Installation and upgrade (command-line installer)Assignee: Jonathan Druart <jonathan.druart>
Status: RESOLVED FIXED QA Contact: Emily Lamancusa (emlam) <emily.lamancusa>
Severity: major    
Priority: P5 - low CC: alexbuckley, caroline.cyr-la-rose, david, emily.lamancusa, fridolin.somers, tomascohen
Version: Main   
Hardware: All   
OS: All   
GIT URL: Change sponsored?: ---
Patch complexity: --- Documentation contact:
Documentation submission: Text to go in the release notes:
This fixes the installation process - instead of getting "Try again" when there is nothing left to do (after updating the database structure) and not being able to finish, you now get "Everything went okay. Update done."
Version(s) released in:
25.05.00,24.11.02,24.05.08
Circulation function:
Bug Depends on: 38385    
Bug Blocks:    
Attachments: Bug 38750: (bug 38385 follow-up) Unblock update process when nothing to do
Bug 38750: (bug 38385 follow-up) Unblock update process when nothing to do

Description Jonathan Druart 2024-12-19 11:22:02 UTC
When we go to installer/install.pl and there is nothing to do we get a "Try again" button and never manage to finish the update.
Comment 1 Jonathan Druart 2024-12-19 11:22:55 UTC
https://snipboard.io/TplscJ.jpg
Comment 2 Jonathan Druart 2024-12-19 11:25:25 UTC
Created attachment 175699 [details] [review]
Bug 38750: (bug 38385 follow-up) Unblock update process when nothing to do

When we go to installer/install.pl and there is nothing to do we get a "Try again" button and never manage to finish the update.

https://snipboard.io/TplscJ.jpg

Test plan:
Go to installer/install.pl
Login
Click next
=> Without this patch you are stuck with a "Try again" button
=> With this patch applied you get a success screen
 "Everything went okay. Update done."
Comment 3 Emily Lamancusa (emlam) 2024-12-19 17:31:45 UTC
Created attachment 175792 [details] [review]
Bug 38750: (bug 38385 follow-up) Unblock update process when nothing to do

When we go to installer/install.pl and there is nothing to do we get a "Try again" button and never manage to finish the update.

https://snipboard.io/TplscJ.jpg

Test plan:
Go to installer/install.pl
Login
Click next
=> Without this patch you are stuck with a "Try again" button
=> With this patch applied you get a success screen
 "Everything went okay. Update done."

Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
Comment 4 Emily Lamancusa (emlam) 2024-12-19 17:32:40 UTC
Trivial change - moving straight to PQA. Thanks, Jonathan!
Comment 5 Katrin Fischer 2024-12-23 08:38:38 UTC
Pushed for 25.05!

Well done everyone, thank you!
Comment 6 Paul Derscheid 2025-02-03 19:09:45 UTC
Nice work everyone!

Pushed to 24.11.x for 24.11.01
Comment 7 Alex Buckley 2025-03-19 20:24:18 UTC
Nice work everyone!

Pushed to 24.05.x for 24.05.08
Comment 8 Fridolin Somers 2025-03-20 15:01:33 UTC
Depends on Bug 38285 not in 23.11.x
Comment 9 Caroline Cyr La Rose 2025-04-18 18:45:21 UTC
Bug fix, nothing to add/edit in the manual