Bug 38285 - Replace instances of obsolete Bootstrap class "pull-right"
Summary: Replace instances of obsolete Bootstrap class "pull-right"
Status: Signed Off
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low minor
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on: 35402
Blocks:
  Show dependency tree / graph
 
Reported: 2024-10-29 10:24 UTC by Owen Leonard
Modified: 2024-11-28 22:10 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
This fixes CSS class changes that were missed during the Bootstrap 5 upgrade: - Removes instances of the pre-Bootstrap-5 class "pull-right" (Bootstrap 5 menus have better responsive behavior). - Adds "dropdown-item" classes to some menu items that lacked it. - Adds some custom style for the "Filter" form in the patron permissions toolbar (it is now correctly aligned). (This is related to the OPAC and staff interface Bootstrap 5 upgrade in Koha 24.11.)
Version(s) released in:
Circulation function:

Attachments
Bug 38285: Replace instances of obsolete Bootstrap class "pull-right" (38.02 KB, patch)
2024-11-06 14:29 UTC, Owen Leonard 		Details | Diff | Splinter Review
Bug 38285: Replace instances of obsolete Bootstrap class "pull-right" (34.66 KB, patch)
2024-11-28 22:02 UTC, David Nind 		Details | Diff | Splinter Review
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2024-10-29 10:24:58 UTC 
Bootstrap 5 doesn't have the "pull-right" class, and we have some instances of it which were not caught during the upgrade.

Most commonly we see it on dropdown menus, where it may be able to be removed without replacing it with a different class. Bootstrap 5 menus are more responsive than previous versions.

Otherwise "pull-right" on dropdowns can be replaced with "dropdown-menu-end".
Comment 1 Owen Leonard 2024-11-06 14:29:56 UTC 
Created attachment 174079 [details] [review]
Bug 38285: Replace instances of obsolete Bootstrap class "pull-right"

This patch fixes instances where the pre-Bootstrap-5 class "pull-right"
was missed during the upgrade. Most cases were on dropdown menus, and
in all of these cases the class can be removed because Bootstrap 5 menus
have better responsive behavior.

Other changes: Added "dropdown-item" classes to some menu items which
lacked it; Added some custom style for the "Filter" form in the patron
permissions toolbar.

To test, apply the patch and rebuild the staff interface CSS. Test that
the following menus look correct and work correctly:

- Catalog -> Bibliographic details page -> Holdings table: The "Edit"
  secondary menu shown for each item (requires that the LocalCoverImages
  system preference be enabled.
- Administration -> Z39.50 servers: The "Actions" menu for each server
  in the list of servers.
- Circulation -> Article requests: The "Actions" menu for each title and
  under each tab (New, Pending, and Processing).
- Tools -> Patron lists: "Actions" menu.
- Administration -> Plugins: "Actions" menu (requires that you have at
  least one plugin installed).
- Reports -> Saved SQL reports: The secondary menu on each saved
  report's "Run" button .
- Cataloging -> Rotating collections: "Actions" menu.
- Serials -> Subscription search results: In the "Open" tab, the
  secondary menu on the "Serial receive" button on each subscription. In
  the "Closed" tab, the "Actions" menu.
- Acquistions -> Suggestions: The secondary menu on each title's
  "Edit" button.
- Tools -> HTML customizations: The secondary menu on the "New
  entry" button; The secondary menu on each entry's
  "Edit" button; Edit entry -> The secondary menu on the "Save" button.
- Cataloging -> Stock rotation: The "Manage" menu on each rota.

A non-menu change:
- Patrons -> Patron details -> More -> Set permissions: CSS has been
  added to correctly align the "Filter" menu.

Sponsored-by: Athens County Public Libraries
Comment 2 David Nind 2024-11-28 22:02:09 UTC 
Created attachment 175023 [details] [review]
Bug 38285: Replace instances of obsolete Bootstrap class "pull-right"

This patch fixes instances where the pre-Bootstrap-5 class "pull-right"
was missed during the upgrade. Most cases were on dropdown menus, and
in all of these cases the class can be removed because Bootstrap 5 menus
have better responsive behavior.

Other changes: Added "dropdown-item" classes to some menu items which
lacked it; Added some custom style for the "Filter" form in the patron
permissions toolbar.

To test, apply the patch and rebuild the staff interface CSS. Test that
the following menus look correct and work correctly:

- Catalog -> Bibliographic details page -> Holdings table: The "Edit"
  secondary menu shown for each item (requires that the LocalCoverImages
  system preference be enabled.
- Administration -> Z39.50 servers: The "Actions" menu for each server
  in the list of servers.
- Circulation -> Article requests: The "Actions" menu for each title and
  under each tab (New, Pending, and Processing).
- Tools -> Patron lists: "Actions" menu.
- Administration -> Plugins: "Actions" menu (requires that you have at
  least one plugin installed).
- Reports -> Saved SQL reports: The secondary menu on each saved
  report's "Run" button .
- Cataloging -> Rotating collections: "Actions" menu.
- Serials -> Subscription search results: In the "Open" tab, the
  secondary menu on the "Serial receive" button on each subscription. In
  the "Closed" tab, the "Actions" menu.
- Acquistions -> Suggestions: The secondary menu on each title's
  "Edit" button.
- Tools -> HTML customizations: The secondary menu on the "New
  entry" button; The secondary menu on each entry's
  "Edit" button; Edit entry -> The secondary menu on the "Save" button.
- Cataloging -> Stock rotation: The "Manage" menu on each rota.

A non-menu change:
- Patrons -> Patron details -> More -> Set permissions: CSS has been
  added to correctly align the "Filter" menu.

Sponsored-by: Athens County Public Libraries
Signed-off-by: David Nind <david@davidnind.com>