Summary: | Missing table cells breaks OPAC charges table | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | OPAC | Assignee: | Owen Leonard <oleonard> |
Status: | Pushed to stable --- | QA Contact: | Katrin Fischer <katrin.fischer> |
Severity: | normal | ||
Priority: | P5 - low | CC: | david, jonathan.druart |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: |
This fixes the charges table for a patron in the OPAC (Your account > Charges). It didn't display correctly in some circumstances (there were missing empty table cells, resulting in empty and misaligned cells at the end of the table).
|
|
Version(s) released in: |
25.05.00,24.11.03
|
Circulation function: | |
Bug Depends on: | 32341 | ||
Bug Blocks: | |||
Attachments: |
Bug 38753: Missing table cells breaks OPAC charges table
Bug 38753: Missing table cells breaks OPAC charges table |
Description
Owen Leonard
2024-12-19 13:08:04 UTC
I think the problem is only visible if the patron has an outstanding credit on their account. Created attachment 175765 [details] [review] Bug 38753: Missing table cells breaks OPAC charges table This patch adds a couple of instances of the empty cell required by DataTables to enable responsive behavior. The mismatch between table headers and table cells causes DataTables to fail. To test you must log in to the OPAC as a user with charges and credit. - Apply the patch and go to Patrons in the staff interface. - Find and view a patron record. Click "Accounting" in the sidebar menu. - Use the "Create manual invoice" and "Create manual credit" tabs to create at least one charge and a credit which is greater than the charges. - Log in to the OPAC as that user and go to their Charges tab. - The charges table shoud look correct, with DataTables sorting indicators on the table headers to indicate that DataTables is working. Sponsored-by: Athens County Public Libraries Created attachment 175806 [details] [review] Bug 38753: Missing table cells breaks OPAC charges table This patch adds a couple of instances of the empty cell required by DataTables to enable responsive behavior. The mismatch between table headers and table cells causes DataTables to fail. To test you must log in to the OPAC as a user with charges and credit. - Apply the patch and go to Patrons in the staff interface. - Find and view a patron record. Click "Accounting" in the sidebar menu. - Use the "Create manual invoice" and "Create manual credit" tabs to create at least one charge and a credit which is greater than the charges. - Log in to the OPAC as that user and go to their Charges tab. - The charges table shoud look correct, with DataTables sorting indicators on the table headers to indicate that DataTables is working. Sponsored-by: Athens County Public Libraries Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> QA by RM. Pushed for 25.05! Well done everyone, thank you! Nice work everyone! Pushed to 24.11.x for 24.11.03 |