Bug 38753 - Missing table cells breaks OPAC charges table
Summary: Missing table cells breaks OPAC charges table
Status: Pushed to stable
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Owen Leonard
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on: 32341
Blocks:
  Show dependency treegraph
 
Reported: 2024-12-19 13:08 UTC by Owen Leonard
Modified: 2025-03-19 23:01 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
This fixes the charges table for a patron in the OPAC (Your account > Charges). It didn't display correctly in some circumstances (there were missing empty table cells, resulting in empty and misaligned cells at the end of the table).
Version(s) released in:
25.05.00,24.11.03
Circulation function:


Attachments
Bug 38753: Missing table cells breaks OPAC charges table (2.06 KB, patch)
2024-12-19 13:59 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 38753: Missing table cells breaks OPAC charges table (2.11 KB, patch)
2024-12-19 21:07 UTC, Roman Dolny
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2024-12-19 13:08:04 UTC
There are a couple of missing instances of the empty '<td></td>' required by DataTables to make the table responsive. The table header/table cell mismatch breaks the DataTable behavior.
Comment 1 Owen Leonard 2024-12-19 13:18:50 UTC
I think the problem is only visible if the patron has an outstanding credit on their account.
Comment 2 Owen Leonard 2024-12-19 13:59:48 UTC
Created attachment 175765 [details] [review]
Bug 38753: Missing table cells breaks OPAC charges table

This patch adds a couple of instances of the empty cell required by
DataTables to enable responsive behavior. The mismatch between table
headers and table cells causes DataTables to fail.

To test you must log in to the OPAC as a user with charges and credit.

- Apply the patch and go to Patrons in the staff interface.
- Find and view a patron record. Click "Accounting" in the sidebar menu.
- Use the "Create manual invoice" and "Create manual credit" tabs to
  create at least one charge and a credit which is greater than the
  charges.
- Log in to the OPAC as that user and go to their Charges tab.
- The charges table shoud look correct, with DataTables sorting
  indicators on the table headers to indicate that DataTables is
  working.

Sponsored-by: Athens County Public Libraries
Comment 3 Roman Dolny 2024-12-19 21:07:01 UTC
Created attachment 175806 [details] [review]
Bug 38753: Missing table cells breaks OPAC charges table

This patch adds a couple of instances of the empty cell required by
DataTables to enable responsive behavior. The mismatch between table
headers and table cells causes DataTables to fail.

To test you must log in to the OPAC as a user with charges and credit.

- Apply the patch and go to Patrons in the staff interface.
- Find and view a patron record. Click "Accounting" in the sidebar menu.
- Use the "Create manual invoice" and "Create manual credit" tabs to
  create at least one charge and a credit which is greater than the
  charges.
- Log in to the OPAC as that user and go to their Charges tab.
- The charges table shoud look correct, with DataTables sorting
  indicators on the table headers to indicate that DataTables is
  working.

Sponsored-by: Athens County Public Libraries
Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>
Comment 4 Katrin Fischer 2024-12-27 16:03:52 UTC
QA by RM.
Comment 5 Katrin Fischer 2024-12-27 16:36:56 UTC
Pushed for 25.05!

Well done everyone, thank you!
Comment 6 Paul Derscheid 2025-03-19 23:01:47 UTC
Nice work everyone!

Pushed to 24.11.x for 24.11.03