Summary: | Opening, closing, or deleting and invoice from the Action drop-down can cause internal server error | ||
---|---|---|---|
Product: | Koha | Reporter: | Emily Lamancusa (emlam) <emily.lamancusa> |
Component: | Acquisitions | Assignee: | Emily Lamancusa (emlam) <emily.lamancusa> |
Status: | Pushed to main --- | QA Contact: | Katrin Fischer <katrin.fischer> |
Severity: | normal | ||
Priority: | P5 - low | CC: | david |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: |
This fixes closing and reopening of invoices using the action button options (Acquisitions > [Vendor] > Invoices > Actions) - when used from the search results when using invoice filters (for example, shipment to and from dates). This caused an internal server error with the message "The given date <date> does not match the date format (iso)...". It also adds a confirmation message when deleting an invoice.
|
Version(s) released in: |
25.05.00
|
Circulation function: | |||
Bug Depends on: | 38155, 38765 | ||
Bug Blocks: | |||
Attachments: |
Bug 38766: Use uri filter for all parameters in referer link
Bug 38766: Use uri filter for all parameters in referer link |
Description
Emily Lamancusa (emlam)
2024-12-20 17:31:21 UTC
Created attachment 175851 [details] [review] Bug 38766: Use uri filter for all parameters in referer link Also fixes the confirmation message for deleting. To test: 1. Go to Acquisitions and create some invoices i. Search for a vendor (can submit a blank search box) ii. Click on vendor name iii. Click "Receive shipments" button iv. In the "Receive a new shipment" section, enter any value in the "Vendor invoice" field and click "Next" v. Click the "My Vendor" breadcrumb and repeat iii-iv a few times 2. Go to Acquisitions > Invoices 3. Specify search filters for shipment to/from dates (that include the invoices you entered) and search for invoices 4. Try opening, closing, and deleting individual invoices using the Action menu --> Internal server error! "The given date <date> does not match the date format (iso)". --> Also, note that there is no confirmation dialog when deleting 5. Apply patch 6. Repeat steps 2-4 --> Confirm that invoices can be opened and closed using the drop-down menu with no issue --> Confirm that both open and closed invoices can be deleted with no issue, and that a confirmation message displays before deleting Note for QA: search for $KohaDates within invoices.tt, and confirm that the $KohaDates filter is now only used for display, never for Internal data storage/flow Created attachment 175854 [details] [review] Bug 38766: Use uri filter for all parameters in referer link Also fixes the confirmation message for deleting. To test: 1. Go to Acquisitions and create some invoices i. Search for a vendor (can submit a blank search box) ii. Click on vendor name iii. Click "Receive shipments" button iv. In the "Receive a new shipment" section, enter any value in the "Vendor invoice" field and click "Next" v. Click the "My Vendor" breadcrumb and repeat iii-iv a few times 2. Go to Acquisitions > Invoices 3. Specify search filters for shipment to/from dates (that include the invoices you entered) and search for invoices 4. Try opening, closing, and deleting individual invoices using the Action menu --> Internal server error! "The given date <date> does not match the date format (iso)". --> Also, note that there is no confirmation dialog when deleting 5. Apply patch 6. Repeat steps 2-4 --> Confirm that invoices can be opened and closed using the drop-down menu with no issue --> Confirm that both open and closed invoices can be deleted with no issue, and that a confirmation message displays before deleting Note for QA: search for $KohaDates within invoices.tt, and confirm that the $KohaDates filter is now only used for display, never for Internal data storage/flow Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> I've added a follow-up for a transatability issue: data-confirmation-msg="Are you sure you want to delete this invoice? Following the existing pattern: data-confirmation-msg="[% t('...') | html %] Pushed for 25.05! Well done everyone, thank you! |