Bug 38767

Summary:	Statuses in the holdings table should be divs not spans
Product:	Koha	Reporter:	Lucas Gass (lukeg) <lucas>
Component:	Circulation	Assignee:	Lucas Gass (lukeg) <lucas>
Status:	Needs Signoff ---	QA Contact:	Testopia <testopia>
Severity:	normal
Priority:	P5 - low	CC:	gmcharlt, kyle.m.hall, phil
Version:	Main
Hardware:	All
OS:	All
Change sponsored?:	---	Patch complexity:	Trivial patch
Documentation contact:		Documentation submission:
Text to go in the release notes:		Version(s) released in:
Circulation function:
Bug Depends on:	38512
Bug Blocks:
Attachments:	Bug 38767: Convert each status element in holdings table from span to div

Description Lucas Gass (lukeg) 2024-12-20 17:37:12 UTC

In the holdings table there is a the status column, there can sometimes be multiple statuses per item. When there is the are displayed in <span>, being inline makes each status run together. 

They need to be block level <div> to be more readable.

Comment 1 Lucas Gass (lukeg) 2024-12-20 17:43:41 UTC

Created attachment 175850 [details] [review]
Bug 38767: Convert each status element in holdings table from span to div

1. have an item with many statuses including:

-checked out
-onsite_checkout
-in transit
-transit requested
-lost
-damaaged
-withdrwan
-not for loan
-hold waiting at...
-recalled
-available
-in bundle

2. notice when there are multiple statuses the text runs into a single "blob".
3. Apply patch
4. Statuses are seperated by a break.

Comment 2 Phil Ringnalda 2024-12-20 22:11:31 UTC

Many of those won't reproduce the problem because staff-global.css sets them to display: block; already. Some can't exist with some others (you can't have available and lost since available comes from !lost). Some sort of expect to be combined (e.g. waitingat and heldfor).

Could you fix the actual problem ones by just adding their class to the classes that are set to display: block?

Comment 3 Phil Ringnalda 2024-12-21 01:15:47 UTC

Oh, didn't notice the dependency saying the problem was the recall message that you made stop trying (and failing) to work as a run-on sentence with its initial lowercase letter.

So make that "can't you just add a classname to the recall span, always a useful thing, and then add that to the list of block statuses in https://git.koha-community.org/Koha-community/Koha/src/commit/1a4820322e528fdea4ac6dd212254ca3021d30a2/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss#L2263 so it won't try to attach itself to other things?"