Bug 38779

Summary: Record sources not working on packages install
Product: Koha Reporter: Tomás Cohen Arazi (tcohen) <tomascohen>
Component: Installation and upgrade (command-line installer)Assignee: Tomás Cohen Arazi (tcohen) <tomascohen>
Status: RESOLVED FIXED QA Contact: Katrin Fischer <katrin.fischer>
Severity: major    
Priority: P5 - low CC: alexbuckley, caroline.cyr-la-rose, david, fridolin.somers, mnero, mtj, paul.derscheid, tomascohen
Version: MainKeywords: rel_24_05_candidate, RM_priority
Hardware: All   
OS: All   
GIT URL: Change sponsored?: ---
Patch complexity: --- Documentation contact:
Documentation submission: Text to go in the release notes:
This fixes the record sources page (Administration > Cataloging > Record sources) for package installs - you can now add and edit record sources, instead of getting a blank page. The Koha packages were missing the required JavaScript files (/intranet-tmpl/prog/js/vue/dist/admin/record_sources_24.1100000.js"></script>) to make the page work correctly.
Version(s) released in:
25.05.00,24.11.02,24.05.07
Circulation function:
Bug Depends on: 35919    
Bug Blocks:    
Attachments: Bug 38779: Add built record sources assets on install
Bug 38779: Add built record sources assets on install

Description Tomás Cohen Arazi (tcohen) 2024-12-23 19:02:46 UTC
Interestingly, we miss `record_sources.js` in Makefile.PL

Seen this on a packages install:

[2024/12/23 10:26:39] [WARN] File not found : js/vue/dist/admin/record_sources.js at /usr/share/koha/lib/Koha/Template/Plugin/Asset.pm line 84.
Comment 1 Tomás Cohen Arazi (tcohen) 2024-12-23 19:04:25 UTC
Created attachment 175915 [details] [review]
Bug 38779: Add built record sources assets on install

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 2 Katrin Fischer 2024-12-23 19:35:08 UTC
Is this something we could add a test for? easy to miss.
Comment 3 David Nind 2024-12-28 20:22:08 UTC
Created attachment 175971 [details] [review]
Bug 38779: Add built record sources assets on install

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: David Nind <david@davidnind.com>
Comment 4 David Nind 2024-12-28 20:43:19 UTC
I checked a demo install for 24.11 (from https://koha-community.org/demo/):
- The record sources administration page is blank
- The page source does not include <script src="/intranet-tmpl/prog/js/vue/dist/admin/record_sources_24.XXXXX.js"></script> (this is present in the page if you are using KTD).

The change makes sense to me, even though I can't test that it is fixed (I would need to build the packages (which I don't know how to do), and then install Koha from scratch).

Feel free to change back to needs sign off if this isn't sufficient.
Comment 5 Katrin Fischer 2024-12-30 10:36:34 UTC
Follows existing pattern, QA by RM!
Comment 6 Katrin Fischer 2024-12-30 11:10:24 UTC
Pushed for 25.05!

Well done everyone, thank you!
Comment 7 Paul Derscheid 2025-02-04 21:54:42 UTC
Nice work everyone!

Pushed to 24.11.x for 24.11.02
Comment 8 Alex Buckley 2025-02-19 01:31:32 UTC
Backported to 24.05.x for 24.05.07

We didn't have a test plan to follow for this. But we have backported it as it's RM_priority, and it is rel_24_05_candidate.

Please let us know if any testing is needed.
Comment 9 Katrin Fischer 2025-02-19 08:53:18 UTC
I think for testing you'd need to do a package install or tarball one. But it should be OK for 24.04 as long as record_sources.js exists.
Comment 10 Alex Buckley 2025-02-20 01:30:29 UTC
(In reply to Katrin Fischer from comment #9)
> I think for testing you'd need to do a package install or tarball one. But
> it should be OK for 24.04 as long as record_sources.js exists.

Thanks for your reply Katrin. I can confirm that 24.05.x does have the record_sources.js file: https://git.koha-community.org/Koha-community/Koha/src/branch/24.05.x/koha-tmpl/intranet-tmpl/prog/js/vue/routes/admin/record_sources.js
Comment 11 Fridolin Somers 2025-02-21 14:18:39 UTC
Depends on Bug 35919 not in 23.11.x
Comment 12 Caroline Cyr La Rose 2025-04-18 18:45:53 UTC
Bug fix, nothing to add/edit in the manual