Bug 38779 - Record sources not working on packages install
Summary: Record sources not working on packages install
Status: Pushed to main
Alias: None
Product: Koha
Classification: Unclassified
Component: Installation and upgrade (command-line installer) (show other bugs)
Version: Main
Hardware: All All
: P5 - low major
Assignee: Tomás Cohen Arazi (tcohen)
QA Contact: Katrin Fischer
URL:
Keywords: rel_24_05_candidate, rel_24_11_candidate, RM_priority
Depends on: 35919
Blocks:
  Show dependency treegraph
 
Reported: 2024-12-23 19:02 UTC by Tomás Cohen Arazi (tcohen)
Modified: 2025-01-28 16:01 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
This fixes the record sources page (Administration > Cataloging > Record sources) for package installs - you can now add and edit record sources, instead of getting a blank page. The Koha packages were missing the required JavaScript files (/intranet-tmpl/prog/js/vue/dist/admin/record_sources_24.1100000.js"></script>) to make the page work correctly.
Version(s) released in:
25.05.00
Circulation function:


Attachments
Bug 38779: Add built record sources assets on install (1.29 KB, patch)
2024-12-23 19:04 UTC, Tomás Cohen Arazi (tcohen)
Details | Diff | Splinter Review
Bug 38779: Add built record sources assets on install (1.33 KB, patch)
2024-12-28 20:22 UTC, David Nind
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Tomás Cohen Arazi (tcohen) 2024-12-23 19:02:46 UTC
Interestingly, we miss `record_sources.js` in Makefile.PL

Seen this on a packages install:

[2024/12/23 10:26:39] [WARN] File not found : js/vue/dist/admin/record_sources.js at /usr/share/koha/lib/Koha/Template/Plugin/Asset.pm line 84.
Comment 1 Tomás Cohen Arazi (tcohen) 2024-12-23 19:04:25 UTC
Created attachment 175915 [details] [review]
Bug 38779: Add built record sources assets on install

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 2 Katrin Fischer 2024-12-23 19:35:08 UTC
Is this something we could add a test for? easy to miss.
Comment 3 David Nind 2024-12-28 20:22:08 UTC
Created attachment 175971 [details] [review]
Bug 38779: Add built record sources assets on install

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: David Nind <david@davidnind.com>
Comment 4 David Nind 2024-12-28 20:43:19 UTC
I checked a demo install for 24.11 (from https://koha-community.org/demo/):
- The record sources administration page is blank
- The page source does not include <script src="/intranet-tmpl/prog/js/vue/dist/admin/record_sources_24.XXXXX.js"></script> (this is present in the page if you are using KTD).

The change makes sense to me, even though I can't test that it is fixed (I would need to build the packages (which I don't know how to do), and then install Koha from scratch).

Feel free to change back to needs sign off if this isn't sufficient.
Comment 5 Katrin Fischer 2024-12-30 10:36:34 UTC
Follows existing pattern, QA by RM!
Comment 6 Katrin Fischer 2024-12-30 11:10:24 UTC
Pushed for 25.05!

Well done everyone, thank you!