Interestingly, we miss `record_sources.js` in Makefile.PL Seen this on a packages install: [2024/12/23 10:26:39] [WARN] File not found : js/vue/dist/admin/record_sources.js at /usr/share/koha/lib/Koha/Template/Plugin/Asset.pm line 84.
Created attachment 175915 [details] [review] Bug 38779: Add built record sources assets on install Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Is this something we could add a test for? easy to miss.
Created attachment 175971 [details] [review] Bug 38779: Add built record sources assets on install Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com>
I checked a demo install for 24.11 (from https://koha-community.org/demo/): - The record sources administration page is blank - The page source does not include <script src="/intranet-tmpl/prog/js/vue/dist/admin/record_sources_24.XXXXX.js"></script> (this is present in the page if you are using KTD). The change makes sense to me, even though I can't test that it is fixed (I would need to build the packages (which I don't know how to do), and then install Koha from scratch). Feel free to change back to needs sign off if this isn't sufficient.
Follows existing pattern, QA by RM!
Pushed for 25.05! Well done everyone, thank you!
Nice work everyone! Pushed to 24.11.x for 24.11.02
Backported to 24.05.x for 24.05.07 We didn't have a test plan to follow for this. But we have backported it as it's RM_priority, and it is rel_24_05_candidate. Please let us know if any testing is needed.
I think for testing you'd need to do a package install or tarball one. But it should be OK for 24.04 as long as record_sources.js exists.
(In reply to Katrin Fischer from comment #9) > I think for testing you'd need to do a package install or tarball one. But > it should be OK for 24.04 as long as record_sources.js exists. Thanks for your reply Katrin. I can confirm that 24.05.x does have the record_sources.js file: https://git.koha-community.org/Koha-community/Koha/src/branch/24.05.x/koha-tmpl/intranet-tmpl/prog/js/vue/routes/admin/record_sources.js
Depends on Bug 35919 not in 23.11.x
Bug fix, nothing to add/edit in the manual