Interestingly, we miss `record_sources.js` in Makefile.PL Seen this on a packages install: [2024/12/23 10:26:39] [WARN] File not found : js/vue/dist/admin/record_sources.js at /usr/share/koha/lib/Koha/Template/Plugin/Asset.pm line 84.
Created attachment 175915 [details] [review] Bug 38779: Add built record sources assets on install Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Is this something we could add a test for? easy to miss.
Created attachment 175971 [details] [review] Bug 38779: Add built record sources assets on install Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com>
I checked a demo install for 24.11 (from https://koha-community.org/demo/): - The record sources administration page is blank - The page source does not include <script src="/intranet-tmpl/prog/js/vue/dist/admin/record_sources_24.XXXXX.js"></script> (this is present in the page if you are using KTD). The change makes sense to me, even though I can't test that it is fixed (I would need to build the packages (which I don't know how to do), and then install Koha from scratch). Feel free to change back to needs sign off if this isn't sufficient.
Follows existing pattern, QA by RM!
Pushed for 25.05! Well done everyone, thank you!