Bug 38794

Summary: AggregatedFullText description should be Aggregated full text
Product: Koha Reporter: Mathieu Saby <mathsabypro>
Component: ERMAssignee: Nicolas Hunstein <nicolas.hunstein>
Status: Pushed to main --- QA Contact: Pedro Amorim <pedro.amorim>
Severity: trivial    
Priority: P5 - low CC: david, jonathan.druart, jonathan.field, martin.renvoize, matt.blenkinsop, nicolas.hunstein, pedro.amorim
Version: Main   
Hardware: All   
OS: All   
GIT URL: Change sponsored?: ---
Patch complexity: String patch Documentation contact:
Documentation submission: Text to go in the release notes:
This fixes the authorized value description for AggregatedFullText in the ERM_PACKAGE_CONTENT_TYPE category. It updates the description from "Aggregated full" to "Aggregated full text".
Version(s) released in:
25.05.00
Circulation function:
Attachments: Bug 38794: update AggregatedFullText description
Bug 38794: update AggregatedFullText description
Bug 38794: update AggregatedFullText description
Bug 38794: (follow-up) add database update
Bug 38794: Update authorized value description for AggregatedFullText
Bug 38794: (follow-up) Add database update
Bug 38794: Update authorized value description for AggregatedFullText
Bug 38794: (follow-up) Add database update
Bug 38794: say_success only if updated

Description Mathieu Saby 2024-12-29 12:11:31 UTC
in ERM_PACKAGE_CONTENT_TYPE auth values, AggregatedFullText description is currently "Aggregated full" 
it should be "Aggregated full text"
Comment 1 Nicolas Hunstein 2025-01-10 13:33:37 UTC
Created attachment 176328 [details] [review]
Bug 38794: update AggregatedFullText description

updates description "Aggregated full" to "Aggregated full text" at authorized value ERM_PACKAGE_CONTENT_TYPE

to test:
- go to Administration/Authorized values
- check authorized values for category ERM_PACKAGE_CONTENT_TYPE
- verify description for AggregatedFullText is Aggregated full

- apply patch
- reset database or reset_all
- verify description has changed to Aggregated full text
Comment 2 Nicolas Hunstein 2025-01-10 13:34:02 UTC
Created attachment 176329 [details] [review]
Bug 38794: update AggregatedFullText description

updates description "Aggregated full" to "Aggregated full text" at authorized value ERM_PACKAGE_CONTENT_TYPE

to test:
- go to Administration/Authorized values
- check authorized values for category ERM_PACKAGE_CONTENT_TYPE
- verify description for AggregatedFullText is Aggregated full

- apply patch
- reset database or reset_all
- verify description has changed to Aggregated full text
Comment 3 Pedro Amorim 2025-01-10 13:43:01 UTC
This is missing an atomic update. Kohas that are upgrading also need this description updated:
update authorised_values set lib = "Aggregated full text" where category = "ERM_PACKAGE_CONTENT_TYPE" AND authorised_value="AggregatedFullTex
t";
Comment 4 Katrin Fischer 2025-01-10 13:53:22 UTC
(In reply to Pedro Amorim from comment #3)
> This is missing an atomic update. Kohas that are upgrading also need this
> description updated:
> update authorised_values set lib = "Aggregated full text" where category =
> "ERM_PACKAGE_CONTENT_TYPE" AND authorised_value="AggregatedFullTex
> t";

The value might have been translated and this would untranslate them.
Suggestion: Add the English description to the WHERE clauses as well.
Comment 5 Pedro Amorim 2025-01-10 14:08:54 UTC
(In reply to Katrin Fischer from comment #4)

> The value might have been translated and this would untranslate them.
> Suggestion: Add the English description to the WHERE clauses as well.

+1
Comment 6 Nicolas Hunstein 2025-01-10 14:48:35 UTC
Created attachment 176345 [details] [review]
Bug 38794: update AggregatedFullText description

updates description "Aggregated full" to "Aggregated full text" at authorized value ERM_PACKAGE_CONTENT_TYPE

to test:
- go to Administration/Authorized values
- check authorized values for category ERM_PACKAGE_CONTENT_TYPE
- verify description for AggregatedFullText is Aggregated full

- apply patch
- reset database or reset_all
- verify description has changed to Aggregated full text
Comment 7 Nicolas Hunstein 2025-01-10 14:48:37 UTC
Created attachment 176346 [details] [review]
Bug 38794: (follow-up) add database update
Comment 8 David Nind 2025-01-11 16:49:45 UTC
Created attachment 176405 [details] [review]
Bug 38794: Update authorized value description for AggregatedFullText

Update the authorized value description for AggregatedFullText in
the ERM_PACKAGE_CONTENT_TYPE category from "Aggregated full" to
"Aggregated full text".

Test plan:
1. Go to Administration > Authorized values.
2. Check the authorized values for the ERM_PACKAGE_CONTENT_TYPE
   category.
3. Note that the description for AggregatedFullText is
   "Aggregated full".
4. Apply the patch.
5. Update the database: updatedatabase
   (Bonus: To check for new installations: reset_all)
6. Refresh the page and note that the description is
   now "Aggregated full text".

Signed-off-by: David Nind <david@davidnind.com>
Comment 9 David Nind 2025-01-11 16:49:48 UTC
Created attachment 176406 [details] [review]
Bug 38794: (follow-up) Add database update

Signed-off-by: David Nind <david@davidnind.com>
Comment 10 David Nind 2025-01-11 16:55:04 UTC
The database update didn't work, as the SQL statement was split across lines in the file.

I've fixed the database patch to correct this.

I also edited the commit messages and added a release note - hope you don't mind!
Comment 11 Jonathan Druart 2025-01-23 11:54:52 UTC
Created attachment 176951 [details] [review]
Bug 38794: Update authorized value description for AggregatedFullText

Update the authorized value description for AggregatedFullText in
the ERM_PACKAGE_CONTENT_TYPE category from "Aggregated full" to
"Aggregated full text".

Test plan:
1. Go to Administration > Authorized values.
2. Check the authorized values for the ERM_PACKAGE_CONTENT_TYPE
   category.
3. Note that the description for AggregatedFullText is
   "Aggregated full".
4. Apply the patch.
5. Update the database: updatedatabase
   (Bonus: To check for new installations: reset_all)
6. Refresh the page and note that the description is
   now "Aggregated full text".

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 12 Jonathan Druart 2025-01-23 11:54:55 UTC
Created attachment 176952 [details] [review]
Bug 38794: (follow-up) Add database update

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 13 Jonathan Druart 2025-01-23 11:54:57 UTC
Created attachment 176953 [details] [review]
Bug 38794: say_success only if updated

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 14 Katrin Fischer 2025-01-24 15:15:18 UTC
Pushed for 25.05!

Well done everyone, thank you!