in ERM_PACKAGE_CONTENT_TYPE auth values, AggregatedFullText description is currently "Aggregated full" it should be "Aggregated full text"
Created attachment 176328 [details] [review] Bug 38794: update AggregatedFullText description updates description "Aggregated full" to "Aggregated full text" at authorized value ERM_PACKAGE_CONTENT_TYPE to test: - go to Administration/Authorized values - check authorized values for category ERM_PACKAGE_CONTENT_TYPE - verify description for AggregatedFullText is Aggregated full - apply patch - reset database or reset_all - verify description has changed to Aggregated full text
Created attachment 176329 [details] [review] Bug 38794: update AggregatedFullText description updates description "Aggregated full" to "Aggregated full text" at authorized value ERM_PACKAGE_CONTENT_TYPE to test: - go to Administration/Authorized values - check authorized values for category ERM_PACKAGE_CONTENT_TYPE - verify description for AggregatedFullText is Aggregated full - apply patch - reset database or reset_all - verify description has changed to Aggregated full text
This is missing an atomic update. Kohas that are upgrading also need this description updated: update authorised_values set lib = "Aggregated full text" where category = "ERM_PACKAGE_CONTENT_TYPE" AND authorised_value="AggregatedFullTex t";
(In reply to Pedro Amorim from comment #3) > This is missing an atomic update. Kohas that are upgrading also need this > description updated: > update authorised_values set lib = "Aggregated full text" where category = > "ERM_PACKAGE_CONTENT_TYPE" AND authorised_value="AggregatedFullTex > t"; The value might have been translated and this would untranslate them. Suggestion: Add the English description to the WHERE clauses as well.
(In reply to Katrin Fischer from comment #4) > The value might have been translated and this would untranslate them. > Suggestion: Add the English description to the WHERE clauses as well. +1
Created attachment 176345 [details] [review] Bug 38794: update AggregatedFullText description updates description "Aggregated full" to "Aggregated full text" at authorized value ERM_PACKAGE_CONTENT_TYPE to test: - go to Administration/Authorized values - check authorized values for category ERM_PACKAGE_CONTENT_TYPE - verify description for AggregatedFullText is Aggregated full - apply patch - reset database or reset_all - verify description has changed to Aggregated full text
Created attachment 176346 [details] [review] Bug 38794: (follow-up) add database update
Created attachment 176405 [details] [review] Bug 38794: Update authorized value description for AggregatedFullText Update the authorized value description for AggregatedFullText in the ERM_PACKAGE_CONTENT_TYPE category from "Aggregated full" to "Aggregated full text". Test plan: 1. Go to Administration > Authorized values. 2. Check the authorized values for the ERM_PACKAGE_CONTENT_TYPE category. 3. Note that the description for AggregatedFullText is "Aggregated full". 4. Apply the patch. 5. Update the database: updatedatabase (Bonus: To check for new installations: reset_all) 6. Refresh the page and note that the description is now "Aggregated full text". Signed-off-by: David Nind <david@davidnind.com>
Created attachment 176406 [details] [review] Bug 38794: (follow-up) Add database update Signed-off-by: David Nind <david@davidnind.com>
The database update didn't work, as the SQL statement was split across lines in the file. I've fixed the database patch to correct this. I also edited the commit messages and added a release note - hope you don't mind!