Summary: | Guarantor does not check non members guarantor while deleting with ChildNeedsGuarantor | ||
---|---|---|---|
Product: | Koha | Reporter: | Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski> |
Component: | Patrons | Assignee: | Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski> |
Status: | Pushed to main --- | QA Contact: | Lisette Scheer <lisette> |
Severity: | normal | ||
Priority: | P5 - low | CC: | gmcharlt, kyle.m.hall, lisette, mteal, thibault.keromnes |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: |
This patch allows a librarian to replace a member guarantor with a non-member guarantor. Before this patch, saving a child's profile with the "delete [this guarantor]" box checked and the data entered in the non-member guarantor field resulted in an error because koha refused to delete the last guarantor.
|
|
Version(s) released in: |
25.05.00
|
Circulation function: | |
Attachments: |
Bug 38841: Check non-patron guarantor while deleting patron guarantor
Bug 38841: Check non-patron guarantor while deleting patron guarantor Bug 38841: Check non-patron guarantor while deleting patron guarantor |
Description
Baptiste Wojtkowski (bwoj)
2025-01-07 15:49:10 UTC
Created attachment 176200 [details] [review] Bug 38841: Check non-patron guarantor while deleting patron guarantor When editing a child while Childneedsquarantor active, trying to delete a guarantor while saving a non-patron guarantor will prevent the user from saving. However, if an adult has expired, some librarian would like to remove the account and let some information in non-patron guarantor. TEST PLAN Before applying patch 1 - Open Lisa Charles'page, add Henry Acevedo as Guarantor, also fill Guarantor surname and firstname 2 - Edit the page and try and remove Henry Acevedo, it won't work however there is still one guarantor 3 - Apply patch 4 - Try and remove Henry Acevedo -> it will work 5 - add HA as a guarantor again 6 - try and remove him AND let guarantor firstname and surname empty -> you can't 7 - Add HA and Edna Acosta as guarantor 8 - Remove HA and ler guarantor firstname and surname empty -> you can Created attachment 176500 [details] [review] Bug 38841: Check non-patron guarantor while deleting patron guarantor When editing a child while Childneedsquarantor active, trying to delete a guarantor while saving a non-patron guarantor will prevent the user from saving. However, if an adult has expired, some librarian would like to remove the account and let some information in non-patron guarantor. TEST PLAN Before applying patch 1 - Open Lisa Charles'page, add Henry Acevedo as Guarantor, also fill Guarantor surname and firstname 2 - Edit the page and try and remove Henry Acevedo, it won't work however there is still one guarantor 3 - Apply patch 4 - Try and remove Henry Acevedo -> it will work 5 - add HA as a guarantor again 6 - try and remove him AND let guarantor firstname and surname empty -> you can't 7 - Add HA and Edna Acosta as guarantor 8 - Remove HA and ler guarantor firstname and surname empty -> you can Signed-off-by: Thibault Keromnes <thibault.keromnes@univ-paris8.fr> While we're waiting for this fix, does anyone have a workaround? You can temporarily disable the syspref ChildNeedsGuarantor before editing a child, or apply temporarily this patch Created attachment 178868 [details] [review] Bug 38841: Check non-patron guarantor while deleting patron guarantor When editing a child while Childneedsquarantor active, trying to delete a guarantor while saving a non-patron guarantor will prevent the user from saving. However, if an adult has expired, some librarian would like to remove the account and let some information in non-patron guarantor. Worked as expected! TEST PLAN Before applying patch 1 - Open Lisa Charles'page, add Henry Acevedo as Guarantor, also fill Guarantor surname and firstname 2 - Edit the page and try and remove Henry Acevedo, it won't work however there is still one guarantor 3 - Apply patch 4 - Try and remove Henry Acevedo -> it will work 5 - add HA as a guarantor again 6 - try and remove him AND let guarantor firstname and surname empty -> you can't 7 - Add HA and Edna Acosta as guarantor 8 - Remove HA and ler guarantor firstname and surname empty -> you can Signed-off-by: Thibault Keromnes <thibault.keromnes@univ-paris8.fr> Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> Can you please add some info to the release notes? Change makes sense, but it will be good to inform. Pushed for 25.05! Well done everyone, thank you! |