Bug 38841 - Guarantor does not check non members guarantor while deleting with ChildNeedsGuarantor
Summary: Guarantor does not check non members guarantor while deleting with ChildNeeds...
Status: Signed Off
Alias: None
Product: Koha
Classification: Unclassified
Component: Patrons (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-01-07 15:49 UTC by Baptiste Wojtkowski (bwoj)
Modified: 2025-01-14 13:00 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 38841: Check non-patron guarantor while deleting patron guarantor (1.99 KB, patch)
2025-01-07 16:01 UTC, Baptiste Wojtkowski (bwoj)
Details | Diff | Splinter Review
Bug 38841: Check non-patron guarantor while deleting patron guarantor (2.05 KB, patch)
2025-01-14 12:58 UTC, Thibault Keromnès
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Baptiste Wojtkowski (bwoj) 2025-01-07 15:49:10 UTC
Steps to reproduce:
1 - Edit a Child, add a guarantor and a non-member guarantor
2 - Try to remove the guarantor while letting the non-member guarantor -> you cannot
Comment 1 Baptiste Wojtkowski (bwoj) 2025-01-07 16:01:34 UTC
Created attachment 176200 [details] [review]
Bug 38841: Check non-patron guarantor while deleting patron guarantor

When editing a child while Childneedsquarantor active, trying to delete
a guarantor while saving a non-patron guarantor will prevent the user
from saving. However, if an adult has expired, some librarian would like
to remove the account and let some information in non-patron guarantor.

TEST PLAN

Before applying patch
1 - Open Lisa Charles'page, add Henry Acevedo as Guarantor, also fill
  Guarantor surname and firstname
2 - Edit the page and try and remove Henry Acevedo, it won't work
  however there is still one guarantor

3 - Apply patch
4 - Try and remove Henry Acevedo -> it will work
5 - add HA as a guarantor again
6 - try and remove him AND let guarantor firstname and surname empty ->
  you can't
7 - Add HA and Edna Acosta as guarantor
8 - Remove HA and ler guarantor firstname and surname empty -> you can
Comment 2 Thibault Keromnès 2025-01-14 12:58:34 UTC
Created attachment 176500 [details] [review]
Bug 38841: Check non-patron guarantor while deleting patron guarantor

When editing a child while Childneedsquarantor active, trying to delete
a guarantor while saving a non-patron guarantor will prevent the user
from saving. However, if an adult has expired, some librarian would like
to remove the account and let some information in non-patron guarantor.

TEST PLAN

Before applying patch
1 - Open Lisa Charles'page, add Henry Acevedo as Guarantor, also fill
  Guarantor surname and firstname
2 - Edit the page and try and remove Henry Acevedo, it won't work
  however there is still one guarantor

3 - Apply patch
4 - Try and remove Henry Acevedo -> it will work
5 - add HA as a guarantor again
6 - try and remove him AND let guarantor firstname and surname empty ->
  you can't
7 - Add HA and Edna Acosta as guarantor
8 - Remove HA and ler guarantor firstname and surname empty -> you can

Signed-off-by: Thibault Keromnes <thibault.keromnes@univ-paris8.fr>