Bug 38874

Summary: Typo in UpdateItemLocationOnCheckout and UpdateItemLocationOnCheckin example
Product: Koha Reporter: Aude Charillon <aude.charillon>
Component: System AdministrationAssignee: Nicolas Hunstein <nicolas.hunstein>
Status: Pushed to main --- QA Contact: Emily Lamancusa (emlam) <emily.lamancusa>
Severity: trivial    
Priority: P5 - low CC: emily.lamancusa, gmcharlt, nicolas.hunstein
Version: unspecified   
Hardware: All   
OS: All   
GIT URL: Change sponsored?: ---
Patch complexity: String patch Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
25.05.00
Circulation function:
Attachments: Bug 38874: update descriptions of "UpdateItemLocationOnCheckout" and "UpdateItemLocationOnCheckin"
Bug 38874: update descriptions of "UpdateItemLocationOnCheckout" and "UpdateItemLocationOnCheckin"
Bug 38874: update descriptions of "UpdateItemLocationOnCheckout" and "UpdateItemLocationOnCheckin"

Description Aude Charillon 2025-01-13 16:39:27 UTC
In the description for the UpdateItemLocationOnCheckout system preference, the Examples section contains the line: "PROC: _PERM_ - causes an item that is in the Processing Center to be updated to it's permanent location." This is not grammatically correct: it should be "its permanent location".
Comment 1 Aude Charillon 2025-01-13 16:52:44 UTC
The exact same wording is used for the UpdateItemLocationOnCheckin system preference and should also be corrected.
Comment 2 Nicolas Hunstein 2025-01-15 08:00:12 UTC
Created attachment 176543 [details] [review]
Bug 38874: update descriptions of  "UpdateItemLocationOnCheckout" and "UpdateItemLocationOnCheckin"

updates description "PROC: _PERM_ - causes an item that is in the Processing center to be updated to it's permanent location." to "PROC: _PERM_ - causes an item that is in the Processing center to be updated to its permanent location."

to test:
- go to Administration/System preferences
- check descriptionss for system preferences UpdateItemLocationOnCheckout and UpdateItemLocationOnCheckin
- verify descriptions contain "it's" instead of "its" in the place "PROC: _PERM_ ..."

- apply patch
- verify descriptions have changed to "its"
Comment 3 Biblibre Sandboxes 2025-01-15 10:56:23 UTC
Created attachment 176549 [details] [review]
Bug 38874: update descriptions of "UpdateItemLocationOnCheckout" and "UpdateItemLocationOnCheckin"

updates description "PROC: _PERM_ - causes an item that is in the Processing center to be updated to it's permanent location." to "PROC: _PERM_ - causes an item that is in the Processing center to be updated to its permanent location."

to test:
- go to Administration/System preferences
- check descriptionss for system preferences UpdateItemLocationOnCheckout and UpdateItemLocationOnCheckin
- verify descriptions contain "it's" instead of "its" in the place "PROC: _PERM_ ..."

- apply patch
- verify descriptions have changed to "its"

Signed-off-by: Aude <aude.charillon@ptfs-europe.com>
Comment 4 Aude Charillon 2025-01-15 11:09:13 UTC
Both typos corrected :)
Comment 5 Emily Lamancusa (emlam) 2025-01-24 18:01:12 UTC
Created attachment 177130 [details] [review]
Bug 38874: update descriptions of "UpdateItemLocationOnCheckout" and "UpdateItemLocationOnCheckin"

updates description "PROC: _PERM_ - causes an item that is in the Processing center to be updated to it's permanent location." to "PROC: _PERM_ - causes an item that is in the Processing center to be updated to its permanent location."

to test:
- go to Administration/System preferences
- check descriptionss for system preferences UpdateItemLocationOnCheckout and UpdateItemLocationOnCheckin
- verify descriptions contain "it's" instead of "its" in the place "PROC: _PERM_ ..."

- apply patch
- verify descriptions have changed to "its"

Signed-off-by: Aude <aude.charillon@ptfs-europe.com>
Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
Comment 6 Emily Lamancusa (emlam) 2025-01-24 18:01:41 UTC
Nice catch, thanks Aude and Nicolas!
Comment 7 Katrin Fischer 2025-01-30 17:56:13 UTC
Pushed for 25.05!

Well done everyone, thank you!