In the description for the UpdateItemLocationOnCheckout system preference, the Examples section contains the line: "PROC: _PERM_ - causes an item that is in the Processing Center to be updated to it's permanent location." This is not grammatically correct: it should be "its permanent location".
The exact same wording is used for the UpdateItemLocationOnCheckin system preference and should also be corrected.
Created attachment 176543 [details] [review] Bug 38874: update descriptions of "UpdateItemLocationOnCheckout" and "UpdateItemLocationOnCheckin" updates description "PROC: _PERM_ - causes an item that is in the Processing center to be updated to it's permanent location." to "PROC: _PERM_ - causes an item that is in the Processing center to be updated to its permanent location." to test: - go to Administration/System preferences - check descriptionss for system preferences UpdateItemLocationOnCheckout and UpdateItemLocationOnCheckin - verify descriptions contain "it's" instead of "its" in the place "PROC: _PERM_ ..." - apply patch - verify descriptions have changed to "its"
Created attachment 176549 [details] [review] Bug 38874: update descriptions of "UpdateItemLocationOnCheckout" and "UpdateItemLocationOnCheckin" updates description "PROC: _PERM_ - causes an item that is in the Processing center to be updated to it's permanent location." to "PROC: _PERM_ - causes an item that is in the Processing center to be updated to its permanent location." to test: - go to Administration/System preferences - check descriptionss for system preferences UpdateItemLocationOnCheckout and UpdateItemLocationOnCheckin - verify descriptions contain "it's" instead of "its" in the place "PROC: _PERM_ ..." - apply patch - verify descriptions have changed to "its" Signed-off-by: Aude <aude.charillon@ptfs-europe.com>
Both typos corrected :)
Created attachment 177130 [details] [review] Bug 38874: update descriptions of "UpdateItemLocationOnCheckout" and "UpdateItemLocationOnCheckin" updates description "PROC: _PERM_ - causes an item that is in the Processing center to be updated to it's permanent location." to "PROC: _PERM_ - causes an item that is in the Processing center to be updated to its permanent location." to test: - go to Administration/System preferences - check descriptionss for system preferences UpdateItemLocationOnCheckout and UpdateItemLocationOnCheckin - verify descriptions contain "it's" instead of "its" in the place "PROC: _PERM_ ..." - apply patch - verify descriptions have changed to "its" Signed-off-by: Aude <aude.charillon@ptfs-europe.com> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
Nice catch, thanks Aude and Nicolas!
Pushed for 25.05! Well done everyone, thank you!