Bug 38876

Summary: Typo in UpdateNotForLoanStatusOnCheckout description
Product: Koha Reporter: Aude Charillon <aude.charillon>
Component: System AdministrationAssignee: Jessie Zairo <jzairo>
Status: Failed QA --- QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: andrew.auld, dcook, gmcharlt, jzairo
Version: unspecified   
Hardware: All   
OS: All   
GIT URL: Initiative type: ---
Sponsorship status: --- Comma delimited list of Sponsors:
Crowdfunding goal: 0 Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:
Attachments: Bug 38876: Fixed typo in descrption of UpdateNotForLoanStatusOnCheckout
Bug 38876: Fixed typo in descrption of UpdateNotForLoanStatusOnCheckout
Bug 38876: Fixed typo in descrption of UpdateNotForLoanStatusOnCheckout

Description Aude Charillon 2025-01-13 16:59:27 UTC
In the description of the UpdateNotForLoanStatusOnCheckout system preference, the sentence: "When an item is checked out, if the not for loan value on the left matches the items not for loan value it will be updated to the right-hand value" should be corrected to "When an item is checked out, if its not for loan value matches the value on the left, then the item's not for loan value will be updated to the value on the right".
Comment 1 Jessie Zairo 2025-11-22 02:57:31 UTC
Created attachment 189891 [details] [review]
Bug 38876: Fixed typo in descrption of UpdateNotForLoanStatusOnCheckout

Test Plan
    1.before applying, navigate to administration->system preferences -> UpdateNotForLoanStatusOnCheckout
    2.observe the language in the description "When an item is checked out, if the not for loan value on the left matches the items not for loan value it will be updated to the right-hand value"
    3.apply the patch
    4.navigate to administration->system preferences -> UpdateNotForLoanStatusOnCheckout
    5.observe the language in the description has been updated to "When an item is checked out, if its not for loan value matches the value on the left, then the items not for loan value will be updated to the value on the right"
    6.Do a reset all and confirm the language is correct
Comment 2 OpenFifth Sandboxes 2025-11-22 17:40:42 UTC
Created attachment 189893 [details] [review]
Bug 38876: Fixed typo in descrption of UpdateNotForLoanStatusOnCheckout

    Test Plan
    1.before applying, navigate to administration->system preferences -> UpdateNotForLoanStatusOnCheckout
    2.observe the language in the description "When an item is checked out, if the not for loan value on the left matches the items not for loan value it will be updated to the right-hand value"
    3.apply the patch
    4.navigate to administration->system preferences -> UpdateNotForLoanStatusOnCheckout
    5.observe the language in the description has been updated to "When an item is checked out, if its not for loan value matches the value on the left, then the items not for loan value will be updated to the value on the right"
    6.Do a reset all and confirm the language is correct

Signed-off-by: Andrew Auld <andrew.auld@openfifth.co.uk>
Comment 3 Andrew Auld 2025-11-22 17:42:24 UTC
Great job! looks perfect to me.
I hear this is your first patch…awesome!
Comment 4 David Cook 2025-11-23 01:39:12 UTC
This looks wonderful, Jessie!

This does a great job of updating the system preference description in the UI, and updating description in the database for new Koha installations. Unfortunately, it doesn't update the system preference in the database for existing Koha installations. While users won't be able to notice this, I think that we generally try to keep the database values and the values in sysprefs.sql in sync. I'm sorry but I think I need to mark this as Failed QA!

Happy to help you with creating the database upgrade for the missing piece!
Comment 5 OpenFifth Sandboxes 2025-11-24 07:12:38 UTC
Created attachment 189900 [details] [review]
Bug 38876: Fixed typo in descrption of UpdateNotForLoanStatusOnCheckout

    Test Plan
    1.before applying, navigate to administration->system preferences -> UpdateNotForLoanStatusOnCheckout
    2.observe the language in the description "When an item is checked out, if the not for loan value on the left matches the items not for loan value it will be updated to the right-hand value"
    3.apply the patch
    4.navigate to administration->system preferences -> UpdateNotForLoanStatusOnCheckout
    5.observe the language in the description has been updated to "When an item is checked out, if its not for loan value matches the value on the left, then the items not for loan value will be updated to the value on the right"
    6.Do a reset all and confirm the language is correct

Signed-off-by: Andrew Auld <andrew.auld@openfifth.co.uk>