In the description of the UpdateNotForLoanStatusOnCheckout system preference, the sentence: "When an item is checked out, if the not for loan value on the left matches the items not for loan value it will be updated to the right-hand value" should be corrected to "When an item is checked out, if its not for loan value matches the value on the left, then the item's not for loan value will be updated to the value on the right".
Created attachment 189891 [details] [review] Bug 38876: Fixed typo in descrption of UpdateNotForLoanStatusOnCheckout Test Plan 1.before applying, navigate to administration->system preferences -> UpdateNotForLoanStatusOnCheckout 2.observe the language in the description "When an item is checked out, if the not for loan value on the left matches the items not for loan value it will be updated to the right-hand value" 3.apply the patch 4.navigate to administration->system preferences -> UpdateNotForLoanStatusOnCheckout 5.observe the language in the description has been updated to "When an item is checked out, if its not for loan value matches the value on the left, then the items not for loan value will be updated to the value on the right" 6.Do a reset all and confirm the language is correct
Created attachment 189893 [details] [review] Bug 38876: Fixed typo in descrption of UpdateNotForLoanStatusOnCheckout Test Plan 1.before applying, navigate to administration->system preferences -> UpdateNotForLoanStatusOnCheckout 2.observe the language in the description "When an item is checked out, if the not for loan value on the left matches the items not for loan value it will be updated to the right-hand value" 3.apply the patch 4.navigate to administration->system preferences -> UpdateNotForLoanStatusOnCheckout 5.observe the language in the description has been updated to "When an item is checked out, if its not for loan value matches the value on the left, then the items not for loan value will be updated to the value on the right" 6.Do a reset all and confirm the language is correct Signed-off-by: Andrew Auld <andrew.auld@openfifth.co.uk>
Great job! looks perfect to me. I hear this is your first patch…awesome!
This looks wonderful, Jessie! This does a great job of updating the system preference description in the UI, and updating description in the database for new Koha installations. Unfortunately, it doesn't update the system preference in the database for existing Koha installations. While users won't be able to notice this, I think that we generally try to keep the database values and the values in sysprefs.sql in sync. I'm sorry but I think I need to mark this as Failed QA! Happy to help you with creating the database upgrade for the missing piece!
Created attachment 189900 [details] [review] Bug 38876: Fixed typo in descrption of UpdateNotForLoanStatusOnCheckout Test Plan 1.before applying, navigate to administration->system preferences -> UpdateNotForLoanStatusOnCheckout 2.observe the language in the description "When an item is checked out, if the not for loan value on the left matches the items not for loan value it will be updated to the right-hand value" 3.apply the patch 4.navigate to administration->system preferences -> UpdateNotForLoanStatusOnCheckout 5.observe the language in the description has been updated to "When an item is checked out, if its not for loan value matches the value on the left, then the items not for loan value will be updated to the value on the right" 6.Do a reset all and confirm the language is correct Signed-off-by: Andrew Auld <andrew.auld@openfifth.co.uk>
Created attachment 190798 [details] [review] Bug 38876: (QA follow-up) automicupdate
added patch to update the system preference in the database for existing Koha installations.
Created attachment 190799 [details] [review] Bug 38876: (follow-up) fix db rev syntax was wrong for dbrev To test apply patches dbic updatedatatbase koha-mysql kohadev select * from systempreferences where variable='UpdateNotForLoanStatusOnCheckout'; confirm the updated description
Created attachment 190899 [details] [review] Bug 38876: Fixed typo in descrption of UpdateNotForLoanStatusOnCheckout Test Plan 1. Before applying, navigate to administration->system preferences -> UpdateNotForLoanStatusOnCheckout 2. Observe the language in the description "When an item is checked out, if the not for loan value on the left matches the items not for loan value it will be updated to the right-hand value" 3. Apply the patch 4. Navigate to administration->system preferences -> UpdateNotForLoanStatusOnCheckout 5. Observe the language in the description has been updated to "When an item is checked out, if its not for loan value matches the value on the left, then the items not for loan value will be updated to the value on the right" 6. Do a reset all and confirm the language is correct Signed-off-by: Andrew Auld <andrew.auld@openfifth.co.uk> Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 190900 [details] [review] Bug 38876: (QA follow-up) automicupdate Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 190901 [details] [review] Bug 38876: (follow-up) fix db rev syntax was wrong for dbrev To test apply patches dbic updatedatatbase koha-mysql kohadev select * from systempreferences where variable='UpdateNotForLoanStatusOnCheckout'; confirm the updated description Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 191030 [details] [review] Bug 38876: Fixed typo in descrption of UpdateNotForLoanStatusOnCheckout Test Plan 1. Before applying, navigate to administration->system preferences -> UpdateNotForLoanStatusOnCheckout 2. Observe the language in the description "When an item is checked out, if the not for loan value on the left matches the items not for loan value it will be updated to the right-hand value" 3. Apply the patch 4. Navigate to administration->system preferences -> UpdateNotForLoanStatusOnCheckout 5. Observe the language in the description has been updated to "When an item is checked out, if its not for loan value matches the value on the left, then the items not for loan value will be updated to the value on the right" 6. Do a reset all and confirm the language is correct Signed-off-by: Andrew Auld <andrew.auld@openfifth.co.uk> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 191031 [details] [review] Bug 38876: (QA follow-up) automicupdate Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 191032 [details] [review] Bug 38876: (follow-up) fix db rev syntax was wrong for dbrev To test apply patches dbic updatedatatbase koha-mysql kohadev select * from systempreferences where variable='UpdateNotForLoanStatusOnCheckout'; confirm the updated description Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Nice work everyone! Pushed to main for 26.05
All pushed to 25.11.x Thanks all!