Bug 38919

Summary: Checkin does not notify of waiting holds
Product: Koha Reporter: Emily Lamancusa (emlam) <emily.lamancusa>
Component: Hold requestsAssignee: Emily Lamancusa (emlam) <emily.lamancusa>
Status: Pushed to stable --- QA Contact: Lisette Scheer <lisette>
Severity: major    
Priority: P5 - low CC: andrew, cbrannon, gmcharlt, lisette, m.de.rooy, me
Version: MainKeywords: regression, rel_24_11_candidate
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
25.05.00,24.11.02
Circulation function:
Bug Depends on: 35402    
Bug Blocks: 37650    
Attachments: Bug 38919: hold-found1 modal needs block class
Bug 38919: hold-found1 modal needs block class
Bug 38919: hold-found1 modal needs block class

Description Emily Lamancusa (emlam) 2025-01-17 16:27:53 UTC
In previous versions, if an item is checked in when it is already waiting for a hold, Koha displays a modal showing that the hold is already waiting, and giving the option to re-confirm or cancel the hold.

In 24.11 and main, the modal doesn't trigger - the "not checked out" message is displayed at the top of the screen, and there is no indication given that the item is already assigned to a waiting hold.
Comment 1 Emily Lamancusa (emlam) 2025-01-17 16:51:39 UTC
Created attachment 176746 [details] [review]
Bug 38919: hold-found1 modal needs block class

After the upgrade to Bootstrap 5, modals need either the block or
noblock class in order to be shown. The class was missing from the modal
that appears when an item is checked in after it is already waiting for
a hold.

To test:
1. Place a hold on an item for pickup at the logged-in branch
2. Check in the item and confirm the hold
3. Check in the item again
--> There is no notification that the item is already assigned to a
waiting hold, just a "Not checked out" message
4. Apply patch
5. Navigate away from the page (we can't simply refresh the page because
   we don't want to resubmit the request just yet)
6. Check in the item again
--> A modal appears notifying of the waiting hold
Comment 2 Roman Dolny 2025-01-17 18:59:04 UTC
Created attachment 176753 [details] [review]
Bug 38919: hold-found1 modal needs block class

After the upgrade to Bootstrap 5, modals need either the block or
noblock class in order to be shown. The class was missing from the modal
that appears when an item is checked in after it is already waiting for
a hold.

To test:
1. Place a hold on an item for pickup at the logged-in branch
2. Check in the item and confirm the hold
3. Check in the item again
--> There is no notification that the item is already assigned to a
waiting hold, just a "Not checked out" message
4. Apply patch
5. Navigate away from the page (we can't simply refresh the page because
   we don't want to resubmit the request just yet)
6. Check in the item again
--> A modal appears notifying of the waiting hold

Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>
Comment 3 Lisette Scheer 2025-01-17 21:20:58 UTC
Created attachment 176759 [details] [review]
Bug 38919: hold-found1 modal needs block class

After the upgrade to Bootstrap 5, modals need either the block or
noblock class in order to be shown. The class was missing from the modal
that appears when an item is checked in after it is already waiting for
a hold.

To test:
1. Place a hold on an item for pickup at the logged-in branch
2. Check in the item and confirm the hold
3. Check in the item again
--> There is no notification that the item is already assigned to a
waiting hold, just a "Not checked out" message
4. Apply patch
5. Navigate away from the page (we can't simply refresh the page because
   we don't want to resubmit the request just yet)
6. Check in the item again
--> A modal appears notifying of the waiting hold

Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>
Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com>
Comment 4 Katrin Fischer 2025-01-21 14:57:26 UTC
Pushed for 25.05!

Well done everyone, thank you!
Comment 5 Lisette Scheer 2025-01-23 20:54:13 UTC
*** Bug 38960 has been marked as a duplicate of this bug. ***
Comment 6 Andrew Fuerste-Henry 2025-01-31 14:12:06 UTC
CCing Paul Derscheid for 24.11 backport. Thanks!
Comment 7 Paul Derscheid 2025-02-04 21:54:53 UTC
Nice work everyone!

Pushed to 24.11.x for 24.11.02