In previous versions, if an item is checked in when it is already waiting for a hold, Koha displays a modal showing that the hold is already waiting, and giving the option to re-confirm or cancel the hold. In 24.11 and main, the modal doesn't trigger - the "not checked out" message is displayed at the top of the screen, and there is no indication given that the item is already assigned to a waiting hold.
Created attachment 176746 [details] [review] Bug 38919: hold-found1 modal needs block class After the upgrade to Bootstrap 5, modals need either the block or noblock class in order to be shown. The class was missing from the modal that appears when an item is checked in after it is already waiting for a hold. To test: 1. Place a hold on an item for pickup at the logged-in branch 2. Check in the item and confirm the hold 3. Check in the item again --> There is no notification that the item is already assigned to a waiting hold, just a "Not checked out" message 4. Apply patch 5. Navigate away from the page (we can't simply refresh the page because we don't want to resubmit the request just yet) 6. Check in the item again --> A modal appears notifying of the waiting hold
Created attachment 176753 [details] [review] Bug 38919: hold-found1 modal needs block class After the upgrade to Bootstrap 5, modals need either the block or noblock class in order to be shown. The class was missing from the modal that appears when an item is checked in after it is already waiting for a hold. To test: 1. Place a hold on an item for pickup at the logged-in branch 2. Check in the item and confirm the hold 3. Check in the item again --> There is no notification that the item is already assigned to a waiting hold, just a "Not checked out" message 4. Apply patch 5. Navigate away from the page (we can't simply refresh the page because we don't want to resubmit the request just yet) 6. Check in the item again --> A modal appears notifying of the waiting hold Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>
Created attachment 176759 [details] [review] Bug 38919: hold-found1 modal needs block class After the upgrade to Bootstrap 5, modals need either the block or noblock class in order to be shown. The class was missing from the modal that appears when an item is checked in after it is already waiting for a hold. To test: 1. Place a hold on an item for pickup at the logged-in branch 2. Check in the item and confirm the hold 3. Check in the item again --> There is no notification that the item is already assigned to a waiting hold, just a "Not checked out" message 4. Apply patch 5. Navigate away from the page (we can't simply refresh the page because we don't want to resubmit the request just yet) 6. Check in the item again --> A modal appears notifying of the waiting hold Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com>
Pushed for 25.05! Well done everyone, thank you!
*** Bug 38960 has been marked as a duplicate of this bug. ***
CCing Paul Derscheid for 24.11 backport. Thanks!
Nice work everyone! Pushed to 24.11.x for 24.11.02