|
Description
Tomás Cohen Arazi (tcohen)
2025-01-20 19:45:24 UTC
Created attachment 176840 [details] [review] Bug 38931: Unit tests Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 176841 [details] [review] Bug 38931: Add endpoints for individual credits and debits As the title says, we are missing such endpoints and this patch adds them. To test: 1. Apply this patches 2. Run: $ ktd --shell k$ yarn api:bundle k$ prove t/db_dependent/api/v1/patrons_accounts.t => SUCCESS: The spec builds! => SUCCESS: The tests pass! 3. Verify all the codepaths are covered by tests 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 176892 [details] [review] Bug 38931: Unit tests Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> Created attachment 176893 [details] [review] Bug 38931: Add endpoints for individual credits and debits As the title says, we are missing such endpoints and this patch adds them. To test: 1. Apply this patches 2. Run: $ ktd --shell k$ yarn api:bundle k$ prove t/db_dependent/api/v1/patrons_accounts.t => SUCCESS: The spec builds! => SUCCESS: The tests pass! 3. Verify all the codepaths are covered by tests 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> Created attachment 185276 [details] [review] Bug 38931: Unit tests Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> Created attachment 185277 [details] [review] Bug 38931: Add endpoints for individual credits and debits As the title says, we are missing such endpoints and this patch adds them. To test: 1. Apply this patches 2. Run: $ ktd --shell k$ yarn api:bundle k$ prove t/db_dependent/api/v1/patrons_accounts.t => SUCCESS: The spec builds! => SUCCESS: The tests pass! 3. Verify all the codepaths are covered by tests 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> Created attachment 186765 [details] [review] Bug 38931: Unit tests Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> Created attachment 186766 [details] [review] Bug 38931: Add endpoints for individual credits and debits As the title says, we are missing such endpoints and this patch adds them. To test: 1. Apply this patches 2. Run: $ ktd --shell k$ yarn api:bundle k$ prove t/db_dependent/api/v1/patrons_accounts.t => SUCCESS: The spec builds! => SUCCESS: The tests pass! 3. Verify all the codepaths are covered by tests 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> Nice work everyone! Pushed to main for 25.11 |