Adding credits is not setting the Location header for the response. Adding debits does, but before bug 38931 it pointed to a non-existent endpoint.
Created attachment 176842 [details] [review] Bug 38932: Regression tests Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 176843 [details] [review] Bug 38932: Make adding a credit return the Location header This patch makes the `POST /patrons/:patron_id/account/credits` endpoint return a valid `Location` header. Tests are added. Bonus: the debits counterpart already returned the header, but pointed to a non-existent endpoint (now added by bug 38931) and it gets tests added. To test: 1. Apply the regression tests patch 2. Run: $ ktd --shell k$ prove t/db_dependent/api/v1/patrons_accounts.t => FAIL: The behavior is not implemented for credits. 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 176896 [details] [review] Bug 38932: Regression tests Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com>
Created attachment 176897 [details] [review] Bug 38932: Make adding a credit return the Location header This patch makes the `POST /patrons/:patron_id/account/credits` endpoint return a valid `Location` header. Tests are added. Bonus: the debits counterpart already returned the header, but pointed to a non-existent endpoint (now added by bug 38931) and it gets tests added. To test: 1. Apply the regression tests patch 2. Run: $ ktd --shell k$ prove t/db_dependent/api/v1/patrons_accounts.t => FAIL: The behavior is not implemented for credits. 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com>
Testing notes (using KTD): 1. Apply 38931 2. Run yarn api:bundle 3. Follow the test plan for this bug (38932)
Created attachment 177111 [details] [review] Bug 38932: Regression tests Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
Created attachment 177112 [details] [review] Bug 38932: Make adding a credit return the Location header This patch makes the `POST /patrons/:patron_id/account/credits` endpoint return a valid `Location` header. Tests are added. Bonus: the debits counterpart already returned the header, but pointed to a non-existent endpoint (now added by bug 38931) and it gets tests added. To test: 1. Apply the regression tests patch 2. Run: $ ktd --shell k$ prove t/db_dependent/api/v1/patrons_accounts.t => FAIL: The behavior is not implemented for credits. 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
Pushed for 25.05! Well done everyone, thank you!