Summary: | Move suppressed record redirection into a sub | ||
---|---|---|---|
Product: | Koha | Reporter: | Tomás Cohen Arazi (tcohen) <tomascohen> |
Component: | Architecture, internals, and plumbing | Assignee: | Tomás Cohen Arazi (tcohen) <tomascohen> |
Status: | Patch doesn't apply --- | QA Contact: | Jonathan Druart <jonathan.druart> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | dcook, didier.gautheron, fridolin.somers, jesse, jonathan.druart, katrin.fischer, laurent.ducos, lisette, lucas, m.de.rooy, martin.renvoize, nick, philippe.blouin, tomascohen |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27734 | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | 28478 | ||
Bug Blocks: | |||
Attachments: |
Bug 38936: Unit tests
Bug 38936: Introduce C4::Output::redirect_if_opac_suppressed Bug 38936: Use redirect_if_opac_suppressed() in opac-*detail.pl pages [24.05.x] Bug 38936: Unit tests [24.05.x] Bug 38936: Introduce C4::Output::redirect_if_opac_suppressed [24.05.x] Bug 38936: Use redirect_if_opac_suppressed() in opac-*detail.pl pages |
Description
Tomás Cohen Arazi (tcohen)
2025-01-21 11:05:51 UTC
Moving to the security component as the diff would expose unpublished code from a `Koha security` bug. Created attachment 176855 [details] [review] Bug 38936: Unit tests Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 176856 [details] [review] Bug 38936: Introduce C4::Output::redirect_if_opac_suppressed Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 176857 [details] [review] Bug 38936: Use redirect_if_opac_suppressed() in opac-*detail.pl pages Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Looking good to me :) Created attachment 178576 [details] [review] [24.05.x] Bug 38936: Unit tests Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 178577 [details] [review] [24.05.x] Bug 38936: Introduce C4::Output::redirect_if_opac_suppressed Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 178578 [details] [review] [24.05.x] Bug 38936: Use redirect_if_opac_suppressed() in opac-*detail.pl pages Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> From a separation of concerns perspective, I don't like the $biblio object being in this function, but having this code in a function is a great step forward. I am ready to QA this as soon as it's signed off. Patch doesn't apply |