Bug 27734 - OpacHiddenItems produces a 404 from borrower holds list
Summary: OpacHiddenItems produces a 404 from borrower holds list
Status: Passed QA
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Nick Clemens
QA Contact: Tomás Cohen Arazi
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-02-19 15:59 UTC by Martha Fuerst
Modified: 2021-06-15 12:28 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 27734: Add OpacHiddenRecordRedirect and OpacHiddenRecordMessage system preferences (6.55 KB, patch)
2021-06-09 19:33 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 27734: Add OpacHiddenRecordRedirect and OpacHiddenRecordMessage system preferences (6.55 KB, patch)
2021-06-10 16:14 UTC, PTFS Europe Sandboxes
Details | Diff | Splinter Review
Bug 27734: Add OpacHiddenRecordRedirect and OpacHiddenRecordMessage system preferences (7.70 KB, patch)
2021-06-15 12:03 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 27734: Add OpacHiddenRecordRedirect and OpacHiddenRecordMessage system preferences (6.60 KB, patch)
2021-06-15 12:13 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 27734: Add OpacHiddenRecordRedirect and OpacHiddenRecordMessage system preferences (7.71 KB, patch)
2021-06-15 12:28 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Martha Fuerst 2021-02-19 15:59:28 UTC
When a borrower clicks on a hold in their holds list they have placed on a title that was subsequently hidden with OpacHiddenItems, it results in a 404 error instead of the "This record is blocked" error page.

It seems like OpacHiddenItems should work the same as individually suppressed records and how they are handled in OpacSuppressionRedirect. This would make more sense from the user's perspective.
Comment 1 Nick Clemens 2021-06-09 19:33:37 UTC
Created attachment 121749 [details] [review]
Bug 27734: Add OpacHiddenRecordRedirect and OpacHiddenRecordMessage system preferences

This patch adds options analogous to OpacSuppressionRedirect and OpacSuppressionMessage for OpacHiddtenItems

Test plan:
1 - Apply patch
2 - Test OpacSupressionsRedirect and OpacSuppressionMessage prefs to ensure they work as before
3 - Enable OpacHiddenItemsHidesRecord and hide a biblio using OpacHiddenItems:
    biblionumber: [303]
3 - Test OpacHiddenRecordRedirect and OpacHiddenRecordMessage to ensure they work as expected
4 - Hit the link: http://localhost:8080/cgi-bin/koha/opac-detail.pl?biblionumber=303
5 - When OpacHiddenRecordRedirect set to 404 you get a 404
6 - When OpacHiddenRecordRedirect set to 'an explanatory page' you get 'opac-blocked.pl'
7 - If you set a message in  OpacHiddenRecordMessage  it displays on opac-blocked.pl
Comment 2 PTFS Europe Sandboxes 2021-06-10 16:14:30 UTC
Created attachment 121797 [details] [review]
Bug 27734: Add OpacHiddenRecordRedirect and OpacHiddenRecordMessage system preferences

This patch adds options analogous to OpacSuppressionRedirect and OpacSuppressionMessage for OpacHiddtenItems

Test plan:
1 - Apply patch
2 - Test OpacSupressionsRedirect and OpacSuppressionMessage prefs to ensure they work as before
3 - Enable OpacHiddenItemsHidesRecord and hide a biblio using OpacHiddenItems:
    biblionumber: [303]
3 - Test OpacHiddenRecordRedirect and OpacHiddenRecordMessage to ensure they work as expected
4 - Hit the link: http://localhost:8080/cgi-bin/koha/opac-detail.pl?biblionumber=303
5 - When OpacHiddenRecordRedirect set to 404 you get a 404
6 - When OpacHiddenRecordRedirect set to 'an explanatory page' you get 'opac-blocked.pl'
7 - If you set a message in  OpacHiddenRecordMessage  it displays on opac-blocked.pl

Signed-off-by: marti <mfuerst@hmcpl.org>
Comment 3 Nick Clemens 2021-06-15 12:03:20 UTC
Created attachment 121988 [details] [review]
Bug 27734: Add OpacHiddenRecordRedirect and OpacHiddenRecordMessage system preferences

This patch adds options analogous to OpacSuppressionRedirect and OpacSuppressionMessage for OpacHiddtenItems

Test plan:
1 - Apply patch
2 - Test OpacSupressionsRedirect and OpacSuppressionMessage prefs to ensure they work as before
3 - Enable OpacHiddenItemsHidesRecord and hide a biblio using OpacHiddenItems:
    biblionumber: [303]
3 - Test OpacHiddenRecordRedirect and OpacHiddenRecordMessage to ensure they work as expected
4 - Hit the link: http://localhost:8080/cgi-bin/koha/opac-detail.pl?biblionumber=303
5 - When OpacHiddenRecordRedirect set to 404 you get a 404
6 - When OpacHiddenRecordRedirect set to 'an explanatory page' you get 'opac-blocked.pl'
7 - If you set a message in  OpacHiddenRecordMessage  it displays on opac-blocked.pl

Signed-off-by: marti <mfuerst@hmcpl.org>
Comment 4 Tomás Cohen Arazi 2021-06-15 12:13:12 UTC
Created attachment 121989 [details] [review]
Bug 27734: Add OpacHiddenRecordRedirect and OpacHiddenRecordMessage system preferences

This patch adds options analogous to OpacSuppressionRedirect and OpacSuppressionMessage for OpacHiddtenItems

Test plan:
1 - Apply patch
2 - Test OpacSupressionsRedirect and OpacSuppressionMessage prefs to ensure they work as before
3 - Enable OpacHiddenItemsHidesRecord and hide a biblio using OpacHiddenItems:
    biblionumber: [303]
3 - Test OpacHiddenRecordRedirect and OpacHiddenRecordMessage to ensure they work as expected
4 - Hit the link: http://localhost:8080/cgi-bin/koha/opac-detail.pl?biblionumber=303
5 - When OpacHiddenRecordRedirect set to 404 you get a 404
6 - When OpacHiddenRecordRedirect set to 'an explanatory page' you get 'opac-blocked.pl'
7 - If you set a message in  OpacHiddenRecordMessage  it displays on opac-blocked.pl

Signed-off-by: marti <mfuerst@hmcpl.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 5 Tomás Cohen Arazi 2021-06-15 12:28:02 UTC
Created attachment 121990 [details] [review]
Bug 27734: Add OpacHiddenRecordRedirect and OpacHiddenRecordMessage system preferences

This patch adds options analogous to OpacSuppressionRedirect and OpacSuppressionMessage for OpacHiddtenItems

Test plan:
1 - Apply patch
2 - Test OpacSupressionsRedirect and OpacSuppressionMessage prefs to ensure they work as before
3 - Enable OpacHiddenItemsHidesRecord and hide a biblio using OpacHiddenItems:
    biblionumber: [303]
3 - Test OpacHiddenRecordRedirect and OpacHiddenRecordMessage to ensure they work as expected
4 - Hit the link: http://localhost:8080/cgi-bin/koha/opac-detail.pl?biblionumber=303
5 - When OpacHiddenRecordRedirect set to 404 you get a 404
6 - When OpacHiddenRecordRedirect set to 'an explanatory page' you get 'opac-blocked.pl'
7 - If you set a message in  OpacHiddenRecordMessage  it displays on opac-blocked.pl

Signed-off-by: marti <mfuerst@hmcpl.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>