When a borrower clicks on a hold in their holds list they have placed on a title that was subsequently hidden with OpacHiddenItems, it results in a 404 error instead of the "This record is blocked" error page. It seems like OpacHiddenItems should work the same as individually suppressed records and how they are handled in OpacSuppressionRedirect. This would make more sense from the user's perspective.
Created attachment 121749 [details] [review] Bug 27734: Add OpacHiddenRecordRedirect and OpacHiddenRecordMessage system preferences This patch adds options analogous to OpacSuppressionRedirect and OpacSuppressionMessage for OpacHiddtenItems Test plan: 1 - Apply patch 2 - Test OpacSupressionsRedirect and OpacSuppressionMessage prefs to ensure they work as before 3 - Enable OpacHiddenItemsHidesRecord and hide a biblio using OpacHiddenItems: biblionumber: [303] 3 - Test OpacHiddenRecordRedirect and OpacHiddenRecordMessage to ensure they work as expected 4 - Hit the link: http://localhost:8080/cgi-bin/koha/opac-detail.pl?biblionumber=303 5 - When OpacHiddenRecordRedirect set to 404 you get a 404 6 - When OpacHiddenRecordRedirect set to 'an explanatory page' you get 'opac-blocked.pl' 7 - If you set a message in OpacHiddenRecordMessage it displays on opac-blocked.pl
Created attachment 121797 [details] [review] Bug 27734: Add OpacHiddenRecordRedirect and OpacHiddenRecordMessage system preferences This patch adds options analogous to OpacSuppressionRedirect and OpacSuppressionMessage for OpacHiddtenItems Test plan: 1 - Apply patch 2 - Test OpacSupressionsRedirect and OpacSuppressionMessage prefs to ensure they work as before 3 - Enable OpacHiddenItemsHidesRecord and hide a biblio using OpacHiddenItems: biblionumber: [303] 3 - Test OpacHiddenRecordRedirect and OpacHiddenRecordMessage to ensure they work as expected 4 - Hit the link: http://localhost:8080/cgi-bin/koha/opac-detail.pl?biblionumber=303 5 - When OpacHiddenRecordRedirect set to 404 you get a 404 6 - When OpacHiddenRecordRedirect set to 'an explanatory page' you get 'opac-blocked.pl' 7 - If you set a message in OpacHiddenRecordMessage it displays on opac-blocked.pl Signed-off-by: marti <mfuerst@hmcpl.org>
Created attachment 121988 [details] [review] Bug 27734: Add OpacHiddenRecordRedirect and OpacHiddenRecordMessage system preferences This patch adds options analogous to OpacSuppressionRedirect and OpacSuppressionMessage for OpacHiddtenItems Test plan: 1 - Apply patch 2 - Test OpacSupressionsRedirect and OpacSuppressionMessage prefs to ensure they work as before 3 - Enable OpacHiddenItemsHidesRecord and hide a biblio using OpacHiddenItems: biblionumber: [303] 3 - Test OpacHiddenRecordRedirect and OpacHiddenRecordMessage to ensure they work as expected 4 - Hit the link: http://localhost:8080/cgi-bin/koha/opac-detail.pl?biblionumber=303 5 - When OpacHiddenRecordRedirect set to 404 you get a 404 6 - When OpacHiddenRecordRedirect set to 'an explanatory page' you get 'opac-blocked.pl' 7 - If you set a message in OpacHiddenRecordMessage it displays on opac-blocked.pl Signed-off-by: marti <mfuerst@hmcpl.org>
Created attachment 121989 [details] [review] Bug 27734: Add OpacHiddenRecordRedirect and OpacHiddenRecordMessage system preferences This patch adds options analogous to OpacSuppressionRedirect and OpacSuppressionMessage for OpacHiddtenItems Test plan: 1 - Apply patch 2 - Test OpacSupressionsRedirect and OpacSuppressionMessage prefs to ensure they work as before 3 - Enable OpacHiddenItemsHidesRecord and hide a biblio using OpacHiddenItems: biblionumber: [303] 3 - Test OpacHiddenRecordRedirect and OpacHiddenRecordMessage to ensure they work as expected 4 - Hit the link: http://localhost:8080/cgi-bin/koha/opac-detail.pl?biblionumber=303 5 - When OpacHiddenRecordRedirect set to 404 you get a 404 6 - When OpacHiddenRecordRedirect set to 'an explanatory page' you get 'opac-blocked.pl' 7 - If you set a message in OpacHiddenRecordMessage it displays on opac-blocked.pl Signed-off-by: marti <mfuerst@hmcpl.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 121990 [details] [review] Bug 27734: Add OpacHiddenRecordRedirect and OpacHiddenRecordMessage system preferences This patch adds options analogous to OpacSuppressionRedirect and OpacSuppressionMessage for OpacHiddtenItems Test plan: 1 - Apply patch 2 - Test OpacSupressionsRedirect and OpacSuppressionMessage prefs to ensure they work as before 3 - Enable OpacHiddenItemsHidesRecord and hide a biblio using OpacHiddenItems: biblionumber: [303] 3 - Test OpacHiddenRecordRedirect and OpacHiddenRecordMessage to ensure they work as expected 4 - Hit the link: http://localhost:8080/cgi-bin/koha/opac-detail.pl?biblionumber=303 5 - When OpacHiddenRecordRedirect set to 404 you get a 404 6 - When OpacHiddenRecordRedirect set to 'an explanatory page' you get 'opac-blocked.pl' 7 - If you set a message in OpacHiddenRecordMessage it displays on opac-blocked.pl Signed-off-by: marti <mfuerst@hmcpl.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Should not we stop using syspref for the messages we display on the interface? Should we use "news" instead? See bug 26050.
(In reply to Jonathan Druart from comment #6) > Should not we stop using syspref for the messages we display on the > interface? Should we use "news" instead? > > See bug 26050. Actually, I think you are right. It would also be fair, since we had a similar thing just rewritten and this is a quite new patch set.
*** This bug has been marked as a duplicate of bug 22286 ***
Sorry, I got the duplicity backwards!
*** Bug 22286 has been marked as a duplicate of this bug. ***
This seems to be strongly related to bug 9966. The staff should be able to let access to bibliographic info even if all items are hidden (similar as with biblios without items). Else, show an appropriate message instead of 404.
Created attachment 173166 [details] [review] Bug 27734: Add OpacHiddenRecordRedirect and OpacHiddenRecordMessage system preferences This patch adds options analogous to OpacSuppressionRedirect and OpacSuppressionMessage for OpacHiddtenItems Test plan: 1 - Apply patch 2 - Test OpacSupressionsRedirect and OpacSuppressionMessage prefs to ensure they work as before 3 - Enable OpacHiddenItemsHidesRecord and hide a biblio using OpacHiddenItems: biblionumber: [303] 3 - Test OpacHiddenRecordRedirect and OpacHiddenRecordMessage to ensure they work as expected 4 - Hit the link: http://localhost:8080/cgi-bin/koha/opac-detail.pl?biblionumber=303 5 - When OpacHiddenRecordRedirect set to 404 you get a 404 6 - When OpacHiddenRecordRedirect set to 'an explanatory page' you get 'opac-blocked.pl' 7 - If you set a message in OpacHiddenRecordMessage it displays on opac-blocked.pl Signed-off-by: marti <mfuerst@hmcpl.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 173167 [details] [review] Bug 27734: Add OpacHiddenRecordRedirect and OpacHiddenRecordMessage system preferences This patch replaces OpacHiddenRecordMessage preference with a HTML customization of the same name. Test plan: 1 - Apply patch 2 - Test OpacSupressionsRedirect and OpacSuppressionMessage prefs to ensure they work as before 3 - Set preference OpacHiddenRecordRedirect on and create HTML customization OpacHiddenRecordMessage 4 - Enable OpacHiddenItemsHidesRecord and hide a biblio using OpacHiddenItems: biblionumber: [303] 5 - Test OpacHiddenRecordRedirect and OpacHiddenRecordMessage to ensure they work as expected 6 - Hit the link: http://localhost:8080/cgi-bin/koha/opac-detail.pl?biblionumber=303 7 - When OpacHiddenRecordRedirect set to 404 you get a 404 8 - When OpacHiddenRecordRedirect set to 'an explanatory page' you get 'opac-blocked.pl' 9 - If you set a message in OpacHiddenRecordMessage it displays on opac-blocked.pl
I've rebased the original patch and added a new patch that replaces OpacHiddenRecordMessage system preference with an HTML customization entry of the same name.
Created attachment 173168 [details] [review] Bug 27734: Replace OpacHiddenRecordMessage system preference with HTML customization This patch replaces OpacHiddenRecordMessage preference with an HTML customization of the same name. Test plan: 1 - Apply patch 2 - Test OpacSupressionsRedirect and OpacSuppressionMessage prefs to ensure they work as before 3 - Set preference OpacHiddenRecordRedirect on and create HTML customization OpacHiddenRecordMessage 4 - Enable OpacHiddenItemsHidesRecord and hide a biblio using OpacHiddenItems: biblionumber: [303] 5 - Test OpacHiddenRecordRedirect and OpacHiddenRecordMessage to ensure they work as expected 6 - Hit the link: http://localhost:8080/cgi-bin/koha/opac-detail.pl?biblionumber=303 7 - When OpacHiddenRecordRedirect set to 404 you get a 404 8 - When OpacHiddenRecordRedirect set to 'an explanatory page' you get 'opac-blocked.pl' 9 - If you set a message in OpacHiddenRecordMessage it displays on opac-blocked.pl
Created attachment 175807 [details] [review] Bug 27734: Add OpacHiddenRecordRedirect and OpacHiddenRecordMessage system preferences This patch adds options analogous to OpacSuppressionRedirect and OpacSuppressionMessage for OpacHiddtenItems Test plan: 1 - Apply patch 2 - Test OpacSupressionsRedirect and OpacSuppressionMessage prefs to ensure they work as before 3 - Enable OpacHiddenItemsHidesRecord and hide a biblio using OpacHiddenItems: biblionumber: [303] 3 - Test OpacHiddenRecordRedirect and OpacHiddenRecordMessage to ensure they work as expected 4 - Hit the link: http://localhost:8080/cgi-bin/koha/opac-detail.pl?biblionumber=303 5 - When OpacHiddenRecordRedirect set to 404 you get a 404 6 - When OpacHiddenRecordRedirect set to 'an explanatory page' you get 'opac-blocked.pl' 7 - If you set a message in OpacHiddenRecordMessage it displays on opac-blocked.pl Signed-off-by: marti <mfuerst@hmcpl.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>
Created attachment 175808 [details] [review] Bug 27734: Replace OpacHiddenRecordMessage system preference with HTML customization This patch replaces OpacHiddenRecordMessage preference with an HTML customization of the same name. Test plan: 1 - Apply patch 2 - Test OpacSupressionsRedirect and OpacSuppressionMessage prefs to ensure they work as before 3 - Set preference OpacHiddenRecordRedirect on and create HTML customization OpacHiddenRecordMessage 4 - Enable OpacHiddenItemsHidesRecord and hide a biblio using OpacHiddenItems: biblionumber: [303] 5 - Test OpacHiddenRecordRedirect and OpacHiddenRecordMessage to ensure they work as expected 6 - Hit the link: http://localhost:8080/cgi-bin/koha/opac-detail.pl?biblionumber=303 7 - When OpacHiddenRecordRedirect set to 404 you get a 404 8 - When OpacHiddenRecordRedirect set to 'an explanatory page' you get 'opac-blocked.pl' 9 - If you set a message in OpacHiddenRecordMessage it displays on opac-blocked.pl Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>
Tomas, you are still QA contact here, could you take another look?
Feels like opac-MARCdetail and opac-ISBDdetail will need adjustement. We should follow what has been done on bug 38936.
This needs to be redone.
Created attachment 188253 [details] [review] Bug 27734: Add tests
Created attachment 188254 [details] [review] Bug 27734: Add C4::Output::redirect_if_opac_hidden() To test: 1. prove t/db_dependent/Output.t
Created attachment 188255 [details] [review] Bug 27734: Use redirect_if_opac_hidden() in opac-*detail.pages
Created attachment 188256 [details] [review] Bug 27734: Add OpacHiddenRecordRedirect system preference This patch adds option analogous to OpacSuppressionRedirect for OpacHiddtenItems Test plan: 1. Apply patch 2. Create a bibiliographic record and add an item to it. Note down its biblionumber. It will be later reffered to as <biblionumber>. 3. Set system preference OpacHiddenRecordRedirect on 4. Create HTML customization OpacHiddenRecordMessage. Add some placeholder content in it. 5. Enable OpacHiddenItemsHidesRecord and hide a biblio using OpacHiddenItems: biblionumber: [<biblionumber>] e.g. biblionumber: [123] 6. Test OpacHiddenRecordRedirect and OpacHiddenRecordMessage to ensure they work as expected 7. Hit these links: http://koha/cgi-bin/koha/opac-detail.pl?biblionumber=<biblionumber> http://koha/cgi-bin/koha/opac-MARCdetail.pl?biblionumber=<biblionumber> http://koha/cgi-bin/koha/opac-ISBDdetail.pl?biblionumber=<biblionumber> 8. When OpacHiddenRecordRedirect set to 404 you get a 404 9. When OpacHiddenRecordRedirect set to 'an explanatory page' you get 'opac-blocked.pl' 10. If you set a message in OpacHiddenRecordMessage it displays on opac-blocked.pl 11. Using preference OpacHiddenItemsExceptions, exclude your patron category 12. Observe the record is no longer blocked when your patron category is excluded
Created attachment 190812 [details] [review] Bug 27734: Add tests Signed-off-by: David Nind <david@davidnind.com>
Created attachment 190813 [details] [review] Bug 27734: Add C4::Output::redirect_if_opac_hidden() To test: 1. prove t/db_dependent/Output.t Signed-off-by: David Nind <david@davidnind.com>
Created attachment 190814 [details] [review] Bug 27734: Use redirect_if_opac_hidden() in opac-*detail.pages Signed-off-by: David Nind <david@davidnind.com>
Created attachment 190815 [details] [review] Bug 27734: Add OpacHiddenRecordRedirect system preference This patch adds option analogous to OpacSuppressionRedirect for OpacHiddtenItems Test plan: 1. Apply patch 2. Create a bibiliographic record and add an item to it. Note down its biblionumber. It will be later reffered to as <biblionumber>. 3. Set system preference OpacHiddenRecordRedirect on 4. Create HTML customization OpacHiddenRecordMessage. Add some placeholder content in it. 5. Enable OpacHiddenItemsHidesRecord and hide a biblio using OpacHiddenItems: biblionumber: [<biblionumber>] e.g. biblionumber: [123] 6. Test OpacHiddenRecordRedirect and OpacHiddenRecordMessage to ensure they work as expected 7. Hit these links: http://koha/cgi-bin/koha/opac-detail.pl?biblionumber=<biblionumber> http://koha/cgi-bin/koha/opac-MARCdetail.pl?biblionumber=<biblionumber> http://koha/cgi-bin/koha/opac-ISBDdetail.pl?biblionumber=<biblionumber> 8. When OpacHiddenRecordRedirect set to 404 you get a 404 9. When OpacHiddenRecordRedirect set to 'an explanatory page' you get 'opac-blocked.pl' 10. If you set a message in OpacHiddenRecordMessage it displays on opac-blocked.pl 11. Using preference OpacHiddenItemsExceptions, exclude your patron category 12. Observe the record is no longer blocked when your patron category is excluded Signed-off-by: David Nind <david@davidnind.com>
I've signed off, but have some feedback: 1. System preference description: - "..opac.." should be OPAC - for the option "an explanatory page ('This record is blocked').", the title of the page generated is "Record blocked", so the option for the system preference should match. - for "..redirect page for suppressed bibliographic records...", I think that should be "..hidden..", as this is what we use in the sentence above and in the system preference name 2. With the "explanatory page" option, I found it odd that the title and message are hard-coded. That is, we are adding a way to add a custom page for the 404, but then are hard-coding a What is displayed if the "explanatory page" option is selected: Record blocked You are not authorized to view this record. [Then anything in OpacHiddenRecordMessage] Testing notes (using KTD): 1. To reproduce the issue: 1.1 Place a hold on a record for a patron (I used Programming Perl, 262) 1.2 Log in to the OPAC as that patron and go to Your account > Your summary > Holds 1.3 Click on the link to the item on hold. Success! You can see the record. 1.4 For OpacHiddenItems, add: biblionumber: [262] 1.5 Repeat step 1.3 1.6 You get the "An error has occurred page": Sorry, the requested page is not available Error 404 2. Apply the patch 3. Update the database: updatedatabase 4. Restart everything: restart_all 5. For step 2 of the test plab: I used an existing record, CGI programming with Perl (11), which has one item 6. For step 3: OpacHiddenRecordRedirect is on by default (set to 'Hide') 7. For step 5: OpacHiddenItems - biblionumber: [11]