| Summary: | Item template toolbar is not like other toolbars | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Lucas Gass (lukeg) <lucas> |
| Component: | Staff interface | Assignee: | Lucas Gass (lukeg) <lucas> |
| Status: | Needs documenting --- | QA Contact: | Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | baptiste.wojtkowski, barbara.johnson, dbarden, fridolin.somers, gmcharlt, kkrueger, Laura.escamilla |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | String patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: |
This enhancement improves the item-template-toolbar in Koha, adding some classes to be consistent with other toolbars in Koha.
|
Version(s) released in: |
25.11.00,25.05.07
|
| Circulation function: | |||
| Attachments: |
Bug 38942: Fix display issues with item-template-toolbar
Bug 38942: Fix display issues with item-template-toolbar Bug 38942: Fix display issues with item-template-toolbar Bug 38942: Fix display issues with item-template-toolbar Screenshot showing toolbar appearance Alignment in the toolbar Bug 38942: Fix display issues with item-template-toolbar Bug 38942: Fix display issues with item-template-toolbar |
||
|
Description
Lucas Gass (lukeg)
2025-01-21 21:26:32 UTC
Created attachment 176885 [details] [review] Bug 38942: Fix display issues with item-template-toolbar This patch does the following: -Adds a 'btn' and 'btn-default' class to the buttons in the item-template-toolbar -Removes the btn-group parent containers -Changes the wording of the remember session checkbox to 'Remember for session', just like it is on the check out screen for due dates. -Adds a visual divider after the 'Remember for session' checkbox -Add CSS to addbiblio.css to make the checkbox/label appear a little nicer To test: -Add an item and 'Save as template' -Notice the toolbar buttons look different from other toolbars in Koha. -Apply patch -Look again, the buttons should look better, hopefully! Created attachment 176923 [details] [review] Bug 38942: Fix display issues with item-template-toolbar This patch does the following: -Adds a 'btn' and 'btn-default' class to the buttons in the item-template-toolbar -Removes the btn-group parent containers -Changes the wording of the remember session checkbox to 'Remember for session', just like it is on the check out screen for due dates. -Adds a visual divider after the 'Remember for session' checkbox -Add CSS to addbiblio.css to make the checkbox/label appear a little nicer To test: -Add an item and 'Save as template' -Notice the toolbar buttons look different from other toolbars in Koha. -Apply patch -Look again, the buttons should look better, hopefully! Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> Created attachment 177748 [details] [review] Bug 38942: Fix display issues with item-template-toolbar This patch does the following: -Adds a 'btn' and 'btn-default' class to the buttons in the item-template-toolbar -Removes the btn-group parent containers -Changes the wording of the remember session checkbox to 'Remember for session', just like it is on the check out screen for due dates. -Adds a visual divider after the 'Remember for session' checkbox -Add CSS to addbiblio.css to make the checkbox/label appear a little nicer To test: -Add an item and 'Save as template' -Notice the toolbar buttons look different from other toolbars in Koha. -Apply patch -Look again, the buttons should look better, hopefully! Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> Created attachment 177754 [details] [review] Bug 38942: Fix display issues with item-template-toolbar This patch does the following: -Adds a 'btn' and 'btn-default' class to the buttons in the item-template-toolbar -Removes the btn-group parent containers -Changes the wording of the remember session checkbox to 'Remember for session', just like it is on the check out screen for due dates. -Adds a visual divider after the 'Remember for session' checkbox -Add CSS to addbiblio.css to make the checkbox/label appear a little nicer To test: -Add an item and 'Save as template' -Notice the toolbar buttons look different from other toolbars in Koha. -Apply patch -Look again, the buttons should look better, hopefully! Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> The button "Remember for session" should be aligned with other button (In reply to Baptiste Wojtkowski (bwoj) from comment #5) > The button "Remember for session" should be aligned with other button It's not a button, it's a checkbox with a label. Just let me know what you want here and I'll do it. It does seem aligned to me. Created attachment 182267 [details]
Screenshot showing toolbar appearance
The alignment looks good to me
Created attachment 182579 [details]
Alignment in the toolbar
I feel like the checkbox is not aligned, a little bit too high (see attachment). If it looks well aligned to you all, I cann PQA this.
Created attachment 187012 [details] [review] Bug 38942: Fix display issues with item-template-toolbar This patch does the following: -Adds a 'btn' and 'btn-default' class to the buttons in the item-template-toolbar -Removes the btn-group parent containers -Changes the wording of the remember session checkbox to 'Remember for session', just like it is on the check out screen for due dates. -Adds a visual divider after the 'Remember for session' checkbox -Add CSS to addbiblio.css to make the checkbox/label appear a little nicer To test: -Add an item and 'Save as template' -Notice the toolbar buttons look different from other toolbars in Koha. -Apply patch -Look again, the buttons should look better, hopefully! Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> rebased for current main Created attachment 187035 [details] [review] Bug 38942: Fix display issues with item-template-toolbar This patch does the following: -Adds a 'btn' and 'btn-default' class to the buttons in the item-template-toolbar -Removes the btn-group parent containers -Changes the wording of the remember session checkbox to 'Remember for session', just like it is on the check out screen for due dates. -Adds a visual divider after the 'Remember for session' checkbox -Add CSS to addbiblio.css to make the checkbox/label appear a little nicer To test: -Add an item and 'Save as template' -Notice the toolbar buttons look different from other toolbars in Koha. -Apply patch -Look again, the buttons should look better, hopefully! Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> Signed-off-by: Baptiste Wojtkowski <baptiste.wojtkowski@biblibre.com> Nice work everyone! Pushed to main for 25.11 This change has been backported to the 25.05.x branch for it's accessibility features. Thank you! Enhancement not pushed to 24.11.x |