Bug 38942 - Item template toolbar is not like other toolbars
Summary: Item template toolbar is not like other toolbars
Status: Signed Off
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Lucas Gass (lukeg)
QA Contact: Baptiste Wojtkowski (bwoj)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-01-21 21:26 UTC by Lucas Gass (lukeg)
Modified: 2025-05-19 09:07 UTC (History)
3 users (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: String patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
This enhancement improves the item-template-toolbar in Koha, adding some classes to be consistent with other toolbars in Koha.
Version(s) released in:
Circulation function:


Attachments
Bug 38942: Fix display issues with item-template-toolbar (7.65 KB, patch)
2025-01-21 21:31 UTC, Lucas Gass (lukeg)
Details | Diff | Splinter Review
Bug 38942: Fix display issues with item-template-toolbar (7.71 KB, patch)
2025-01-22 17:08 UTC, PTFS Europe Sandboxes
Details | Diff | Splinter Review
Bug 38942: Fix display issues with item-template-toolbar (52.15 KB, patch)
2025-02-11 18:20 UTC, Lucas Gass (lukeg)
Details | Diff | Splinter Review
Bug 38942: Fix display issues with item-template-toolbar (9.51 KB, patch)
2025-02-11 20:00 UTC, Jonathan Druart
Details | Diff | Splinter Review
Screenshot showing toolbar appearance (21.07 KB, image/png)
2025-05-12 12:21 UTC, Owen Leonard
Details
Alignment in the toolbar (7.85 KB, image/png)
2025-05-19 09:07 UTC, Baptiste Wojtkowski (bwoj)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Lucas Gass (lukeg) 2025-01-21 21:26:32 UTC
If you look at the item-template-toolbar in Koha, it looks quite different from other toolbars in Koha. 

TO recreate:
-Add an item and 'Save as template'
-Notice the toolbar buttons look different from other toolbars in Koha.
Comment 1 Lucas Gass (lukeg) 2025-01-21 21:31:54 UTC Comment hidden (obsolete)
Comment 2 PTFS Europe Sandboxes 2025-01-22 17:08:48 UTC Comment hidden (obsolete)
Comment 3 Lucas Gass (lukeg) 2025-02-11 18:20:33 UTC Comment hidden (obsolete)
Comment 4 Jonathan Druart 2025-02-11 20:00:21 UTC
Created attachment 177754 [details] [review]
Bug 38942: Fix display issues with item-template-toolbar

This patch does the following:
-Adds a 'btn' and 'btn-default' class to the buttons in the item-template-toolbar
-Removes the btn-group parent containers
-Changes the wording of the remember session checkbox to 'Remember for session', just like it is on the check out screen for due dates.
-Adds a visual divider after the 'Remember for session' checkbox
-Add CSS to addbiblio.css to make the checkbox/label appear a little nicer

To test:
-Add an item and 'Save as template'
-Notice the toolbar buttons look different from other toolbars in Koha.
-Apply patch
-Look again, the buttons should look better, hopefully!

Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov>
Comment 5 Baptiste Wojtkowski (bwoj) 2025-02-27 14:46:17 UTC
The button "Remember for session" should be aligned with other button
Comment 6 Lucas Gass (lukeg) 2025-05-08 17:41:33 UTC
(In reply to Baptiste Wojtkowski (bwoj) from comment #5)
> The button "Remember for session" should be aligned with other button

It's not a button, it's a checkbox with a label. Just let me know what you want here and I'll do it.

It does seem aligned to me.
Comment 7 Owen Leonard 2025-05-12 12:21:19 UTC
Created attachment 182267 [details]
Screenshot showing toolbar appearance

The alignment looks good to me
Comment 8 Baptiste Wojtkowski (bwoj) 2025-05-19 09:07:54 UTC
Created attachment 182579 [details]
Alignment in the toolbar

I feel like the checkbox is not aligned, a little bit too high (see attachment). If it looks well aligned to you all, I cann PQA this.