Summary: | Advanced catalog editor's macro modal isn't wide enough | ||
---|---|---|---|
Product: | Koha | Reporter: | Lucas Gass (lukeg) <lucas> |
Component: | Cataloging | Assignee: | Lucas Gass (lukeg) <lucas> |
Status: | Signed Off --- | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | barbara.johnson, m.de.rooy, phil |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | 35402 | ||
Bug Blocks: | |||
Attachments: |
Bug 38943: Increase macro modal width in advanced editor
Bug 38943: Increase macro modal width in advanced editor |
Description
Lucas Gass (lukeg)
2025-01-21 22:11:33 UTC
Created attachment 176886 [details] [review] Bug 38943: Increase macro modal width in advanced editor To test: 1. Turn on EnableAdvancedCatalogingEditor 2. From the advanced editor, pull up the modal for macros. 3. Notice the size. 4. APPLY PATCH 5. Try step 2 again, this time the modal is wider. 6. Try on different screen sizes. Created attachment 176922 [details] [review] Bug 38943: Increase macro modal width in advanced editor To test: 1. Turn on EnableAdvancedCatalogingEditor 2. From the advanced editor, pull up the modal for macros. 3. Notice the size. 4. APPLY PATCH 5. Try step 2 again, this time the modal is wider. 6. Try on different screen sizes. Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> modal-fullscreen is probably too much, but giving #macro-ui the same treatment that #advanced-search-ui and #search-results-ui got, the class modal-full which gives them width: 95%, would not. Really, those two don't need to be so wide because they handle resizing nicely, but the macro UI does need to be because when you are editing a macro you don't get line wrap, you just get a very awkward scrollbar. modal-xl puts that off until you have a macro with a line around 100 chars long instead of around 65 chars, but it's still a fixed width you can't do anything about, unlike modal-full letting you just increase the width of the window when 95% isn't enough. |