Bug 38943 - Advanced catalog editor's macro modal isn't wide enough
Summary: Advanced catalog editor's macro modal isn't wide enough
Status: Signed Off
Alias: None
Product: Koha
Classification: Unclassified
Component: Cataloging (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Lucas Gass (lukeg)
QA Contact: Testopia
URL:
Keywords:
Depends on: 35402
Blocks:
  Show dependency treegraph
 
Reported: 2025-01-21 22:11 UTC by Lucas Gass (lukeg)
Modified: 2025-01-31 19:37 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 38943: Increase macro modal width in advanced editor (1.25 KB, patch)
2025-01-21 22:14 UTC, Lucas Gass (lukeg)
Details | Diff | Splinter Review
Bug 38943: Increase macro modal width in advanced editor (1.31 KB, patch)
2025-01-22 17:03 UTC, PTFS Europe Sandboxes
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Lucas Gass (lukeg) 2025-01-21 22:11:33 UTC
The advanced catalog editor's marco isn't wide enough, especially on larger screens. 

We are using 'modal-lg' but should probably use 'modal-xl'. I have also considered 'modal-fullscreen' but perhaps that is too much.
Comment 1 Lucas Gass (lukeg) 2025-01-21 22:14:02 UTC
Created attachment 176886 [details] [review]
Bug 38943: Increase macro modal width in advanced editor

To test:
1. Turn on EnableAdvancedCatalogingEditor
2. From the advanced editor, pull up the modal for macros.
3. Notice the size.
4. APPLY PATCH
5. Try step 2 again, this time the modal is wider.
6. Try on different screen sizes.
Comment 2 PTFS Europe Sandboxes 2025-01-22 17:03:37 UTC
Created attachment 176922 [details] [review]
Bug 38943: Increase macro modal width in advanced editor

To test:
1. Turn on EnableAdvancedCatalogingEditor
2. From the advanced editor, pull up the modal for macros.
3. Notice the size.
4. APPLY PATCH
5. Try step 2 again, this time the modal is wider.
6. Try on different screen sizes.

Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov>
Comment 3 Phil Ringnalda 2025-01-31 19:37:02 UTC
modal-fullscreen is probably too much, but giving #macro-ui the same treatment that #advanced-search-ui and #search-results-ui got, the class modal-full which gives them width: 95%, would not.

Really, those two don't need to be so wide because they handle resizing nicely, but the macro UI does need to be because when you are editing a macro you don't get line wrap, you just get a very awkward scrollbar. modal-xl puts that off until you have a macro with a line around 100 chars long instead of around 65 chars, but it's still a fixed width you can't do anything about, unlike modal-full letting you just increase the width of the window when 95% isn't enough.