| Summary: | JS function messenger not used in acq.js | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
| Component: | Architecture, internals, and plumbing | Assignee: | Jonathan Druart <jonathan.druart> |
| Status: | RESOLVED FIXED | QA Contact: | Brendan Lawlor <blawlor> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | blawlor, david, fridolin.somers |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
25.05.00
|
|
| Circulation function: | |||
| Attachments: |
Bug 38952: Remove JS function messenger from acq.js
Bug 38952: Remove JS function messenger from acq.js Bug 38952: Remove JS function messenger from acq.js Bug 38952: Remove JS function messenger from acq.js |
||
Created attachment 176942 [details] [review] Bug 38952: Remove JS function messenger from acq.js Test plan: % git grep -l messenger koha-tmpl/intranet-tmpl/lib/fontawesome/css/brands.min.css koha-tmpl/intranet-tmpl/lib/fontawesome/webfonts/fa-brands-400.ttf koha-tmpl/opac-tmpl/lib/fontawesome/css/brands.min.css koha-tmpl/opac-tmpl/lib/fontawesome/webfonts/fa-brands-400.ttf The function is unused and can be removed. Created attachment 177067 [details] [review] Bug 38952: Remove JS function messenger from acq.js Test plan: % git grep -l messenger koha-tmpl/intranet-tmpl/lib/fontawesome/css/brands.min.css koha-tmpl/intranet-tmpl/lib/fontawesome/webfonts/fa-brands-400.ttf koha-tmpl/opac-tmpl/lib/fontawesome/css/brands.min.css koha-tmpl/opac-tmpl/lib/fontawesome/webfonts/fa-brands-400.ttf The function is unused and can be removed. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 177368 [details] [review] Bug 38952: Remove JS function messenger from acq.js Test plan: % git grep -l messenger koha-tmpl/intranet-tmpl/lib/fontawesome/css/brands.min.css koha-tmpl/intranet-tmpl/lib/fontawesome/webfonts/fa-brands-400.ttf koha-tmpl/opac-tmpl/lib/fontawesome/css/brands.min.css koha-tmpl/opac-tmpl/lib/fontawesome/webfonts/fa-brands-400.ttf The function is unused and can be removed. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> QA notes:
git log -G'messenger\('
This takes a long time but it finds the commit where calls to this function were removed.
git log -p ca16532ea8270b14178ab47cb26f48c53f64a20a -G'messenger\('
This shows the diff of that commit
Fix for Bug 5028 - Remove references to catmaintain.pl
git grep -l 'messenger('
After patch returns no results
Passing QA.
Created attachment 177924 [details] [review] Bug 38952: Remove JS function messenger from acq.js Test plan: % git grep -l messenger koha-tmpl/intranet-tmpl/lib/fontawesome/css/brands.min.css koha-tmpl/intranet-tmpl/lib/fontawesome/webfonts/fa-brands-400.ttf koha-tmpl/opac-tmpl/lib/fontawesome/css/brands.min.css koha-tmpl/opac-tmpl/lib/fontawesome/webfonts/fa-brands-400.ttf The function is unused and can be removed. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Pushed for 25.05! Well done everyone, thank you! Enhancement not pushed to 24.11.x No changes to the manual required. |
koha-tmpl/intranet-tmpl/prog/js/acq.js 166 function messenger(X,Y,etc){ // FIXME: unused? 167 win=window.open("","mess","height="+X+",width="+Y+",screenX=150,screenY=0"); 168 win.focus(); 169 win.document.close(); 170 win.document.write("<body link='#333333' bgcolor='#ffffff' text='#000000'><font size='2'><p><br />"); 171 win.document.write(etc); 172 win.document.write("<center><form><input type=button onclick='self.close()' value='Close'></form></center>"); 173 win.document.write("</font></body></html>"); 174 } % git grep -l messenger koha-tmpl/intranet-tmpl/lib/fontawesome/css/brands.min.css koha-tmpl/intranet-tmpl/lib/fontawesome/webfonts/fa-brands-400.ttf koha-tmpl/intranet-tmpl/prog/js/acq.js koha-tmpl/opac-tmpl/lib/fontawesome/css/brands.min.css koha-tmpl/opac-tmpl/lib/fontawesome/webfonts/fa-brands-400.ttf