Summary: | JS function messenger not used in acq.js | ||
---|---|---|---|
Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
Component: | Architecture, internals, and plumbing | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | Passed QA --- | QA Contact: | Brendan Lawlor <blawlor> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | blawlor |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 38952: Remove JS function messenger from acq.js
Bug 38952: Remove JS function messenger from acq.js Bug 38952: Remove JS function messenger from acq.js |
Description
Jonathan Druart
2025-01-23 08:29:12 UTC
Created attachment 176942 [details] [review] Bug 38952: Remove JS function messenger from acq.js Test plan: % git grep -l messenger koha-tmpl/intranet-tmpl/lib/fontawesome/css/brands.min.css koha-tmpl/intranet-tmpl/lib/fontawesome/webfonts/fa-brands-400.ttf koha-tmpl/opac-tmpl/lib/fontawesome/css/brands.min.css koha-tmpl/opac-tmpl/lib/fontawesome/webfonts/fa-brands-400.ttf The function is unused and can be removed. Created attachment 177067 [details] [review] Bug 38952: Remove JS function messenger from acq.js Test plan: % git grep -l messenger koha-tmpl/intranet-tmpl/lib/fontawesome/css/brands.min.css koha-tmpl/intranet-tmpl/lib/fontawesome/webfonts/fa-brands-400.ttf koha-tmpl/opac-tmpl/lib/fontawesome/css/brands.min.css koha-tmpl/opac-tmpl/lib/fontawesome/webfonts/fa-brands-400.ttf The function is unused and can be removed. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 177368 [details] [review] Bug 38952: Remove JS function messenger from acq.js Test plan: % git grep -l messenger koha-tmpl/intranet-tmpl/lib/fontawesome/css/brands.min.css koha-tmpl/intranet-tmpl/lib/fontawesome/webfonts/fa-brands-400.ttf koha-tmpl/opac-tmpl/lib/fontawesome/css/brands.min.css koha-tmpl/opac-tmpl/lib/fontawesome/webfonts/fa-brands-400.ttf The function is unused and can be removed. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> QA notes: git log -G'messenger\(' This takes a long time but it finds the commit where calls to this function were removed. git log -p ca16532ea8270b14178ab47cb26f48c53f64a20a -G'messenger\(' This shows the diff of that commit Fix for Bug 5028 - Remove references to catmaintain.pl git grep -l 'messenger(' After patch returns no results Passing QA. |