Bug 38952 - JS function messenger not used in acq.js
Summary: JS function messenger not used in acq.js
Status: Passed QA
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low enhancement
Assignee: Jonathan Druart
QA Contact: Brendan Lawlor
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-01-23 08:29 UTC by Jonathan Druart
Modified: 2025-01-30 21:52 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 38952: Remove JS function messenger from acq.js (1.56 KB, patch)
2025-01-23 08:38 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 38952: Remove JS function messenger from acq.js (2.24 KB, patch)
2025-01-23 18:59 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 38952: Remove JS function messenger from acq.js (2.29 KB, patch)
2025-01-30 21:40 UTC, Brendan Lawlor
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2025-01-23 08:29:12 UTC
koha-tmpl/intranet-tmpl/prog/js/acq.js

166 function messenger(X,Y,etc){    // FIXME: unused?
167     win=window.open("","mess","height="+X+",width="+Y+",screenX=150,screenY=0");
168     win.focus();
169     win.document.close();
170     win.document.write("<body link='#333333' bgcolor='#ffffff' text='#000000'><font size='2'><p><br />");
171     win.document.write(etc);
172     win.document.write("<center><form><input type=button onclick='self.close()' value='Close'></form></center>");
173     win.document.write("</font></body></html>");
174 }

% git grep -l messenger
koha-tmpl/intranet-tmpl/lib/fontawesome/css/brands.min.css
koha-tmpl/intranet-tmpl/lib/fontawesome/webfonts/fa-brands-400.ttf
koha-tmpl/intranet-tmpl/prog/js/acq.js
koha-tmpl/opac-tmpl/lib/fontawesome/css/brands.min.css
koha-tmpl/opac-tmpl/lib/fontawesome/webfonts/fa-brands-400.ttf
Comment 1 Jonathan Druart 2025-01-23 08:38:05 UTC
Created attachment 176942 [details] [review]
Bug 38952: Remove JS function messenger from acq.js

Test plan:
% git grep -l messenger
koha-tmpl/intranet-tmpl/lib/fontawesome/css/brands.min.css
koha-tmpl/intranet-tmpl/lib/fontawesome/webfonts/fa-brands-400.ttf
koha-tmpl/opac-tmpl/lib/fontawesome/css/brands.min.css
koha-tmpl/opac-tmpl/lib/fontawesome/webfonts/fa-brands-400.ttf

The function is unused and can be removed.
Comment 2 Owen Leonard 2025-01-23 18:59:52 UTC
Created attachment 177067 [details] [review]
Bug 38952: Remove JS function messenger from acq.js

Test plan:
% git grep -l messenger
koha-tmpl/intranet-tmpl/lib/fontawesome/css/brands.min.css
koha-tmpl/intranet-tmpl/lib/fontawesome/webfonts/fa-brands-400.ttf
koha-tmpl/opac-tmpl/lib/fontawesome/css/brands.min.css
koha-tmpl/opac-tmpl/lib/fontawesome/webfonts/fa-brands-400.ttf

The function is unused and can be removed.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 3 Brendan Lawlor 2025-01-30 21:40:24 UTC
Created attachment 177368 [details] [review]
Bug 38952: Remove JS function messenger from acq.js

Test plan:
% git grep -l messenger
koha-tmpl/intranet-tmpl/lib/fontawesome/css/brands.min.css
koha-tmpl/intranet-tmpl/lib/fontawesome/webfonts/fa-brands-400.ttf
koha-tmpl/opac-tmpl/lib/fontawesome/css/brands.min.css
koha-tmpl/opac-tmpl/lib/fontawesome/webfonts/fa-brands-400.ttf

The function is unused and can be removed.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org>
Comment 4 Brendan Lawlor 2025-01-30 21:52:39 UTC
QA notes:

git log -G'messenger\('
This takes a long time but it finds the commit where calls to this function were removed.

git log -p ca16532ea8270b14178ab47cb26f48c53f64a20a -G'messenger\('
This shows the diff of that commit

Fix for Bug 5028 - Remove references to catmaintain.pl

git grep -l 'messenger('
After patch returns no results

Passing QA.