Summary: | Identity providers "More" controls broken after Bootstrap 5 upgrade | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | Pushed to main --- | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | david |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: |
This fixes the identity providers add and modify form so that the "More" buttons now correctly expand and show hidden help text. (This is related to the OPAC and staff interface Bootstrap 5 upgrade in Koha 24.11.)
|
|
Version(s) released in: |
25.05.00
|
Circulation function: | |
Bug Depends on: | 35402 | ||
Bug Blocks: | |||
Attachments: |
Bug 38968: Identity providers "More" controls broken after Bootstrap 5 upgrade
Bug 38968: Identity providers "More" controls broken after Bootstrap 5 upgrade Bug 38968: Identity providers "More" controls broken after Bootstrap 5 upgrade |
Description
Owen Leonard
2025-01-25 15:33:18 UTC
Created attachment 177142 [details] [review] Bug 38968: Identity providers "More" controls broken after Bootstrap 5 upgrade This patch corrects the data attribute on "More" buttons which were incorrectly updated during the Bootstrap 5 upgrade. "data-bs-target" is corrected to "data-target." Also fixed are instances of a misspelled class, "ligth" -> "light" To test, apply the patch and go to Administration -> Identity providers. - Click "New identity provider." - In the "Advanced configuration" section, test the "More" buttons underneath the textareas. Clicking them should expand the hidden help text and hide the button. - Perform the same test when updating an identity provider. Sponsored-by: Athens County Public Libraries Created attachment 177143 [details] [review] Bug 38968: Identity providers "More" controls broken after Bootstrap 5 upgrade This patch corrects the data attribute on "More" buttons which were incorrectly updated during the Bootstrap 5 upgrade. "data-bs-target" is corrected to "data-target." Also fixed are instances of a misspelled class, "ligth" -> "light" To test, apply the patch and go to Administration -> Identity providers. - Click "New identity provider." - In the "Advanced configuration" section, test the "More" buttons underneath the textareas. Clicking them should expand the hidden help text and hide the button. - Perform the same test when updating an identity provider. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> Created attachment 177164 [details] [review] Bug 38968: Identity providers "More" controls broken after Bootstrap 5 upgrade This patch corrects the data attribute on "More" buttons which were incorrectly updated during the Bootstrap 5 upgrade. "data-bs-target" is corrected to "data-target." Also fixed are instances of a misspelled class, "ligth" -> "light" To test, apply the patch and go to Administration -> Identity providers. - Click "New identity provider." - In the "Advanced configuration" section, test the "More" buttons underneath the textareas. Clicking them should expand the hidden help text and hide the button. - Perform the same test when updating an identity provider. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed for 25.05! Well done everyone, thank you! |