When adding or editing an identify provider there are "More" buttons which are supposed to expand hidden help text. During the Bootstrap upgrade these buttons' "data-target" attribute was incorrectly changed with search and replace to "data-bs-target."
Created attachment 177142 [details] [review] Bug 38968: Identity providers "More" controls broken after Bootstrap 5 upgrade This patch corrects the data attribute on "More" buttons which were incorrectly updated during the Bootstrap 5 upgrade. "data-bs-target" is corrected to "data-target." Also fixed are instances of a misspelled class, "ligth" -> "light" To test, apply the patch and go to Administration -> Identity providers. - Click "New identity provider." - In the "Advanced configuration" section, test the "More" buttons underneath the textareas. Clicking them should expand the hidden help text and hide the button. - Perform the same test when updating an identity provider. Sponsored-by: Athens County Public Libraries
Created attachment 177143 [details] [review] Bug 38968: Identity providers "More" controls broken after Bootstrap 5 upgrade This patch corrects the data attribute on "More" buttons which were incorrectly updated during the Bootstrap 5 upgrade. "data-bs-target" is corrected to "data-target." Also fixed are instances of a misspelled class, "ligth" -> "light" To test, apply the patch and go to Administration -> Identity providers. - Click "New identity provider." - In the "Advanced configuration" section, test the "More" buttons underneath the textareas. Clicking them should expand the hidden help text and hide the button. - Perform the same test when updating an identity provider. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com>
Created attachment 177164 [details] [review] Bug 38968: Identity providers "More" controls broken after Bootstrap 5 upgrade This patch corrects the data attribute on "More" buttons which were incorrectly updated during the Bootstrap 5 upgrade. "data-bs-target" is corrected to "data-target." Also fixed are instances of a misspelled class, "ligth" -> "light" To test, apply the patch and go to Administration -> Identity providers. - Click "New identity provider." - In the "Advanced configuration" section, test the "More" buttons underneath the textareas. Clicking them should expand the hidden help text and hide the button. - Perform the same test when updating an identity provider. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Pushed for 25.05! Well done everyone, thank you!