Bug 38968 - Identity providers "More" controls broken after Bootstrap 5 upgrade
Summary: Identity providers "More" controls broken after Bootstrap 5 upgrade
Status: Pushed to main
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on: 35402
Blocks:
  Show dependency treegraph
 
Reported: 2025-01-25 15:33 UTC by Owen Leonard
Modified: 2025-01-30 17:07 UTC (History)
1 user (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
This fixes the identity providers add and modify form so that the "More" buttons now correctly expand and show hidden help text. (This is related to the OPAC and staff interface Bootstrap 5 upgrade in Koha 24.11.)
Version(s) released in:
25.05.00
Circulation function:


Attachments
Bug 38968: Identity providers "More" controls broken after Bootstrap 5 upgrade (7.86 KB, patch)
2025-01-25 15:56 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 38968: Identity providers "More" controls broken after Bootstrap 5 upgrade (7.90 KB, patch)
2025-01-25 17:09 UTC, David Nind
Details | Diff | Splinter Review
Bug 38968: Identity providers "More" controls broken after Bootstrap 5 upgrade (7.98 KB, patch)
2025-01-27 09:45 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2025-01-25 15:33:18 UTC
When adding or editing an identify provider there are "More" buttons which are supposed to expand hidden help text. During the Bootstrap upgrade these buttons' "data-target" attribute was incorrectly changed with search and replace to "data-bs-target."
Comment 1 Owen Leonard 2025-01-25 15:56:57 UTC
Created attachment 177142 [details] [review]
Bug 38968: Identity providers "More" controls broken after Bootstrap 5 upgrade

This patch corrects the data attribute on "More" buttons which were
incorrectly updated during the Bootstrap 5 upgrade. "data-bs-target" is
corrected to "data-target."

Also fixed are instances of a misspelled class, "ligth" -> "light"

To test, apply the patch and go to Administration -> Identity providers.

- Click "New identity provider."
  - In the "Advanced configuration" section, test the "More" buttons
    underneath the textareas. Clicking them should expand the hidden
    help text and hide the button.
- Perform the same test when updating an identity provider.

Sponsored-by: Athens County Public Libraries
Comment 2 David Nind 2025-01-25 17:09:20 UTC
Created attachment 177143 [details] [review]
Bug 38968: Identity providers "More" controls broken after Bootstrap 5 upgrade

This patch corrects the data attribute on "More" buttons which were
incorrectly updated during the Bootstrap 5 upgrade. "data-bs-target" is
corrected to "data-target."

Also fixed are instances of a misspelled class, "ligth" -> "light"

To test, apply the patch and go to Administration -> Identity providers.

- Click "New identity provider."
  - In the "Advanced configuration" section, test the "More" buttons
    underneath the textareas. Clicking them should expand the hidden
    help text and hide the button.
- Perform the same test when updating an identity provider.

Sponsored-by: Athens County Public Libraries
Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Jonathan Druart 2025-01-27 09:45:06 UTC
Created attachment 177164 [details] [review]
Bug 38968: Identity providers "More" controls broken after Bootstrap 5 upgrade

This patch corrects the data attribute on "More" buttons which were
incorrectly updated during the Bootstrap 5 upgrade. "data-bs-target" is
corrected to "data-target."

Also fixed are instances of a misspelled class, "ligth" -> "light"

To test, apply the patch and go to Administration -> Identity providers.

- Click "New identity provider."
  - In the "Advanced configuration" section, test the "More" buttons
    underneath the textareas. Clicking them should expand the hidden
    help text and hide the button.
- Perform the same test when updating an identity provider.

Sponsored-by: Athens County Public Libraries
Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 4 Katrin Fischer 2025-01-30 17:07:21 UTC
Pushed for 25.05!

Well done everyone, thank you!