Bug 38989

Summary: Note hard-coded price checks in MarcFieldsToOrder system preference text
Product: Koha Reporter: Andrew Fuerste-Henry <andrew>
Component: System AdministrationAssignee: Nicolas Hunstein <nicolas.hunstein>
Status: Needs documenting --- QA Contact: Lucas Gass (lukeg) <lucas>
Severity: enhancement    
Priority: P5 - low CC: fridolin.somers, gmcharlt, lucas, nicolas.hunstein
Version: MainKeywords: Academy
Hardware: All   
OS: All   
GIT URL: Change sponsored?: ---
Patch complexity: String patch Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
25.05.00
Circulation function:
Attachments: Bug 38989: Updated system preference text of MarcFieldsToOrder
Bug 38989: Updated system preference text of MarcFieldsToOrder
Bug 38989: Updated system preference text of MarcFieldsToOrder

Description Andrew Fuerste-Henry 2025-01-28 19:20:45 UTC
MarcFieldsToOrder allows the user to indicate a MARC field in which Koha should look for a price when creating orders from staged MARC files. Without defining anything here, Koha will check the 345$c and 020$c for MARC21 records and the 345$c and 010$c for UNIMARC records. It'd be helpful to include that in the system preference text.
Comment 1 Nicolas Hunstein 2025-02-28 12:26:59 UTC
Created attachment 178818 [details] [review]
Bug 38989: Updated system preference text of MarcFieldsToOrder

Updates system preference text MarcFieldsToOrder by adding string "When there is no mapping for price, Koha will use 345$c and 020$c for MARC21 records and 345$c and 010$c for UNIMARC records"

to test:
- go to Admin > System preferences > MarcFieldsToOrder
- check there is no string like "When there is no mapping for price, Koha will use 345$c and 020$c for MARC21 records and 345$c and 010$c for UNIMARC records"

-apply patch
- verify there is the string
Comment 2 Andrew Fuerste-Henry 2025-02-28 13:16:21 UTC
Created attachment 178819 [details] [review]
Bug 38989: Updated system preference text of MarcFieldsToOrder

Updates system preference text MarcFieldsToOrder by adding string "When there is no mapping for price, Koha will use 345$c and 020$c for MARC21 records and 345$c and 010$c for UNIMARC records"

to test:
- go to Admin > System preferences > MarcFieldsToOrder
- check there is no string like "When there is no mapping for price, Koha will use 345$c and 020$c for MARC21 records and 345$c and 010$c for UNIMARC records"

-apply patch
- verify there is the string

Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com>
Comment 3 Lucas Gass (lukeg) 2025-02-28 15:32:33 UTC
Created attachment 178851 [details] [review]
Bug 38989: Updated system preference text of MarcFieldsToOrder

Updates system preference text MarcFieldsToOrder by adding string "When there is no mapping for price, Koha will use 345$c and 020$c for MARC21 records and 345$c and 010$c for UNIMARC records"

to test:
- go to Admin > System preferences > MarcFieldsToOrder
- check there is no string like "When there is no mapping for price, Koha will use 345$c and 020$c for MARC21 records and 345$c and 010$c for UNIMARC records"

-apply patch
- verify there is the string

Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 4 Katrin Fischer 2025-03-07 17:04:24 UTC
Pushed for 25.05!

Well done everyone, thank you!
Comment 5 Fridolin Somers 2025-08-04 09:59:07 UTC
Enhancement not pushed to 24.11.x