Bug 38989 - Note hard-coded price checks in MarcFieldsToOrder system preference text
Summary: Note hard-coded price checks in MarcFieldsToOrder system preference text
Status: Pushed to main
Alias: None
Product: Koha
Classification: Unclassified
Component: System Administration (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Nicolas Hunstein
QA Contact: Lucas Gass (lukeg)
URL:
Keywords: Academy
Depends on:
Blocks:
 
Reported: 2025-01-28 19:20 UTC by Andrew Fuerste-Henry
Modified: 2025-03-07 17:04 UTC (History)
3 users (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: String patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
25.05.00
Circulation function:


Attachments
Bug 38989: Updated system preference text of MarcFieldsToOrder (1.76 KB, patch)
2025-02-28 12:26 UTC, Nicolas Hunstein
Details | Diff | Splinter Review
Bug 38989: Updated system preference text of MarcFieldsToOrder (1.82 KB, patch)
2025-02-28 13:16 UTC, Andrew Fuerste-Henry
Details | Diff | Splinter Review
Bug 38989: Updated system preference text of MarcFieldsToOrder (1.88 KB, patch)
2025-02-28 15:32 UTC, Lucas Gass (lukeg)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Fuerste-Henry 2025-01-28 19:20:45 UTC
MarcFieldsToOrder allows the user to indicate a MARC field in which Koha should look for a price when creating orders from staged MARC files. Without defining anything here, Koha will check the 345$c and 020$c for MARC21 records and the 345$c and 010$c for UNIMARC records. It'd be helpful to include that in the system preference text.
Comment 1 Nicolas Hunstein 2025-02-28 12:26:59 UTC
Created attachment 178818 [details] [review]
Bug 38989: Updated system preference text of MarcFieldsToOrder

Updates system preference text MarcFieldsToOrder by adding string "When there is no mapping for price, Koha will use 345$c and 020$c for MARC21 records and 345$c and 010$c for UNIMARC records"

to test:
- go to Admin > System preferences > MarcFieldsToOrder
- check there is no string like "When there is no mapping for price, Koha will use 345$c and 020$c for MARC21 records and 345$c and 010$c for UNIMARC records"

-apply patch
- verify there is the string
Comment 2 Andrew Fuerste-Henry 2025-02-28 13:16:21 UTC
Created attachment 178819 [details] [review]
Bug 38989: Updated system preference text of MarcFieldsToOrder

Updates system preference text MarcFieldsToOrder by adding string "When there is no mapping for price, Koha will use 345$c and 020$c for MARC21 records and 345$c and 010$c for UNIMARC records"

to test:
- go to Admin > System preferences > MarcFieldsToOrder
- check there is no string like "When there is no mapping for price, Koha will use 345$c and 020$c for MARC21 records and 345$c and 010$c for UNIMARC records"

-apply patch
- verify there is the string

Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com>
Comment 3 Lucas Gass (lukeg) 2025-02-28 15:32:33 UTC
Created attachment 178851 [details] [review]
Bug 38989: Updated system preference text of MarcFieldsToOrder

Updates system preference text MarcFieldsToOrder by adding string "When there is no mapping for price, Koha will use 345$c and 020$c for MARC21 records and 345$c and 010$c for UNIMARC records"

to test:
- go to Admin > System preferences > MarcFieldsToOrder
- check there is no string like "When there is no mapping for price, Koha will use 345$c and 020$c for MARC21 records and 345$c and 010$c for UNIMARC records"

-apply patch
- verify there is the string

Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 4 Katrin Fischer 2025-03-07 17:04:24 UTC
Pushed for 25.05!

Well done everyone, thank you!