Description
Jonathan Druart
2025-01-29 16:05:41 UTC
Created attachment 177316 [details] [review] Bug 38993: Merge 'fetch' directories Why does not alias @fetch work?? Created attachment 177317 [details] [review] Bug 38993: (follow-up) Add 'fetch' alias to rspack config Created attachment 177318 [details] [review] Bug 38993: (follow-up) Add 'fetch' alias to rspack config Created attachment 177337 [details] [review] Bug 38993: Merge 'fetch' directories Created attachment 177338 [details] [review] Bug 38993: (follow-up) Add 'fetch' alias to rspack config Created attachment 177339 [details] [review] Bug 38993: Use the @fetch alias Created attachment 177342 [details] [review] Bug 38993: Use the @fetch alias Created attachment 177343 [details] [review] Bug 38993: Restore add patrons to list Created attachment 177344 [details] [review] Bug 38993: Restore add patrons to list Created attachment 177345 [details] [review] Bug 38993: Merge 'fetch' directories Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> Created attachment 177346 [details] [review] Bug 38993: (follow-up) Add 'fetch' alias to rspack config Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> Created attachment 177347 [details] [review] Bug 38993: Use the @fetch alias Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> Created attachment 177348 [details] [review] Bug 38993: Restore add patrons to list Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> We should then discuss how we want to organize those files. One thing that is wrong is the inconsistency in the use of plural vs singular: additional-fields-api-client.js cover-image-api-client.js patron-api-client.js We first had the modules, and so started with singular. Then we continue with all singular. But at some point plurals got introduced and now it's messy. I would revert to all singular, but that's for another bug report. Rebased version of the patches on my gitlab repo: "bug_38993-rebased". Will attach the patch here soon, but keeping for some auto-rebase tests. (In reply to Jonathan Druart from comment #15) > Rebased version of the patches on my gitlab repo: "bug_38993-rebased". > > Will attach the patch here soon, but keeping for some auto-rebase tests. We are patient :) Created attachment 179100 [details] [review] Bug 38993: Merge 'fetch' directories Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> Created attachment 179101 [details] [review] Bug 38993: (follow-up) Add 'fetch' alias to rspack config Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> Created attachment 179102 [details] [review] Bug 38993: Use the @fetch alias Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> Created attachment 179103 [details] [review] Bug 38993: Restore add patrons to list Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> Created attachment 179106 [details] [review] Bug 38993: Merge 'fetch' directories Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 179107 [details] [review] Bug 38993: (follow-up) Add 'fetch' alias to rspack config Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 179108 [details] [review] Bug 38993: Use the @fetch alias Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 179109 [details] [review] Bug 38993: Restore add patrons to list Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Maybe a quick note about this for devs? (if it doesn't make sense, just refuse keyword) Pushed for 25.05! Well done everyone, thank you! Created attachment 179513 [details] [review] Bug 38993: Fix sysprefs fetch from cypress Conflict between bug 38993 and bug 36025 We pass the token in the header, and retrieve it from the meta tag. Pushed for 25.05! Well done everyone, thank you! Created attachment 179550 [details] [review] Bug 38993: Send CSRF token for Vue fetches We need it for syspref at least. Pushed for 25.05! Well done everyone, thank you! |