Bug 39021

Summary: Badly formatted dropdown on patron account transactions page
Product: Koha Reporter: Owen Leonard <oleonard>
Component: PatronsAssignee: Owen Leonard <oleonard>
Status: Pushed to main --- QA Contact: Nick Clemens (kidclamp) <nick>
Severity: minor    
Priority: P5 - low CC: david, gmcharlt, kyle.m.hall, nick
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
This fixes the misaligned "Email" item on the "Receipt" action dropdown menu for a patron's accounting transactions page in the staff interface (when UseEmailReceipts is set to "Send"). (This is related to the OPAC and staff interface Bootstrap 5 upgrade in Koha 24.11.)
Version(s) released in:
25.05.00
Circulation function:
Bug Depends on: 35402    
Bug Blocks:    
Attachments: Bug 39021: Fix badly formatted dropdown on patron account transactions page
Bug 39021: Fix badly formatted dropdown on patron account transactions page
Bug 39021: Fix badly formatted dropdown on patron account transactions page
Bug 39021: Fix badly formatted dropdown on patron account transactions page

Description Owen Leonard 2025-02-03 18:08:27 UTC
If you have UseEmailReceipts enabled, the "Transactions" page has "receipts" menus for some transactions. In these menus the "email" option is badly formatted.
Comment 1 Owen Leonard 2025-02-03 18:40:59 UTC
Created attachment 177475 [details] [review]
Bug 39021: Fix badly formatted dropdown on patron account transactions page

This patch makes minor markup changes in order for the "Email" menu item
to be styled correctly after the Bootstrap upgrade. The patch also
simplifies the submission of the form by removing unnecessary JS event
handling.

To test, apply the patch and locate a patron record to view.

- Open the "Accounting" tab
- Click "Create manual invoice"
- Put a charge on the patron's account and click "Save and pay"
- Pay the charge
- Click "Transactions"
  - In the "Actions" column there should be a "Receipt" menu.
  - The "Email" item should be correctly formatted, matching the "Print"
    entry.
  - Clicking "Email" should result in the page refreshing, with the
    message "Receipt sent" at the top.
  - If you don't have email set up you can confirm that the message was
    queued by creating an SQL report: "SELECT * FROM `message_queue`"
  - The report should show the message with the receipt you emailed.

Sponsored-by: Athens County Public Libraries
Comment 2 David Nind 2025-02-03 21:50:17 UTC
Created attachment 177489 [details] [review]
Bug 39021: Fix badly formatted dropdown on patron account transactions page

This patch makes minor markup changes in order for the "Email" menu item
to be styled correctly after the Bootstrap upgrade. The patch also
simplifies the submission of the form by removing unnecessary JS event
handling.

To test, apply the patch and locate a patron record to view.

- Open the "Accounting" tab
- Click "Create manual invoice"
- Put a charge on the patron's account and click "Save and pay"
- Pay the charge
- Click "Transactions"
  - In the "Actions" column there should be a "Receipt" menu.
  - The "Email" item should be correctly formatted, matching the "Print"
    entry.
  - Clicking "Email" should result in the page refreshing, with the
    message "Receipt sent" at the top.
  - If you don't have email set up you can confirm that the message was
    queued by creating an SQL report: "SELECT * FROM `message_queue`"
  - The report should show the message with the receipt you emailed.

Sponsored-by: Athens County Public Libraries
Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Nick Clemens (kidclamp) 2025-02-07 13:11:42 UTC Comment hidden (obsolete)
Comment 4 Owen Leonard 2025-02-12 14:27:19 UTC
Created attachment 177919 [details] [review]
Bug 39021: Fix badly formatted dropdown on patron account transactions page

This patch makes minor markup changes in order for the "Email" menu item
to be styled correctly after the Bootstrap upgrade. The patch also
simplifies the submission of the form by removing unnecessary JS event
handling.

To test, apply the patch and locate a patron record to view.

- Open the "Accounting" tab
- Click "Create manual invoice"
- Put a charge on the patron's account and click "Save and pay"
- Pay the charge
- Click "Transactions"
  - In the "Actions" column there should be a "Receipt" menu.
  - The "Email" item should be correctly formatted, matching the "Print"
    entry.
  - Clicking "Email" should result in the page refreshing, with the
    message "Receipt sent" at the top.
  - If you don't have email set up you can confirm that the message was
    queued by creating an SQL report: "SELECT * FROM `message_queue`"
  - The report should show the message with the receipt you emailed.

Sponsored-by: Athens County Public Libraries
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 5 Katrin Fischer 2025-02-13 15:20:34 UTC
Pushed for 25.05!

Well done everyone, thank you!