Bug 39025

Summary: Update patron account templates to use old_issue_id to display circ info
Product: Koha Reporter: Andrew Fuerste-Henry <andrew>
Component: Fines and feesAssignee: Andrew Fuerste-Henry <andrew>
Status: Signed Off --- QA Contact: Testopia <testopia>
Severity: major    
Priority: P5 - low Keywords: regression
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:
Bug Depends on: 22421    
Bug Blocks:    
Attachments: Bug 39025: Use old_issue_id for issue details on patron account screens
Bug 39025: Use old_issue_id for issue details on patron account screens

Description Andrew Fuerste-Henry 2025-02-03 21:28:18 UTC
In Bug 22421 we created accountlines.old_issue_id to hold the issue_id of a finished issue in a way that folllows foreign key constraints. 

But in boraccount.tt and pay.tt we use issue_id to pull checkout information related to the fee. We need to update those templates to use old_issue_id where it exists. Currently any fee associated with a completed checkout will not show and due date, return date, etc.
Comment 1 Andrew Fuerste-Henry 2025-02-04 13:17:05 UTC
Created attachment 177506 [details] [review]
Bug 39025: Use old_issue_id for issue details on patron account screens

To test:
1: Have an item that is checked out, overdue, and showing an accruing fine
2: On the patron account, check both Make A Payment and Transactions tabs, confirm that the fine shows Due Date, Checkout Date, and Checked Out From values
3: Check your item in
4: Reload the patron account, confirm that the fine no longer shows checkout data on either Make A Payment or Transactions
5: Apply patch
6: Reload pages, confirm Make A Payment and Transactions tabs now show values in Due Date, Checkin Date, Checkout Date, and Checked Out From
Comment 2 Roman Dolny 2025-02-04 17:55:21 UTC
Created attachment 177513 [details] [review]
Bug 39025: Use old_issue_id for issue details on patron account screens

To test:
1: Have an item that is checked out, overdue, and showing an accruing fine
2: On the patron account, check both Make A Payment and Transactions tabs, confirm that the fine shows Due Date, Checkout Date, and Checked Out From values
3: Check your item in
4: Reload the patron account, confirm that the fine no longer shows checkout data on either Make A Payment or Transactions
5: Apply patch
6: Reload pages, confirm Make A Payment and Transactions tabs now show values in Due Date, Checkin Date, Checkout Date, and Checked Out From

Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>